[Bug 21503] New: Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Bug ID: 21503 Summary: Update AuthorisedValues.pm to fall back to code if description doesn't exist Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org If depending on AuthorisedValues.pm (sub GetDescriptionByKohaField) for an authorised value, if a description doesn't exist, the description is left blank instead of failing to code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80151&action=edit Bug 21503: Fail authorised vaulues better/to code To Test (Test both detail.pl and opac-detail.pl for functionality): 1) Apply patch (restart_all) 2) Look up an item that has a shelving location with a description defined (opac description too). 3) Remove opac description from shelving location. Refresh opac-detail.pl and note that description fails back to the regular description. Refresh detail.pl and note no change. 4) Remove regular description from shelving location. Refresh opac-detail.pl and detail.pl. Note that both default to the shelving location code. 5) Remove the shelving location from the LOC table all together. Refresh opac-detail.pl and detail.pl. Note that both default to a blank shelving location. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80152&action=edit Bug 21503: Fail authorised values better/to code To Test (Test both detail.pl and opac-detail.pl for functionality): 1) Apply patch (restart_all) 2) Look up an item that has a shelving location with a description defined (opac description too). 3) Remove opac description from shelving location. Refresh opac-detail.pl and note that description fails back to the regular description. Refresh detail.pl and note no change. 4) Remove regular description from shelving location. Refresh opac-detail.pl and detail.pl. Note that both default to the shelving location code. 5) Remove the shelving location from the LOC table all together. Refresh opac-detail.pl and detail.pl. Note that both default to a blank shelving location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cbrannon@cdalibrary.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80151|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18355 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 80233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80233&action=edit Bug 21503: Tests for the existing behaviour This patch introduces tests for the current behaviour for the AuthorisedValues template plugin. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t => SUCCESS: Tests pass, all green! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I'd flush the cache again at the end of the tests to avoid side-effects in the following tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80233|0 |1 is obsolete| | --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80439&action=edit Bug 21503: Tests for the exiting behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80233|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- Tomas, I have either failed at writing a good test or failed at my patch. Would you take a look a the test and tell me what you think. It seems to fail where it should with the master, but it is failing in other ways with the patch, yet the patch does what it is supposed to. So, I don't know where I have gone astray. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- Tomas, see comment 6. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Christopher Brannon from comment #6)
Tomas, I have either failed at writing a good test or failed at my patch. Would you take a look a the test and tell me what you think. It seems to fail where it should with the master, but it is failing in other ways with the patch, yet the patch does what it is supposed to. So, I don't know where I have gone astray.
I wrote tests for the existing behavior, trying to cover all the use cases. The last two tests are for the situation in which the requested av doesn't exist. What I understand is that you want to change the behavior so those two tests return the passed value instead of the empty string. So all you need to do (if I didn't miss something) is change those two tests, so they 'expect' the result is the passed value. We can talk about it tomorrow! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80439|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80439|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80152|0 |1 is obsolete| | Attachment #80233|0 |1 is obsolete| | Attachment #80439|0 |1 is obsolete| | --- Comment #9 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80521&action=edit Bug 21503: Tests for the existing behavior This patch introduces 7 tests for the current behaviour for the AuthorisedValues template plugin. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t => SUCCESS: Tests pass, all green! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80521|0 |1 is obsolete| | --- Comment #10 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80544&action=edit Bug 21503: Tests for the existing behavior This patch introduces 7 tests for the current behaviour for the AuthorisedValues template plugin. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t => SUCCESS: Tests pass, all green! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80544|0 |1 is obsolete| | --- Comment #11 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80545&action=edit Bug 21503: Tests for the existing behavior This patch introduces 7 tests for the current behaviour for the AuthorisedValues template plugin. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t => SUCCESS: Tests pass, all green! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #12 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80558&action=edit Bug 21503: Fix AV to fail to other values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80545|0 |1 is obsolete| | --- Comment #13 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80561&action=edit Bug 21503: Tests for the existing behavior This patch introduces 7 tests for the current behaviour for the AuthorisedValues template plugin. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t => SUCCESS: Tests pass, all green! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80558|0 |1 is obsolete| | --- Comment #14 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80562&action=edit Bug 21503: Fix AV to fail to other values To Test (Test both detail.pl and opac-detail.pl for functionality): 1) Apply patch (restart_all) 2) Look up an item that has a shelving location with a description defined (opac description too). 3) Remove opac description from shelving location. Refresh opac-detail.pl and note that description fails back to the regular description. Refresh detail.pl and note no change. 4) Remove regular description from shelving location. Refresh opac-detail.pl and detail.pl. Note that both default to the shelving location code. 5) Remove the shelving location from the LOC table all together. Refresh opac-detail.pl and detail.pl. Note that both default to the requested selving location code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80562|0 |1 is obsolete| | --- Comment #15 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80563&action=edit Bug 21503: Fix AV to fail to other values To Test (Test both detail.pl and opac-detail.pl for functionality): 1) Apply patch (restart_all) 2) Look up an item that has a shelving location with a description defined (opac description too). 3) Remove opac description from shelving location. Refresh opac-detail.pl and note that description fails back to the regular description. Refresh detail.pl and note no change. 4) Remove regular description from shelving location. Refresh opac-detail.pl and detail.pl. Note that both default to the shelving location code. 5) Remove the shelving location from the LOC table all together. Refresh opac-detail.pl and detail.pl. Note that both default to the requested shelving location code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80601&action=edit Bug 21503: Tests cleanup and highlight a missing case This patch does the following changes: - Use build_object to create the MSS - Store the generate AVs. That was not the case before and so we were not testing the right things - Split the tests into 2 parts: staff and OPAC, for readability - Update the tests' descriptions - Highlight a problem: If descriptions are missing for both OPAC and staff, undef is returned. Is that what we expect? It seems that it is not what were expecting the tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Christopher, 2 things: - I think I found a missing case in the previous patches - You should not modify the patch from someone else. If you want to add/remove/alter lines from a previous patch you should attach a new patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #18 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Jonathan Druart from comment #16)
Created attachment 80601 [details] [review] Bug 21503: Tests cleanup and highlight a missing case
This patch does the following changes: - Use build_object to create the MSS - Store the generate AVs. That was not the case before and so we were not testing the right things - Split the tests into 2 parts: staff and OPAC, for readability - Update the tests' descriptions - Highlight a problem: If descriptions are missing for both OPAC and staff, undef is returned. Is that what we expect? It seems that it is not what were expecting the tests.
Perhaps the problem was with the fact that we weren't testing the right things? I could not get a test cast to return null or empty if the authorised_value didn't exist. It seemed to always return the authorised_value if there was nothing eles. I assumed it was the non-existant parameter being searched, and so I left it at that. Thank you for your help. This is the firt time I've touched a unit test. I think the expectation is that if there are no descriptions, then the authorised_value is displayed. If there is no av, then it should either return the parameter that was searched or be blank. Not sure which. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #19 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Jonathan Druart from comment #17)
Hi Christopher, 2 things: - I think I found a missing case in the previous patches - You should not modify the patch from someone else. If you want to add/remove/alter lines from a previous patch you should attach a new patch
I had removed that case, because I could not get it to ever be true. Perhaps you fixed this. I will check things. Sorry, I didn't know. I'll be more careful. Tomas made the patch as an example for me, since this was my first time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #20 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80758&action=edit Bug 21503: Tests clarification for debugging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #21 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80759&action=edit Bug 21503: Changed logic for checking values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #22 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80762&action=edit Bug 21503: Simplify If Else logic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80561|0 |1 is obsolete| | --- Comment #23 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 101323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101323&action=edit Bug 21503: Tests for the existing behavior This patch introduces 7 tests for the current behaviour for the AuthorisedValues template plugin. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t => SUCCESS: Tests pass, all green! Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80563|0 |1 is obsolete| | --- Comment #24 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 101324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101324&action=edit Bug 21503: Fix AV to fail to other values To Test (Test both detail.pl and opac-detail.pl for functionality): 1) Apply patch (restart_all) 2) Look up an item that has a shelving location with a description defined (opac description too). 3) Remove opac description from shelving location. Refresh opac-detail.pl and note that description fails back to the regular description. Refresh detail.pl and note no change. 4) Remove regular description from shelving location. Refresh opac-detail.pl and detail.pl. Note that both default to the shelving location code. 5) Remove the shelving location from the LOC table all together. Refresh opac-detail.pl and detail.pl. Note that both default to the requested shelving location code. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80601|0 |1 is obsolete| | --- Comment #25 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 101325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101325&action=edit Bug 21503: Tests cleanup and highlight a missing case This patch does the following changes: - Use build_object to create the MSS - Store the generate AVs. That was not the case before and so we were not testing the right things - Split the tests into 2 parts: staff and OPAC, for readability - Update the tests' descriptions - Highlight a problem: If descriptions are missing for both OPAC and staff, undef is returned. Is that what we expect? It seems that it is not what were expecting the tests. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80758|0 |1 is obsolete| | --- Comment #26 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 101326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101326&action=edit Bug 21503: Tests clarification for debugging Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80759|0 |1 is obsolete| | --- Comment #27 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 101327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101327&action=edit Bug 21503: Changed logic for checking values Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80762|0 |1 is obsolete| | --- Comment #28 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 101328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101328&action=edit Bug 21503: Simplify If Else logic Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #29 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Works as expected. This behavior makes sense to me. Note for QA : Some lines are missing ending ";"non ? Like : return $av_check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101323|0 |1 is obsolete| | Attachment #101324|0 |1 is obsolete| | Attachment #101325|0 |1 is obsolete| | Attachment #101326|0 |1 is obsolete| | Attachment #101327|0 |1 is obsolete| | Attachment #101328|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101524&action=edit Bug 21503: Tests for the existing behavior This patch introduces 7 tests for the current behaviour for the AuthorisedValues template plugin. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t => SUCCESS: Tests pass, all green! Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101525&action=edit Bug 21503: Fix AV to fail to other values To Test (Test both detail.pl and opac-detail.pl for functionality): 1) Apply patch (restart_all) 2) Look up an item that has a shelving location with a description defined (opac description too). 3) Remove opac description from shelving location. Refresh opac-detail.pl and note that description fails back to the regular description. Refresh detail.pl and note no change. 4) Remove regular description from shelving location. Refresh opac-detail.pl and detail.pl. Note that both default to the shelving location code. 5) Remove the shelving location from the LOC table all together. Refresh opac-detail.pl and detail.pl. Note that both default to the requested shelving location code. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101526&action=edit Bug 21503: Tests cleanup and highlight a missing case This patch does the following changes: - Use build_object to create the MSS - Store the generate AVs. That was not the case before and so we were not testing the right things - Split the tests into 2 parts: staff and OPAC, for readability - Update the tests' descriptions - Highlight a problem: If descriptions are missing for both OPAC and staff, undef is returned. Is that what we expect? It seems that it is not what were expecting the tests. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101527&action=edit Bug 21503: Tests clarification for debugging Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101528&action=edit Bug 21503: Changed logic for checking values Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Bug 21503: Simplify If Else logic Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101529&action=edit Bug 21503: Restore existing ternary operator logic This syntax is much more readable IMO. Precendent patch also missed the case where the parameter was undef. I think we are good now. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101527|0 |1 is obsolete| | Attachment #101528|0 |1 is obsolete| | Attachment #101529|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101533&action=edit Bug 21503: Tests clarification for debugging Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101534&action=edit Bug 21503: Changed logic for checking values Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Bug 21503: Simplify If Else logic Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101535&action=edit Bug 21503: Restore existing ternary operator logic This syntax is much more readable IMO. Precendent patch also missed the case where the parameter was undef. I think we are good now. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #40 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org