[Bug 8818] New: Authority linker error on Z cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 Priority: P5 - low Change sponsored?: --- Bug ID: 8818 CC: jcamins@cpbibliography.com, m.de.rooy@rijksmuseum.nl Assignee: gmcharlt@gmail.com Summary: Authority linker error on Z cataloging Severity: critical Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha I was cataloging a new book today. I followed these steps: 1. Z39 search of LOC 2. Choose title 3. Add summary 520 4. Add url 856 5. Choose authority for author 100 6. Hit save I got this error: Software error: Can't locate object method "new" via package "C4::Linker::FirstMatch" (perhaps you forgot to load "C4::Linker::FirstMatch"?) at /home/nengard/kohaclone/C4/Biblio.pm line 503. For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- I tried again skipping steps 3-5 and still get the same error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Finally I changed my linker settings and just got a different error: Software error: Can't locate object method "new" via package "C4::Linker::Default" (perhaps you forgot to load "C4::Linker::Default"?) at /home/nengard/kohaclone/C4/Biblio.pm line 503. For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12511&action=edit Bug 8818: make sure we load modules before using them An eval { eval "require $module;" }; was replaced with eval { eval { require $module; }; }; which is a no-op, meaning that the linker was not getting loaded, and the catalog module was throwing up a big nasty error every time someone tried to save a record with a heading. This patch replaces the require with can_load from Module::Load::Conditional, which is PBP-friendly, and offers equivalent functionality. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12511|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12512&action=edit [SIGNED-OFF] Bug 8818: make sure we load modules before using them An eval { eval "require $module;" }; was replaced with eval { eval { require $module; }; }; which is a no-op, meaning that the linker was not getting loaded, and the catalog module was throwing up a big nasty error every time someone tried to save a record with a heading. This patch replaces the require with can_load from Module::Load::Conditional, which is PBP-friendly, and offers equivalent functionality. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8829 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #4)
Created attachment 12512 [details] [SIGNED-OFF] Bug 8818: make sure we load modules before using them
patch looks good, passing QA $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit eb6effd) * 0a60190 Bug 8818: make sure we load modules before using them C4/Biblio.pm misc/link_bibs_to_authorities.pl * C4/Biblio.pm OK * misc/link_bibs_to_authorities.pl OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- updating severity since I can't catalog at all until this is pushed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org