[Bug 8737] New: Incorrect icon at login in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8737 Priority: P5 - low Change sponsored?: --- Bug ID: 8737 Assignee: oleonard@myacpl.org Summary: Incorrect icon at login in staff client Severity: enhancement Classification: Unclassified OS: All Reporter: mtompset@hotmail.com Hardware: All Status: NEW Version: unspecified Component: Templates Product: Koha Problem: despite setting the syspref for IntranetFavicon and doing several refreshes, the default koha icon shows in my firefox tab. Test: 1) Go to koha staff client to log in. The default green box k logo should be in the browsers tab. 2) Log in. 3) If it is still the default: 3-1) click "Koha Administration" 3-2) click "Global system preferences" 3-3) click on the "Staff client" tab near the bottom left of the page 3-4) In the "Appearance" section, modified the "IntranetFavicon" system preference to point a different icon. 3-5) scroll down and click 'Save all staff client preferences' 3-6) log out 3-7) log in 4) It should now be a different icon. 5) log out. It should now be the default icon, not the same one as logged in. Before coming upon what I am going to attach as a solution, I was looking in Template. jcamins commented out a section of code that I was going to add to as a solution, so I figured that wouldn't be a good solution. I then checked to see if it worked for OPAC. It did, so something must have the right code for Opac, but have forgotten the Intranet. Pre-solution hunt: 1) cd kohaclone 2) grep OpacFavicon `find . -name "*.p[lm]"` 3) grep IntranetFavicon `find . -name "*.p[lm]"` 4) Note there are two entries for OpacFavicon in C4/Auth.pm, but only one IntranetFavicon entry So looking at around line 949 which is in the "AUTH rejected" section, I found both OPAC and Intranet variables were being set, but the IntranetFavicon was missing. NOTE: Someone more familiar with expected environment variables should check if anything else is missing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8737 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |mtompset@hotmail.com --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 12032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12032&action=edit Sets missing environment variable so correct icon is displayed. I initially did a tarball install of 3.6.3 and hacked the template files to get it right. This patch against master should be the correct solution to the problem. This problem exists in 3.6.X and I believe 3.8.X as well. I followed the simple steps given in my previous comments to confirm after applying the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8737 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12032|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12046&action=edit Bug 8737 - Incorrect icon at login in staff client Added the following missing code to ensure the correct icon is used when logged out: IntranetFavicon => C4::Context->preference('IntranetFavicon') This was added into an existing $template->param() call. Not to be confused with the koha logo on the login page, the icon is a 16x16 pixel graphic in the browser tab. The default is found at .../intranet-tmpl/prog/en/includes/favicon.ico. If the "IntranetFavicon" system preference is set, it should be used by the staff client regardless of login state. It was not being used in the "AUTH rejected" section of Auth.pm, but the OpacFavicon variable was being set. This explains why the "OpacFavicon" system preference works for the OPAC client, but not the staff client upon logout. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8737 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8737 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Version|unspecified |rel_3_8 Severity|enhancement |minor --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8737 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- More a minor bugfix than an ENH. Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8737 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.12 (was released with 3.10.0) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org