[Bug 35205] New: Fix duplicate id attribute in desks search form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Bug ID: 35205 Summary: Fix duplicate id attribute in desks search form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The header search form for circulation desks has an id attribute which is a duplicate of one on the desks entry form. That means that when you're adding a desk, clicking the "Desk name" label moves the cursor focus to the header search form instead of the field in the entry form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158144&action=edit Bug 35205: Fix duplicate id attribute in desks search form This patch updates the header search form for desks administration so that it doesn't contain an HTML id attribute which duplicates one on the desks entry form. To test, apply the patch and make sure the "UseCirculationDesks" system preference is enabled. - Go to Administration -> Circulation desks -> New desk. - Click the "Desk" label in the entry form. Cursor focus should move to the adjacent input field. - Click the "Search desks" label in the header search form to confirm that your cursor moves to the header search form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158144|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 158227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158227&action=edit Bug 35205: Fix duplicate id attribute in desks search form This patch updates the header search form for desks administration so that it doesn't contain an HTML id attribute which duplicates one on the desks entry form. To test, apply the patch and make sure the "UseCirculationDesks" system preference is enabled. - Go to Administration -> Circulation desks -> New desk. - Click the "Desk" label in the entry form. Cursor focus should move to the adjacent input field. - Click the "Search desks" label in the header search form to confirm that your cursor moves to the header search form. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158227|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158391&action=edit Bug 35205: Fix duplicate id attribute in desks search form This patch updates the header search form for desks administration so that it doesn't contain an HTML id attribute which duplicates one on the desks entry form. To test, apply the patch and make sure the "UseCirculationDesks" system preference is enabled. - Go to Administration -> Circulation desks -> New desk. - Click the "Desk" label in the entry form. Cursor focus should move to the adjacent input field. - Click the "Search desks" label in the header search form to confirm that your cursor moves to the header search form. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |34624 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 34624 which added for="desk_name" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 [Bug 34624] Many header search forms lack for attribute for label -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Bug 35205 depends on bug 34624, which changed state. Bug 34624 Summary: Many header search forms lack for attribute for label https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org