[Bug 34624] New: Many header search forms lack for attribute for label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Bug ID: 34624 Summary: Many header search forms lack for attribute for label Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: accessibility Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org In the header search forms, we have a label which is associated with the form field, but in many cases the label doesn't have a "for" attribute. This is a problem for HTML validity and for accessibility. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154843&action=edit Bug 34624: Add "for" attribute to label in header search forms which lack it This patch adds a "for" label to header search forms labels which lack it. To test, apply the patch and test the affected pages to confirm that clicking the label corresponding to the active search form can be clicked to move cursor focus to that input field. As you activate each search form, the cursor focus will automatically be moved to the input. Click outside of the field to remove the focus, and then click the label to test that it is correctly tied to the field. - Staff interface home page: - Checkout, Check in, Renew, Search patrons, and Search catalog. - Acquisitions: Vendor search and orders search - Acquisitions -> Vendor search -> Vendor -> Contracts: Contract search - Acquisitions -> Vendor search -> Vendor -> Basket -> Add to basket -> From a suggestion: Search suggestions - Authorities: Main heading ($a only), Main heading, All headings, and Entire record. - Administration -> Budgets: Search funds - Administration -> Cities & towns: City search - Administration -> Currencies: Currencies search - Administration -> Desks: Search desks * With UseCirculationDesks enabled - Administration -> Patron categories: Search patron categories - Administration -> System preferences: Search system preferences - Administration -> Z39.50 servers -> Z39.50 server search - Cataloging: Cataloging search - E-resource management: Search agreements, Search licenses, Search packages, and Search titles * With ERMModule enabled - Patrons -> Search patrons - Serials: Search subscriptions - Tools -> Notices & slips: Search notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154843|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154879&action=edit Bug 34624: Add "for" attribute to label in header search forms which lack it This patch adds a "for" label to header search forms labels which lack it. To test, apply the patch and test the affected pages to confirm that clicking the label corresponding to the active search form can be clicked to move cursor focus to that input field. As you activate each search form, the cursor focus will automatically be moved to the input. Click outside of the field to remove the focus, and then click the label to test that it is correctly tied to the field. - Staff interface home page: - Checkout, Check in, Renew, Search patrons, and Search catalog. - Acquisitions: Vendor search and orders search - Acquisitions -> Vendor search -> Vendor -> Contracts: Contract search - Acquisitions -> Vendor search -> Vendor -> Basket -> Add to basket -> From a suggestion: Search suggestions - Authorities: Main heading ($a only), Main heading, All headings, and Entire record. - Administration -> Budgets: Search funds - Administration -> Cities & towns: City search - Administration -> Currencies: Currencies search - Administration -> Desks: Search desks * With UseCirculationDesks enabled - Administration -> Patron categories: Search patron categories - Administration -> System preferences: Search system preferences - Administration -> Z39.50 servers -> Z39.50 server search - Cataloging: Cataloging search - E-resource management: Search agreements, Search licenses, Search packages, and Search titles * With ERMModule enabled - Patrons -> Search patrons - Serials: Search subscriptions - Tools -> Notices & slips: Search notices Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I wonder if we should/could just merge all these *-search.inc files into a single one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154879|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155150&action=edit Bug 34624: Add "for" attribute to label in header search forms which lack it This patch adds a "for" label to header search forms labels which lack it. To test, apply the patch and test the affected pages to confirm that clicking the label corresponding to the active search form can be clicked to move cursor focus to that input field. As you activate each search form, the cursor focus will automatically be moved to the input. Click outside of the field to remove the focus, and then click the label to test that it is correctly tied to the field. - Staff interface home page: - Checkout, Check in, Renew, Search patrons, and Search catalog. - Acquisitions: Vendor search and orders search - Acquisitions -> Vendor search -> Vendor -> Contracts: Contract search - Acquisitions -> Vendor search -> Vendor -> Basket -> Add to basket -> From a suggestion: Search suggestions - Authorities: Main heading ($a only), Main heading, All headings, and Entire record. - Administration -> Budgets: Search funds - Administration -> Cities & towns: City search - Administration -> Currencies: Currencies search - Administration -> Desks: Search desks * With UseCirculationDesks enabled - Administration -> Patron categories: Search patron categories - Administration -> System preferences: Search system preferences - Administration -> Z39.50 servers -> Z39.50 server search - Cataloging: Cataloging search - E-resource management: Search agreements, Search licenses, Search packages, and Search titles * With ERMModule enabled - Patrons -> Search patrons - Serials: Search subscriptions - Tools -> Notices & slips: Search notices Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34707 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 155286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155286&action=edit Bug 34624: (follow-up) fix broken <span> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | CC| |victor@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- QA in progress: code looks good, test plan lists all the relevant pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- All good except "- Serials: Search subscriptions" There is no "for", where should it point to? On page load, focus is on ISSN, should it be the same or does Title makes more sense there? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155394&action=edit Bug 34624: (follow-up) Add "for" attribute to serials-search.inc label -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155150|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155412&action=edit Bug 34624: Add "for" attribute to label in header search forms which lack it This patch adds a "for" label to header search forms labels which lack it. To test, apply the patch and test the affected pages to confirm that clicking the label corresponding to the active search form can be clicked to move cursor focus to that input field. As you activate each search form, the cursor focus will automatically be moved to the input. Click outside of the field to remove the focus, and then click the label to test that it is correctly tied to the field. - Staff interface home page: - Checkout, Check in, Renew, Search patrons, and Search catalog. - Acquisitions: Vendor search and orders search - Acquisitions -> Vendor search -> Vendor -> Contracts: Contract search - Acquisitions -> Vendor search -> Vendor -> Basket -> Add to basket -> From a suggestion: Search suggestions - Authorities: Main heading ($a only), Main heading, All headings, and Entire record. - Administration -> Budgets: Search funds - Administration -> Cities & towns: City search - Administration -> Currencies: Currencies search - Administration -> Desks: Search desks * With UseCirculationDesks enabled - Administration -> Patron categories: Search patron categories - Administration -> System preferences: Search system preferences - Administration -> Z39.50 servers -> Z39.50 server search - Cataloging: Cataloging search - E-resource management: Search agreements, Search licenses, Search packages, and Search titles * With ERMModule enabled - Patrons -> Search patrons - Serials: Search subscriptions - Tools -> Notices & slips: Search notices Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155286|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155413&action=edit Bug 34624: (follow-up) fix broken <span> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155394|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155414&action=edit Bug 34624: (follow-up) Add "for" attribute to serials-search.inc label Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|victor@tuxayo.net |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looking good, thanks Owen. QA scripts happy, no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Great, thanks all :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply on 23.05.x, surely because not having Bug 32910 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Is there interest in having this backported? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It would be great to see this accessibility improvement backported.. but I've not actually seen it hit am accessibility assessment report yet.. so it really depends if it's much work or not.. I'm sure we could wait for it here at least 😉 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157070&action=edit Bug 34624: [23.05.x] Add "for" attribute to label in header search forms which lack it This patch adds a "for" label to header search forms labels which lack it. To test, apply the patch and test the affected pages to confirm that clicking the label corresponding to the active search form can be clicked to move cursor focus to that input field. As you activate each search form, the cursor focus will automatically be moved to the input. Click outside of the field to remove the focus, and then click the label to test that it is correctly tied to the field. - Staff interface home page: - Checkout, Check in, Renew, Search patrons, and Search catalog. - Acquisitions: Vendor search and orders search - Acquisitions -> Vendor search -> Vendor -> Contracts: Contract search - Acquisitions -> Vendor search -> Vendor -> Basket -> Add to basket -> From a suggestion: Search suggestions - Authorities: Main heading ($a only), Main heading, All headings, and Entire record. - Administration -> Budgets: Search funds - Administration -> Cities & towns: City search - Administration -> Currencies: Currencies search - Administration -> Desks: Search desks * With UseCirculationDesks enabled - Administration -> Patron categories: Search patron categories - Administration -> System preferences: Search system preferences - Administration -> Z39.50 servers -> Z39.50 server search - Cataloging: Cataloging search - E-resource management: Search agreements, Search licenses, Search packages, and Search titles * With ERMModule enabled - Patrons -> Search patrons - Serials: Search subscriptions - Tools -> Notices & slips: Search notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 [Bug 35205] Fix duplicate id attribute in desks search form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.06 released in| | --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org