https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43884 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43884 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 208670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208670&action=edit Bug 43884: Fall back to print in queue_notice when itiva cannot deliver Koha::Patron::queue_notice always skipped the itiva transport when TalkingTechItivaPhoneNotification was enabled, even if the patron has no phone number for TalkingTech_itiva_outbound.pl to call, and queued an itiva notice that nothing would send when the preference was disabled. In both cases the patron got no notice at all. Skip itiva only when the outbound script will handle it, and otherwise fall back to print, matching C4::Reserves::_koha_notify_reserve since bug 43380. Test plan: 1) Apply this patch and restart all the things! 2) Set the TalkingTechItivaPhoneNotification system preference to "Enable" 3) Pick a patron and give them a phone number 4) In the patron's "Messaging" preferences, set the "Hold reminder" notice to "Phone" only (the itiva transport), and save 5) Place a hold for them and check an item in to fill it, so the hold is waiting 6) From the command line, run the hold reminder in test mode: perl misc/cronjobs/holds/holds_reminder.pl -days 0 -v 7) Note nothing is reported for the patron: the Itiva script handles their notice, so there is nothing for Koha to queue and no print fallback 8) Edit the patron, clear the phone number, and run step 6 again 9) Note the patron "would have been sent print fallback for: itiva" 10) Set TalkingTechItivaPhoneNotification to "Disable", restore the phone number and run step 6 again 11) Note the patron "would have been sent print fallback for: itiva" again 12) Run the command once more with -c to really send, and confirm a print "Hold reminder" notice now appears on the patron's "Notices" tab (and that none appeared in step 7's configuration) 13) Run prove t/db_dependent/Koha/Patrons.t 14) Sign off :-D Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43884 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43884 --- Comment #2 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 208715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208715&action=edit Bug 43884: Fall back to print in queue_notice when itiva cannot deliver Koha::Patron::queue_notice always skipped the itiva transport when TalkingTechItivaPhoneNotification was enabled, even if the patron has no phone number for TalkingTech_itiva_outbound.pl to call, and queued an itiva notice that nothing would send when the preference was disabled. In both cases the patron got no notice at all. Skip itiva only when the outbound script will handle it, and otherwise fall back to print, matching C4::Reserves::_koha_notify_reserve since bug 43380. Test plan: 1) Apply this patch and restart all the things! 2) Set the TalkingTechItivaPhoneNotification system preference to "Enable" 3) Pick a patron and give them a phone number 4) In the patron's "Messaging" preferences, set the "Hold reminder" notice to "Phone" only (the itiva transport), and save 5) Place a hold for them and check an item in to fill it, so the hold is waiting 6) From the command line, run the hold reminder in test mode: perl misc/cronjobs/holds/holds_reminder.pl -days 0 -v 7) Note nothing is reported for the patron: the Itiva script handles their notice, so there is nothing for Koha to queue and no print fallback 8) Edit the patron, clear the phone number, and run step 6 again 9) Note the patron "would have been sent print fallback for: itiva" 10) Set TalkingTechItivaPhoneNotification to "Disable", restore the phone number and run step 6 again 11) Note the patron "would have been sent print fallback for: itiva" again 12) Run the command once more with -c to really send, and confirm a print "Hold reminder" notice now appears on the patron's "Notices" tab (and that none appeared in step 7's configuration) 13) Run prove t/db_dependent/Koha/Patrons.t 14) Sign off :-D Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.