https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43884 Bug ID: 43884 Summary: queue_notice does not fall back to print when itiva cannot deliver Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk Depends on: 43380 Target Milestone: --- Bug 43380 made C4::Reserves::_koha_notify_reserve fall back to a print notice when itiva cannot deliver the notice, that is when TalkingTechItivaPhoneNotification is disabled or the patron has no phone number. Koha::Patron::queue_notice still has 'next if $mtt eq itiva && TalkingTechItivaPhoneNotification' with no phone check, so in those cases the notice is silently dropped. This affects overdue, preoverdue and the other notices that go through queue_notice. This bug aligns queue_notice with the hold-filled behaviour and adds tests. Additionally, TalkingTech_itiva_outbound.pl selects rows on the itiva preference only, so patrons with no phone number get a row with a blank phone in the CSV. It should skip rows with an empty borrowers.phone. Test plan: 1. Set TalkingTechItivaPhoneNotification to Enable. 2. Give a patron an overdue notice preference of itiva only, with a phone number set. 3. Trigger the notice (e.g. run overdue_notices.pl) and note no print notice is queued. 4. Clear the patron's phone number and repeat. 5. Note a print notice is queued. 6. Disable TalkingTechItivaPhoneNotification, restore the phone number and repeat. 7. Note a print notice is queued. 8. Run TalkingTech_itiva_outbound.pl and note that rows with no phone number are not output. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43380 [Bug 43380] Koha will generate spurious print notices if itiva is enabled and a patron has only selected phone notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.