[Bug 7695] New: Boolean operator AND in XSLT gets translated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7695 Priority: P5 - low Change sponsored?: --- Bug ID: 7695 Assignee: frederic@tamil.fr Summary: Boolean operator AND in XSLT gets translated QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: magnus@enger.priv.no Hardware: All Status: NEW Version: master Component: I18N/L10N Product: Koha * Problem In koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl (and the corresponding XSLT for the intranet) this: 476 <xsl:with-param name="delimeter"> and </xsl:with-param> gets translated into this, for nb-NO: 476 <xsl:with-param name="delimeter"> og </xsl:with-param> ("og" being Norwegian for "and"), resulting in searches like this, when TraceSubjectSubdivisions is set to "include": (su,complete-subfield:"USA ") og (su,complete-subfield:"Borgerkrigen, 1861-1865") Zebra does not know how to handle "og" as a boolean operator, of course, resulting in zero hits. In the OPAC this can currently be avoided by not translating the string "and ", since this is the only occurrence of that string (but there is one occurrence of "and"), but in the intranet there are three occurrences of "and ", and only one of them is a boolean operator, so you can't just not translate the one place where it is. * One possible solution Since the translation process is case sensitive, but Zebra is not, it might be a way out to change "and" into "AND" in the line above, to make it stand out from the cases where "and" occurs as a regular word. Then we would "just" have to remember not to translate "AND", but just copy it over. Does anyone have a better idea? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7695 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 8346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8346&action=edit Bug 7695 - Change boolean operator from "and" to "AND" When XSLTDetailsDisplay/OPACXSLTDetailsDisplay = on and TraceSubjectSubdivisions = Include, subject sudivisions are combined with the boolean operator "and". Currently, this word is translated along with other occurrences of the same word, resulting in a false "no records found" for users of non-English templates. This patch replaces "and" with "AND" which should have no effect on searching (since Zebra is case-insensitive in this regard) but will make the boolean operator stand out from other uses of "and" in translations. TraceSubjectSubdivisions is currently only implemented in MARC21, so UNIMARC and NORMARC is not affected. To test: XSLTDetailsDisplay/OPACXSLTDetailsDisplay = using XSLT TraceSubjectSubdivisions = Include marcflavour = MARC21 Find a record with a clickable subject that includes one or more subdivisions and check that the subdivisions are combined with "AND", not "and". Check that you get the expected result when clicking on the subject. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7695 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- If this solution is accepted, I'll implement it for NORMARC as part of bug 7537. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7695 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7537 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7695 --- Comment #3 from Magnus Enger <magnus@enger.priv.no> --- This will probably need a rebase if Bug 7092 gets pushed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7695 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8346|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8655&action=edit [SIGNED-OFF] Bug 7695 - Change boolean operator from "and" to "AND" When XSLTDetailsDisplay/OPACXSLTDetailsDisplay = on and TraceSubjectSubdivisions = Include, subject sudivisions are combined with the boolean operator "and". Currently, this word is translated along with other occurrences of the same word, resulting in a false "no records found" for users of non-English templates. This patch replaces "and" with "AND" which should have no effect on searching (since Zebra is case-insensitive in this regard) but will make the boolean operator stand out from other uses of "and" in translations. TraceSubjectSubdivisions is currently only implemented in MARC21, so UNIMARC and NORMARC is not affected. To test: XSLTDetailsDisplay/OPACXSLTDetailsDisplay = using XSLT TraceSubjectSubdivisions = Include marcflavour = MARC21 Find a record with a clickable subject that includes one or more subdivisions and check that the subdivisions are combined with "AND", not "and". Check that you get the expected result when clicking on the subject. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Easy to test and works as advertised. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7695 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Magnus Enger <magnus@enger.priv.no> --- I assume Katrin got thrown off the mobile broadband before she could change the status, so I'm going to change it for her. Correct me if I'm wrong! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7695 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl QA Contact|koha.sekjal@gmail.com |m.de.rooy@rijksmuseum.nl --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Did not test it, but simple change looks good. Pragmatic solution. Updating status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7695 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7695 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7695 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7695 --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org