[Bug 7665] New: Bibs with no ISBN's show broken images for covers when using Syndetics cover images.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7665 Priority: P5 - low Change sponsored?: --- Bug ID: 7665 Assignee: oleonard@myacpl.org Summary: Bibs with no ISBN's show broken images for covers when using Syndetics cover images. QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: wizzyrea@gmail.com Hardware: All Status: NEW Version: rel_3_6 Component: OPAC Product: Koha When using the Syndetics service for enhanced content, bibs that have no ISBN numbers show broken images instead of "no image available" placeholders. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7665 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 8061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8061&action=edit Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images Patch fixes problem for syndetics + bibs with no ISBN. Also adds "no image found" capability to Syndetics results. To test (first, contact me and I will let you use my syndetics credentials *for testing this bug only*): * replicate bug - have a bib with an ISBN, and one without. The one with the ISBN should show a cover, the one without will show a broken image. * apply patch * search for the same bib - you should now see "no image available" for the one with no ISBN, and a cover image for your bib with an ISBN. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7665 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7665 --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Wow, terrible test plan. First, make sure you have all other cover image sources off, and enable all syndetics options. Then, proceed with testing per the plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7665 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8061|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8062&action=edit [SIGNED-OFF] Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images Patch fixes problem for syndetics + bibs with no ISBN. Also adds "no image found" capability to Syndetics results. To test (first, contact me and I will let you use my syndetics credentials *for testing this bug only*): * replicate bug - have a bib with an ISBN, and one without. The one with the ISBN should show a cover, the one without will show a broken image. * apply patch * search for the same bib - you should now see "no image available" for the one with no ISBN, and a cover image for your bib with an ISBN. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7665 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7665 --- Comment #4 from Ian Walls <koha.sekjal@gmail.com> --- Created attachment 8131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8131&action=edit Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images Patch fixes problem for syndetics + bibs with no ISBN. Also adds "no image found" capability to Syndetics results. To test (first, contact me and I will let you use my syndetics credentials *for testing this bug only*): * replicate bug - have a bib with an ISBN, and one without. The one with the ISBN should show a cover, the one without will show a broken image. * apply patch * search for the same bib - you should now see "no image available" for the one with no ISBN, and a cover image for your bib with an ISBN. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Ian Walls <koha.sekjal@gmail.com> QA Comment: normalized spacing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7665 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8062|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7665 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7665 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed, (untested as I don't have syndetics credentials) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7665 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org