[Bug 23433] New: Make consistent use of patron-title.inc in hold confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Bug ID: 23433 Summary: Make consistent use of patron-title.inc in hold confirmation dialogs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 23399 We have inconsistent use of patron-title.inc in returns.tt. Sometimes it is used and sometimes it isn't. Where it was added it seems to have reversed the display of patron surname and first name: Previously last, first; now first last. All uses of patron-title.inc in this situation should be consistent. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 [Bug 23399] Reindent returns.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23399 |23434 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 [Bug 23399] Reindent returns.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 [Bug 23434] Hold confirmation dialog problem if HoldsAutoFill is enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92032&action=edit Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs Use of patron-title.inc on the checkin page is inconsistent, resulting in patron names being displayed differently under different circumstances. This patch makes it more consistent. To test, apply the patch and check in items with the following statuses: - On hold for a patron at your library - On hold for a patron not at your library - On hold and already marked 'Waiting' - On hold while HoldsAutoFill preference is enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Owen, I can no longer cleanly apply this patch to master. If you can rebase it, I will attempt to sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92032|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 100277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100277&action=edit Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs Use of patron-title.inc on the checkin page is inconsistent, resulting in patron names being displayed differently under different circumstances. This patch makes it more consistent. To test, apply the patch and check in items with the following statuses: - On hold for a patron at your library - On hold for a patron not at your library - On hold and already marked 'Waiting' - On hold while HoldsAutoFill preference is enabled - An item which has been marked with a LOST status in the 'ClaimReturnedLostValue' system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- I guess returns.tt is a moving target, sadly this again doesn't apply cleanly. :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100277|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 100916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100916&action=edit Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs Use of patron-title.inc on the checkin page is inconsistent, resulting in patron names being displayed differently under different circumstances. This patch makes it more consistent. To test, apply the patch and check in items with the following statuses: - On hold for a patron at your library - On hold for a patron not at your library - On hold and already marked 'Waiting' - On hold while HoldsAutoFill preference is enabled - An item which has been marked with a LOST status in the 'ClaimReturnedLostValue' system preference. - An item which was checked out to a manually-restricted patron and checked in with a back-dated checkin date. See test plan on Bug 24776. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- These all display the name as (surname, firstname) except when I turn on HoldsAutoFill. It then displays (firstname, surname). Not sure if that matters but wanted to point that out before signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #7 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Yes, I get the same. When HoldsAutoFill is enabled, the 'hold-found1' modal isn't launched. Instead, it's 'dialog alert hold-auto-filled' - and this patch doesn't seem to update that part of returns.tt Once that's done, it'll work perfectly. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100916|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 104028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104028&action=edit Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs Use of patron-title.inc on the checkin page is inconsistent, resulting in patron names being displayed differently under different circumstances. This patch makes it more consistent. To test, apply the patch and check in items with the following statuses: - On hold for a patron at your library - On hold for a patron not at your library - On hold and already marked 'Waiting' - On hold while HoldsAutoFill preference is enabled - An item which has been marked with a LOST status in the 'ClaimReturnedLostValue' system preference. - An item which was checked out to a manually-restricted patron and checked in with a back-dated checkin date. See test plan on Bug 24776. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Thanks to all who tested. I corrected two more sections of the template with the standard configuration of the include. (In reply to Sally from comment #7)
When HoldsAutoFill is enabled, the 'hold-found1' modal isn't launched.
I think this is the correct behavior, because HoldsAutoFill is supposed to minimally interrupt the workflow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 --- Comment #10 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- (In reply to Owen Leonard from comment #9)
Thanks to all who tested. I corrected two more sections of the template with the standard configuration of the include.
(In reply to Sally from comment #7)
When HoldsAutoFill is enabled, the 'hold-found1' modal isn't launched.
I think this is the correct behavior, because HoldsAutoFill is supposed to minimally interrupt the workflow.
It's the right behaviour, I agree - I was just trying to explain what I noticed when the patch didn't work so it would be (hopefully!) easier to identify and fix. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104028|0 |1 is obsolete| | --- Comment #11 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 104105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104105&action=edit Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs Use of patron-title.inc on the checkin page is inconsistent, resulting in patron names being displayed differently under different circumstances. This patch makes it more consistent. To test, apply the patch and check in items with the following statuses: - On hold for a patron at your library - On hold for a patron not at your library - On hold and already marked 'Waiting' - On hold while HoldsAutoFill preference is enabled - An item which has been marked with a LOST status in the 'ClaimReturnedLostValue' system preference. - An item which was checked out to a manually-restricted patron and checked in with a back-dated checkin date. See test plan on Bug 24776. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works great, thanks Owen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104105|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104114&action=edit Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs Use of patron-title.inc on the checkin page is inconsistent, resulting in patron names being displayed differently under different circumstances. This patch makes it more consistent. To test, apply the patch and check in items with the following statuses: - On hold for a patron at your library - On hold for a patron not at your library - On hold and already marked 'Waiting' - On hold while HoldsAutoFill preference is enabled - An item which has been marked with a LOST status in the 'ClaimReturnedLostValue' system preference. - An item which was checked out to a manually-restricted patron and checked in with a back-dated checkin date. See test plan on Bug 24776. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Owen and Sally! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104251&action=edit Bug 23433: (RM follow-up) One last consistency improvement Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #17 from Joy Nelson <joy@bywatersolutions.com> --- doesn't apply cleanly to 19.11.x please rebase if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26961 [Bug 26961] Patron name not shown at checkin if HidePatronName set to "Don't show" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org