https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com, | |josef.moravec@gmail.com, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com Depends on| |24081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 [Bug 24081] Add a 'discount' process to accounts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Did you test this Michal? The original patchset was meant to add such a permission.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100197&action=edit Bug 24812: (bug 24081 follow-up) Add permission description Bug 24081 added a discount permission to the accounts system but during subsequent rebases, the description of that new permission got lot. This patch restores the description. Test plan 0/ Check that a checkbox without a description appears in the 'Manage patrons patrons fines and fees' section of the 'Set permissions' page. 1/ Apply the patch 2/ Reload the page and note that the checkbox now preceeds a suitable description. 3/ Signoff. Bonus points: Check the permission works as described and hides the 'Discount' action button for staff who do not have the permission enabled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100197|0 |1 is obsolete| | --- Comment #5 from Michal Denar <black23@gmail.com> --- Created attachment 100198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100198&action=edit Bug 24812: (bug 24081 follow-up) Add permission description Bug 24081 added a discount permission to the accounts system but during subsequent rebases, the description of that new permission got lot. This patch restores the description. Test plan 0/ Check that a checkbox without a description appears in the 'Manage patrons patrons fines and fees' section of the 'Set permissions' page. 1/ Apply the patch 2/ Reload the page and note that the checkbox now preceeds a suitable description. 3/ Signoff. Bonus points: Check the permission works as described and hides the 'Discount' action button for staff who do not have the permission enabled. Nice work. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100198|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100458&action=edit Bug 24812: (bug 24081 follow-up) Add permission description Bug 24081 added a discount permission to the accounts system but during subsequent rebases, the description of that new permission got lot. This patch restores the description. Test plan 0/ Check that a checkbox without a description appears in the 'Manage patrons patrons fines and fees' section of the 'Set permissions' page. 1/ Apply the patch 2/ Reload the page and note that the checkbox now preceeds a suitable description. 3/ Signoff. Bonus points: Check the permission works as described and hides the 'Discount' action button for staff who do not have the permission enabled. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23442 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 Bug 24812 depends on bug 24081, which changed state. Bug 24081 Summary: Add a 'discount' process to accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.