[Bug 27436] New: Set focus for cursor to report name field when creating new SQL report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Bug ID: 27436 Summary: Set focus for cursor to report name field when creating new SQL report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: barbara.johnson@bedfordtx.gov, gmcharlt@gmail.com, testopia@bugs.koha-community.org When adding a new SQL report you have to tab to or click the report name field. It would be more efficient to set the focus automatically by adding a "focus" class to the <input> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jamespfk@gmail.com Assignee|oleonard@myacpl.org |jamespfk@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 --- Comment #1 from James O'Keeffe <jamespfk@gmail.com> --- Created attachment 115275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115275&action=edit Bug 27436: Set focus for cursor to report name field when creating new SQL report This patch focuses the cursor on the 'Report name' field when creating a new SQL report Test plan: 1. Navigate to the 'Create report from SQL' page (Home -> Reports -> Guided reports Wizard -> Create from SQL) 2. Observe that the 'Report name' box is not focused on 3. Apply the patch, log in, log out. 4. Repeat step 1. The 'Report name' box should now be focused on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115275|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115307&action=edit Bug 27436: Set focus for cursor to report name field when creating new SQL report This patch focuses the cursor on the 'Report name' field when creating a new SQL report Test plan: 1. Navigate to the 'Create report from SQL' page (Home -> Reports -> Guided reports Wizard -> Create from SQL) 2. Observe that the 'Report name' box is not focused on 3. Apply the patch, log in, log out. 4. Repeat step 1. The 'Report name' box should now be focused on. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #3 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115307|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 115573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115573&action=edit Bug 27436: Set focus for cursor to report name field when creating new SQL report This patch focuses the cursor on the 'Report name' field when creating a new SQL report Test plan: 1. Navigate to the 'Create report from SQL' page (Home -> Reports -> Guided reports Wizard -> Create from SQL) 2. Observe that the 'Report name' box is not focused on 3. Apply the patch, log in, log out. 4. Repeat step 1. The 'Report name' box should now be focused on. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- It might be nice to have the sql textarea focused when editing an existing report, but this is a great improvement! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Focus must be put using the "focus" class instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jamespfk@gmail.com |katrin.fischer@bsz-bw.de QA Contact|kyle@bywatersolutions.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115573|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139419&action=edit Bug 27436: Set focus on first input when adding a new SQL report When adding a new SQL report, the focus/cursor should be in the first input field of the form: Report name To test: * Add a new SQL report in reports > new from SQL - cursur is in no field * Apply patch * Add another new SQL report - cursor is now in the first input field of the form: Report name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I implemented the standard solution for setting the focus using the CSS class as suggested in comment#6. As both patches were one line fixes mine replaces James' previous patch. I didn't see a better way, if you prefer this as a follow-up, please let me know. I didn't change the behavior for editing an existing patch as I think while SQL might be the most 'common' field to change, it could also be a danger of making unwanted changes and I found other examples where on editing the focus is on top. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139419|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 139427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139427&action=edit Bug 27436: Set focus on first input when adding a new SQL report When adding a new SQL report, the focus/cursor should be in the first input field of the form: Report name To test: * Add a new SQL report in reports > new from SQL - cursur is in no field * Apply patch * Add another new SQL report - cursor is now in the first input field of the form: Report name Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411 [Bug 31411] [Omnibus] Set focus to first input field of an add/entry form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139427|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140157&action=edit Bug 27436: Set focus on first input when adding a new SQL report When adding a new SQL report, the focus/cursor should be in the first input field of the form: Report name To test: * Add a new SQL report in reports > new from SQL - cursur is in no field * Apply patch * Add another new SQL report - cursor is now in the first input field of the form: Report name Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27436 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org