[Bug 27193] New: Set focus for cursor to patron attribute type code input box when creating new patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Bug ID: 27193 Summary: Set focus for cursor to patron attribute type code input box when creating new patron attributes Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.johnson@bedfordtx.gov QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When adding a new patron attribute type on patron-attr-types.pl you have to click in the patron attribute type code input box, which is a required field, so that you can enter text. It would be more efficient to set the focus for the cursor to always be in the patron attribute type code input box so that you could just begin typing and eliminate an extra click. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Component|System Administration |Templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Ella <ellawipatene@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ellawipatene@gmail.com Assignee|koha-bugs@lists.koha-commun |ellawipatene@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Ella <ellawipatene@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 --- Comment #1 from Ella <ellawipatene@gmail.com> --- Created attachment 115274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115274&action=edit Bug 27193 - Set focus for cursor to patron attribute type code input box when creating new patron attributes 1. (Before attaching the patch) Go into administration 2. Go to Patron attribute types - then 'New patron attribute type' 3. Without the patch, the cursor should not automatically focus on the first container 'Patron attribute type code' 4. Install patch 5. Redo steps 1&2 6. If the patch worked, then the cursor should automatically focus to the first container 'Patron attribute type code' Sponsored.by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Needs Signoff |Failed QA --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hello Ella, The commit message of your patch must start with "Bug 27193: ". Can you resubmit please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Ella <ellawipatene@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 --- Comment #3 from Ella <ellawipatene@gmail.com> --- Created attachment 115347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115347&action=edit Bug 27193: Set focus for cursor to patron attribute type code input box when creating new patron attributes 1. (Before attaching the patch) Go into administration 2. Go to Patron attribute types - then 'New patron attribute type' 3. Without the patch, the cursor should not automatically focus on the first container 'Patron attribute type code' 4. Install patch 5. Redo steps 1&2 6. If the patch worked, then the cursor should automatically focus to the first container 'Patron attribute type code' Sponsored.by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115366&action=edit Bug 27195: Set focus for cursor to city input box when creating new cities (Before downloading the patch) 1. Go to administration 2. Go to cities 3. Click on add new city 4. See if the cursor automatically focuses to the first city container (It shouldn't). 5. Apply patch 6. Repeat steps 1-4 7. If the cursor automatically focuses in the first city container, the patch has worked! Sponsored-by: Catalyst IT Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115274|0 |1 is obsolete| | --- Comment #5 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115367&action=edit Bug 27193 - Set focus for cursor to patron attribute type code input box when creating new patron attributes 1. (Before attaching the patch) Go into administration 2. Go to Patron attribute types - then 'New patron attribute type' 3. Without the patch, the cursor should not automatically focus on the first container 'Patron attribute type code' 4. Install patch 5. Redo steps 1&2 6. If the patch worked, then the cursor should automatically focus to the first container 'Patron attribute type code' Sponsored.by: Catalyst IT Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Attachment #115366|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115347|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 115616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115616&action=edit Bug 27193: Set focus for cursor to patron attribute type code input box when creating new patron attributes 1. (Before attaching the patch) Go into administration 2. Go to Patron attribute types - then 'New patron attribute type' 3. Without the patch, the cursor should not automatically focus on the first container 'Patron attribute type code' 4. Install patch 5. Redo steps 1&2 6. If the patch worked, then the cursor should automatically focus to the first container 'Patron attribute type code' Sponsored.by: Catalyst IT Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115367|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Focus must be put using the "focus" class instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ellawipatene@gmail.com |katrin.fischer@bsz-bw.de QA Contact|kyle@bywatersolutions.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115616|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139416&action=edit Bug 27193: Set focus on first input when adding a new patron attribute When adding a new patron attribute, the focus/cursor should be in the first input field of the form: Patron attribute type code To test: * Add a new patron attribute - cursur is in no field * Apply patch * Add another new patron attribute - cursor is now in the first input field: Patron attribute type code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've implemented the solution from comment#7 using the CSS class. As this is a one line change all in all it replaces Ella's patch. I am sorry to lose the contribution, but not sure about a better option here. :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139416|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 139424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139424&action=edit Bug 27193: Set focus on first input when adding a new patron attribute When adding a new patron attribute, the focus/cursor should be in the first input field of the form: Patron attribute type code To test: * Add a new patron attribute - cursur is in no field * Apply patch * Add another new patron attribute - cursor is now in the first input field: Patron attribute type code Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411 [Bug 31411] [Omnibus] Set focus to first input field of an add/entry form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139424|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140158&action=edit Bug 27193: Set focus on first input when adding a new patron attribute When adding a new patron attribute, the focus/cursor should be in the first input field of the form: Patron attribute type code To test: * Add a new patron attribute - cursur is in no field * Apply patch * Add another new patron attribute - cursor is now in the first input field: Patron attribute type code Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org