[Bug 38753] New: Missing table cells breaks OPAC charges table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 Bug ID: 38753 Summary: Missing table cells breaks OPAC charges table Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There are a couple of missing instances of the empty '<td></td>' required by DataTables to make the table responsive. The table header/table cell mismatch breaks the DataTable behavior. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I think the problem is only visible if the patron has an outstanding credit on their account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 [Bug 32341] Some OPAC tables are not displayed well in mobile mode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175765&action=edit Bug 38753: Missing table cells breaks OPAC charges table This patch adds a couple of instances of the empty cell required by DataTables to enable responsive behavior. The mismatch between table headers and table cells causes DataTables to fail. To test you must log in to the OPAC as a user with charges and credit. - Apply the patch and go to Patrons in the staff interface. - Find and view a patron record. Click "Accounting" in the sidebar menu. - Use the "Create manual invoice" and "Create manual credit" tabs to create at least one charge and a credit which is greater than the charges. - Log in to the OPAC as that user and go to their Charges tab. - The charges table shoud look correct, with DataTables sorting indicators on the table headers to indicate that DataTables is working. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175765|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 175806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175806&action=edit Bug 38753: Missing table cells breaks OPAC charges table This patch adds a couple of instances of the empty cell required by DataTables to enable responsive behavior. The mismatch between table headers and table cells causes DataTables to fail. To test you must log in to the OPAC as a user with charges and credit. - Apply the patch and go to Patrons in the staff interface. - Find and view a patron record. Click "Accounting" in the sidebar menu. - Use the "Create manual invoice" and "Create manual credit" tabs to create at least one charge and a credit which is greater than the charges. - Log in to the OPAC as that user and go to their Charges tab. - The charges table shoud look correct, with DataTables sorting indicators on the table headers to indicate that DataTables is working. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA by RM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the charges release notes| |table for a patron in the | |OPAC (Your account > | |Charges). It didn't display | |correctly in some | |circumstances (there were | |missing empty table cells, | |resulting in empty and | |misaligned cells at the end | |of the table). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 Bug 38753 depends on bug 32341, which changed state. Bug 32341 Summary: Some OPAC tables are not displayed well in mobile mode https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38753 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #8 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org