[Bug 38377] New: Wrong Turkish translation in renewal part
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 Bug ID: 38377 Summary: Wrong Turkish translation in renewal part Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: angelic@devinim.com.tr QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com In renewal part there is a missunderstanding. Let me explain with an example. The sentence in English: "2 of 3 renewals remaining" is translated as "2 uzatma hakkınızdan 3 tane kaldı" in Turkish. This is wrong. Right Turkish translation must be like this : "3 uzatma hakkınızdan 2 tane kaldı" This information can be seen in (with a user having renewals): cgi-bin/koha/opac-user.pl page of user. cgi-bin/koha/circ/circulation.pl?borrowernumber=xxxx -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 Angelic <angelic@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174075&action=edit Bug 38377: Improve translatability of "%s/%s renewals remaining" See comment 0 The sentence in English: "2 of 3 renewals remaining" is translated as "2 uzatma hakkınızdan 3 tane kaldı" in Turkish. This is wrong. Right Turkish translation must be like this : "3 uzatma hakkınızdan 2 tane kaldı" We cannot use %s/%s as the order will be preserved, we need to use named placeholders. Test plan: Apply this patch % gulp po:update --lang LANG Go to misc/translator/po % git grep 'renewals remaining' Translate the occurrences, remove fuzzy sudo koha-translate --update LANG --dev kohadev restart_all Enable LANG for both staff and OPAC Have a look at the checkouts table and notice that the strings have been correctly translated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Version|23.11 |unspecified -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174075|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 175938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175938&action=edit Bug 38377: Improve translatability of "%s/%s renewals remaining" See comment 0 The sentence in English: "2 of 3 renewals remaining" is translated as "2 uzatma hakkınızdan 3 tane kaldı" in Turkish. This is wrong. Right Turkish translation must be like this : "3 uzatma hakkınızdan 2 tane kaldı" We cannot use %s/%s as the order will be preserved, we need to use named placeholders. Test plan: Apply this patch % gulp po:update --lang LANG Go to misc/translator/po % git grep 'renewals remaining' Translate the occurrences, remove fuzzy sudo koha-translate --update LANG --dev kohadev restart_all Enable LANG for both staff and OPAC Have a look at the checkouts table and notice that the strings have been correctly translated Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the translation release notes| |strings for renewals - they | |now use named placeholders | |so that the correct order | |can be translated. | | | |Example: | |- In English: "4 | |of 5 renewals remaining" | |- | |In Turkish: | | . was | |incorrectly translated as | |"4 uzatma hakkınızdan 5 | |tane kaldı" | | . is now | |correctly translated as (5 | |uzatma hakkınızdan 4 tane | |kaldı" --- Comment #3 from David Nind <david@davidnind.com> --- I've signed off, and I think I get the expected results. I had a lot of trouble following the test plan. Testing notes (using KTD): 1. To identify files to change, I used: git grep 'renewals remaining' tr-TR-* 2. I made changes to the po files as set out in [1]. 3. The update command didn't work for me (I started with no additional languages installed, so I guess that explains this?): koha-translate --update tr-TR --dev kohadev Error: the selected language is not currently installed. Try --install. 4. I got the same result if I ran the command from a root shell (ktd --root --shell). 5. Instead, I did an install: koha-translate --install tr-TR --dev kohadev 6. Results for the OPAC, I get this in the renewals column: Turkish: Süresi uzatıldı! [] Süresini uzat ( 5 uzatma hakkınızdan 4 tane kaldı ) English: Renewed! [] Renew ( 4 of 5 renewals remaining ) 7. Results for the staff interface: I get this in the renewals column: Turkish: 1 [] (5 uzatma hakkınızdan 4 tane kaldı) English: 1 [] (4 of 5 renewals remaining) [1] Changes made to po files ============================ tr-TR-messages-js.po -------------------- 724 #: koha-tmpl/intranet-tmpl/prog/js/checkouts.js:366 725 #, fuzzy 726 msgid "{renewals_left} of {renewals_allowed} renewals remaining" 727 msgstr "%s uzatma hakkınızdan %s tane kaldı" 728 729 #: koha-tmpl/intranet-tmpl/prog/js/checkouts.js:368 730 #, fuzzy 731 msgid " and {renewals_left} of {renewals_allowed} unseen renewals remaining" 732 msgstr "%s uzatma hakkınızdan %s tane kaldı" Changes: - Changed 727 and 732 to: msgstr "{renewals_allowed} uzatma hakkınızdan {renewals_left} tane kaldı" - Removed #, fuzzy lines x2 tr-TR-messages.po ----------------- 9372 #, perl-brace-format 9373 msgid "{renewals_left} of {renewals_allowed} renewals remaining" 9374 msgstr "" Changes: - Changed 9374 to: msgstr "{renewals_allowed} uzatma hakkınızdan {renewals_left} tane kaldı" tr-TR-opac-bootstrap.po ----------------------- 12940 #. For the first occurrence, 12941 #. %1$s: I18N.tx("{renewals_left} of {renewals_allowed} renewals remaining", { renewals_left = ISSUE.renewsleft, renewa ls_allowed = ISSUE.renewsallowed }) 12942 #. %2$s: IF Koha.Preference('UnseenRenewals') && ISSUE.unseenallowed 12943 #. %3$s: ISSUE.unseenleft | html 12944 #. %4$s: ISSUE.unseenallowed | html 12945 #. %5$s: END 12946 #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:469 12947 #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:487 12948 #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:495 12949 #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:503 12950 #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:809 12951 #, fuzzy, c-format 12952 msgid "( %s %s / %s of %s renewals left before the item must be seen by the library %s )" 12953 msgstr "( %s izin verilenden %s tane kalan uzatma hakkı %s / %s izin verilenden %s materyal kütüphane tarafından görülme lidir %s )" 12970 #. %1$s: ISSUE.renewsleft | html 12971 #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:480 12972 #, c-format 12973 msgid "Item must be renewed at the library. %s renewals remaining" 12974 msgstr "Materyalin süresi kütüphanede uzatılmalıdır. %s Kalan uzatma hakkı" Didn't make any changes. tr-TR-staff-prog.po ------------------- No occurrences, didn't make any changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrong Turkish translation |Improve translatability of |in renewal part |remaining renewals counters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38377 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #7 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org