https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32473 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145210&action=edit Bug 32609: Improve yarn build commands We had: yarn css # Build staff css yarn css --view opac # Build OPAC css yarn build # Nothing, was broken yarn watch # Nothing, was broken yarn build_js # Build JS/Vue yarn watch_js # Watch JS/Vue This patch is suggesting to have something more consistent: yarn css:build # Build CSS for OPAC and staff (dev) yarn css:build:prod # Build CSS for OPAC and staff (prod) yarn css:watch # Watch CSS for OPAC and staff (dev) yarn js:build # Build JS (dev) yarn js:build:prod # Build JS (prod) yarn js:watch # Watch JS (dev) yarn build # Same as css:build and js:build (dev) yarn build:prod # Same as css:build:prod and js:build:prod (prod) Note that the cssnano was breaking the build function. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145212&action=edit Bug 32609: Add warning to the about page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |martin.renvoize@ptfs-europe | |.com, mtj@kohaaloha.com, | |oleonard@myacpl.org, | |paul.derscheid@lmscloud.de, | |tomascohen@gmail.com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think this is going toward the good direction, what do you think? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- +1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #10 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #9)

(In reply to Jonathan Druart from comment #0)

...

We need to improve our yarn build commands to generate css and js compiled files.

Then remove them from our codebase, and generate them when needed:

- when generating the debian packages - when ktd is starting up - when patches are applied on the sandbox

Hm, what about tarballs?

We roll our own packages - what would be the suggested workflow? Generate the files on the git branch before building the packages?

i think we might be able to add these steps to Makefile.PL, so they get run for both tarball and deb pkg builds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145209|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145211|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Mason James from comment #10)

(In reply to Katrin Fischer from comment #9)

...

Hm, what about tarballs?

We roll our own packages - what would be the suggested workflow? Generate the files on the git branch before building the packages?

i think we might be able to add these steps to Makefile.PL, so they get run for both tarball and deb pkg builds

Yeah I reckon we add something to PL_FILES: https://metacpan.org/pod/ExtUtils::MakeMaker#PL_FILES That way it would apply to tarballs, deb pkg builds, and technically even git dev installs. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is looking great.. we clearly need to continue down this route in my opinion. Let me know how I can help.. obviously it will require changes in surrounding projects like ktd, sandboxes, packaging pipeline.. we should be able to split the load at least a little. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Cook from comment #12)

If we create a Perl script to run these commands, we can include it in Makefile.PL, plus manually call it for "ktd" and sandboxes, so... that should be pretty straightforward overall.

Actually it's not obvious at all for me how this can be done easily. There are dev paths in gulpfile... We could rely no an env var (or an option?) that would pass the path. Like: css_path=/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/css/ yarn css:build:prod I've done this already. For the js/vue dist file, it's a bit more tricky (node path, relative js path, modules, etc.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Cook from comment #17)

If you can tell me which commands we need to build the JS and CSS, I'm happy to give this a try...

It's in commit message of the second commit: This patch is suggesting to have something more consistent: yarn css:build # Build CSS for OPAC and staff (dev) yarn css:build:prod # Build CSS for OPAC and staff (prod) yarn css:watch # Watch CSS for OPAC and staff (dev) yarn js:build # Build JS (dev) yarn js:build:prod # Build JS (prod) yarn js:watch # Watch JS (dev) yarn build # Same as css:build and js:build (dev) yarn build:prod # Same as css:build:prod and js:build:prod (prod) Here we will need `yarn build:prod` that will generate the minified css files and the dist file for the Vue app. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- My patch is on top of Jonathans branch (though with it I think we don't need his last two patches). I've not actually tested it in the end to end sense of building a package. Also, it assumes dependencies for yarn and friends are there.. but I think that's a fair assumption for a build box right? Let me know if we're thinking along the same lines David and please feel free to improve further. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #22 from David Cook <dcook@prosentient.com.au> --- If we're going to get a script file from PL_FILES to run "before" pm_to_blib, then we need to use a target that can be found in "PM". Since Jonathan removed the files, "perl Makefile.PL" creates a Makefile that doesn't include the CSS and JS targets in "PM", so they don't get copied into "blib" and don't wind up in the tarball (for tarball/package installs). If we're going to use Makefile.PL to include generated files, we just need to add them to the "PM" argument in Makefile.PL and to call build-resources.PL with an argument that can be found in "PM". (We don't want multiple arguments, or build-resources.PL will be run multiple times.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #24 from David Cook <dcook@prosentient.com.au> --- According to https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff..., I first need to run "yarn install" I wonder if that should be in build-resources.PL or not. I'll add it in and see how I go... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #26 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #25)

That means that the CSS and JS files have been built and copied across to "blib". From there, they can be installed using a source install or built into a Debian package.

I verified this by running "make install" in a "single" deployment. /opt/koha/intranet/htdocs/intranet-tmpl/prog/js/vue/dist/main.js /opt/koha/opac/htdocs/opac-tmpl/bootstrap/css/opac.css You could manually verify the rest. There's just a bunch of generated files to list. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #28 from David Cook <dcook@prosentient.com.au> --- Created attachment 145838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145838&action=edit Bug 32609: (follow-up) enhance Makefile.PL This patch adds a new target to the Makefile which gets called as the first step of the "all" target. This means that CSS and JS files get compiled every time "make" is called. (Note: Since the "install" target depends on "all", it will be re-run at install time.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #30 from David Cook <dcook@prosentient.com.au> --- Anyway, I'm pretty happy with how that turned out overall. It certainly does the trick. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145802|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Indeed, that's why I was hesitant to put the 'yarn install' within the PL. I'm sure there must be something we can pass there to ensure it installed pinned versions from our committed lock file.. but I'm damned if I can spot such an option. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #34 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #31)

I have one concern about the `yarn install` step. At some point we want to freeze the node_modules directory, or we may get expected regressions at a very bad time. Imagine we are testing a beta version D-15 before the release, everything is working great, we decide to release on D-day, package maintainer releases using `yarn install && yarn build:prod`. If something changed in the node modules, we haven't tested it and we release a broken version.

If we use "yarn install --frozen-lockfile" when running via Makefile.PL, that should avoid that scenario. We'd be using only the versions from yarn.lock that hypothetically were tested. That said, testing will be interesting. I suppose you'll get generated files at ktd startup time, and those should be OK until you change branches. At that point, you might have the wrong generated files and not know it. When it comes to local dev/test, we might need to just get into the habit of being mindful of doing yarn install/build when we switch branches (if required). Sandboxes shouldn't be a problem since we could automate the file re-generation...

It's tricky and I don't have a solution right now, but we need to: * Let developers yarn install whenever they want (/kohadevbox/koha/node_modules will be used/tested) * Have a generated (when?) version (/kohadevbox/node_modules) that would be used to generate the compiled files on ktd startup (sandboxes and devs). We could run build:prod to avoid last minute bugs to popup. * Pick the last generated version for the release

I suppose test/QA theoretically should catch if there's a problem with generated files. So the "last generated version for the release" will just be what's in the package.json and yarn.lock files. Maybe we're overthinking it a bit? Although I think changing "yarn install" to "yarn install --frozen-lockfile" sounds necessary for sure. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- New commit added to the remote branch: "Bug 32609: Use the current yarn.lock to generate node_modules" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is ready to be tested! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #38)

Do we need a list of other tasks that need taking care as part of pushing this.. i.e. we'll need to update the sandboxes and ktd to run the new yarn commands (or perhaps point them at the new build_resources.PL script alternatively).

This is for https://gitlab.com/koha-community/koha-misc4dev/-/issues/60 I have a patch almost done, but I need a DB rev number to finish it (yes, that's not nice, we will depend on a DB rev for something not DB related...) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I tried to do an old-fashioned dev install to test this.. but alas, I failed miserably. I had to sort out all sorts of dependencies to get the 'perl Makefile.PL' step happy.. then upon running 'make' it complained about yarn not being found.. so I installed yarn but then it complained with yarn: error: no such option: --frozen-lockfile So I tried replacing --frozen-lockfile with --immutable and that complained too. In short.. I can run `build-resources.PL` perfectly from inside ktd.. though of course in that case we don't need the `yarn install` step at all as we have our our node_modules all there and waiting for us.. but trying to run it outside of ktd we end up stuck in dependancies hell. I'm not sure where that leaves us.. we're not really actually expecting people to be running dev installs now.. and we don't really document it anywhere anymore as far as I can see on googling.. So maybe this is OK as I believe this should all work for packaging as it stands. We need Mason to weight in really. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #43 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #41)

I had to sort out all sorts of dependencies to get the 'perl Makefile.PL' step happy.. then upon running 'make' it complained about yarn not being found.. so I installed yarn but then it complained with yarn: error: no such option: --frozen-lockfile

So I tried replacing --frozen-lockfile with --immutable and that complained too.

Which kind of dependencies did you need to sort out? Was it stuff like "build-essential gcc gettext" or something else? Which OS and OS version were you using? Was this in or outside of Docker? Which version of yarn were you using? Was it Yarn v1, v2, or v3? What was the --immutable complaint? It looks like Debian/Ubuntu provide Yarn 1.x, and npm looks like it uses 1.x (although it provides 2.x too).

In short.. I can run `build-resources.PL` perfectly from inside ktd.. though of course in that case we don't need the `yarn install` step at all as we have our our node_modules all there and waiting for us.. but trying to run it outside of ktd we end up stuck in dependancies hell.

I needed the `yarn install` in my ktd as I didn't have node_modules already there. After a bit of reading, it sounds like running some type of `yarn install` invocation is a common step (although I suppose we could debate about when to run it). I used to run Koha in OpenSuse and getting the dependencies right was always a pain, which is why we switched over to Debian/Ubuntu (and ktd for dev/test).

I'm not sure where that leaves us.. we're not really actually expecting people to be running dev installs now.. and we don't really document it anywhere anymore as far as I can see on googling.. So maybe this is OK as I believe this should all work for packaging as it stands.

We need Mason to weight in really.

Yeah, it would be good to hear from Mason. Perhaps I should have a go with my local package building as well and see if I bump into any gotchas... Both single and dev installs are a bit fraught because of dependencies (which is a big reason I stopped doing them heh). Overall, I don't think the community directly supports anything except Debian package installs on Debian/Ubuntu, although we could always document better. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #45 from David Cook <dcook@prosentient.com.au> --- So I'm looking at building a package with these patches, and I notice that the "yarn" in ktd is provided by this source list: deb https://dl.yarnpkg.com/debian/ stable main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #47 from David Cook <dcook@prosentient.com.au> --- Package builder output on "make": make[1]: Entering directory '/home/koha/build/koha-22.12+test.bb175389' "/usr/bin/perl" build-resources.PL yarn install v1.22.19 [1/4] Resolving packages... [2/4] Fetching packages... [3/4] Linking dependencies... warning " > bootstrap@4.6.2" has unmet peer dependency "jquery@1.9.1 - 3". warning " > bootstrap@4.6.2" has unmet peer dependency "popper.js@^1.16.1". [4/4] Building fresh packages... Done in 242.50s. yarn run v1.22.19 $ yarn css:build:prod && yarn js:build:prod $ gulp build && gulp css --view opac [05:19:53] Using gulpfile ~/build/koha-22.12+test.bb175389/gulpfile.js [05:19:54] Starting 'build'... [05:19:54] Finished 'build' after 10 ms [05:19:58] Using gulpfile ~/build/koha-22.12+test.bb175389/gulpfile.js [05:19:58] Starting 'css'... [05:19:58] Finished 'css' after 12 ms $ webpack --mode production asset main.js 1.44 MiB [emitted] [minimized] [big] (name: main) 1 related asset orphan modules 838 KiB [orphan] 277 modules runtime modules 1.17 KiB 6 modules cacheable modules 2.69 MiB modules by path ./node_modules/ 2.18 MiB 30 modules modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/ 525 KiB modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/*.vue 35.6 KiB 20 modules modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/stores/*.js 3.52 KiB ./koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js 1.12 KiB [built] [code generated] + 2 modules modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/*.js 484 KiB ./koha-tmpl/intranet-tmpl/prog/js/vue/routes.js + 232 modules 474 KiB [built] [code generated] + 2 modules ./koha-tmpl/intranet-tmpl/prog/js/vue/main-erm.ts 1.88 KiB [built] [code generated] WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB). This can impact web performance. Assets: main.js (1.44 MiB) WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance. Entrypoints: main (1.44 MiB) main.js WARNING in webpack performance recommendations: You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application. For more info visit https://webpack.js.org/guides/code-splitting/ webpack 5.74.0 compiled with 3 warnings in 27212 ms Done in 72.50s. -- Package builder output on "make install": make[1]: Entering directory '/home/koha/build/koha-22.12+test.bb175389' dh_auto_install dh_auto_install: warning: Compatibility levels before 10 are deprecated (level 9 in use) make -j1 install DESTDIR=/home/koha/build/koha-22.12\+test.bb175389/debian/tmp AM_UPDATE_INFO_DIR=no PREFIX=/usr make[2]: Entering directory '/home/koha/build/koha-22.12+test.bb175389' "/usr/bin/perl" build-resources.PL yarn install v1.22.19 [1/4] Resolving packages... success Already up-to-date. Done in 0.83s. yarn run v1.22.19 $ yarn css:build:prod && yarn js:build:prod $ gulp build && gulp css --view opac [05:22:18] Using gulpfile ~/build/koha-22.12+test.bb175389/gulpfile.js [05:22:18] Starting 'build'... [05:22:18] Finished 'build' after 10 ms [05:22:21] Using gulpfile ~/build/koha-22.12+test.bb175389/gulpfile.js [05:22:21] Starting 'css'... [05:22:21] Finished 'css' after 11 ms $ webpack --mode production asset main.js 1.44 MiB [compared for emit] [minimized] [big] (name: main) 1 related asset orphan modules 838 KiB [orphan] 277 modules runtime modules 1.17 KiB 6 modules cacheable modules 2.69 MiB modules by path ./node_modules/ 2.18 MiB 30 modules modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/ 525 KiB modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/*.vue 35.6 KiB 20 modules modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/stores/*.js 3.52 KiB ./koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js 1.12 KiB [built] [code generated] + 2 modules modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/*.js 484 KiB ./koha-tmpl/intranet-tmpl/prog/js/vue/routes.js + 232 modules 474 KiB [built] [code generated] + 2 modules ./koha-tmpl/intranet-tmpl/prog/js/vue/main-erm.ts 1.88 KiB [built] [code generated] WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB). This can impact web performance. Assets: main.js (1.44 MiB) WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance. Entrypoints: main (1.44 MiB) main.js WARNING in webpack performance recommendations: You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application. For more info visit https://webpack.js.org/guides/code-splitting/ webpack 5.74.0 compiled with 3 warnings in 20990 ms Done in 33.78s. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So I was installing on a fresh Ubuntu.. and trying initially to use ubuntu apt repos.. Yarn came in at a newer version that Koha expected.. that was the main stumbling block really. I've since managed to get it all working.. thanks for the tip about that yarn repo. We don't document a dev install anywhere now so it's become more difficult and I've become very rusty ;). My feeling at this point is that we should go with this as is now :). You can add my SO lines to the remote branch Jonathan.. I'm happy I got it all working for a standard install and a dev type install.. and it sounds like David was pretty happy with building a package, all be it he had expected issues due to upstream having a bad debian.control file at the minute (I fixed that in 22.11.x branch already.. not sure if he's got it building and applying to master regularly yet?) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- When everything is set, could you add a little write-up to the wiki? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32806 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 [Bug 32806] Some Vue files need to be moved for better reusability -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is a merge request in misc4dev to support both build_js and build, see https://gitlab.com/koha-community/koha-misc4dev It must be merged before this is pushed to master. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #56 from Mason James <mtj@kohaaloha.com> --- (In reply to David Cook from comment #55)

I wonder if Mason should install "yarn" on the package build machine(s) before this is pushed too, so that there aren't any delays building packages going forward?

i've added yarn (1.22.19-1) to the pkg build system -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We decided not to backport this architectural enhancement. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 [Bug 32975] Error in package.json's definition of css:build vs css:build:prod -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #61 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #60)

Any reason why the build-resouces.PL script includes a 1; at the end ?

Maybe not needed, but should not hurt.

Why the uppercase PL btw?

https://metacpan.org/pod/ExtUtils::MakeMaker#How-To-Write-A-Makefile.PL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32994 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 [Bug 32994] Remove compiled files from src (2) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #63 from Lucas Gass <lucas@bywatersolutions.com> --- Won't backport to 22.05.x, unless requested. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #64 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #62)

I decided to backport this one now.. it will aid in future maintenance, as it's already proved to cause a few minor issues with erm bugfix backports we've wanted to keep.

It's also proved itself nicely in master now so I feel it's a safe bet.

Backported for release in 22.11.04

Will know more soon! I'm working on a customized 22.11.03 and planning to merge in 22.11.04 when it comes out. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #66 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #64)

Will know more soon! I'm working on a customized 22.11.03 and planning to merge in 22.11.04 when it comes out.

(In reply to Aleisha Amohia from comment #65)

This has caused some problems for our libraries upgrading to 22.11.04.

(In reply to Aleisha Amohia from comment #65)

Is there something we need to additionally do or install?

I recently decided to pin at 22.11.03 for the time being, so I'm not sure what the problem might be. I could probably look at this later this week if no one else does. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #67)

(In reply to Martin Renvoize from comment #62)

...

Backported for release in 22.11.04

Did you ask Mason to adjust the pkg workflow to embed the css and js files?

Community packages are all working as expected here.. I presume your building your own Aliesha.. in which case the core thing is to ensure you run the build-resources.PL script as part of your package building process.. that will compile the CSS and JS resources for you. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #70 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #68)

Community packages are all working as expected here.. I presume your building your own Aliesha.. in which case the core thing is to ensure you run the build-resources.PL script as part of your package building process.. that will compile the CSS and JS resources for you.

The Makefile should be running build-resources.PL as per https://gitlab.com/joubu/Koha/-/commit/b64db106e0db41da06fbf72f1674b2ed43b3f... If the overall process was failing, I think Aleisha would have different symptoms. The issue she's having might be unrelated to this change but won't know without more information (provided either by Aleisha or someone else investigating). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #72 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to David Cook from comment #71)

(In reply to David Cook from comment #70)

...

If the overall process was failing, I think Aleisha would have different symptoms. The issue she's having might be unrelated to this change but won't know without more information (provided either by Aleisha or someone else investigating).

Actually, on that note, I think Aleisha should probably open a separate bug report for the issues she's facing and do a "See Also" to this one in case it's related.

Will do. I did a git bisect to narrow down the commit where we stopped seeing things we expected to see but there could be something else at play in the packaging process or other. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #74 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thank you Tomás but as I said, we aren't building our own packages. It is community packages that we get this problem -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #76 from David Cook <dcook@prosentient.com.au> --- (In reply to Aleisha Amohia from comment #74)

Thank you Tomás but as I said, we aren't building our own packages. It is community packages that we get this problem

It looks like there are some demo boxes on 22.11 so I'm happy to help Aleisha out with this one (on a separate bug report). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #77 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to David Cook from comment #76)

(In reply to Aleisha Amohia from comment #74)

...

Thank you Tomás but as I said, we aren't building our own packages. It is community packages that we get this problem

It looks like there are some demo boxes on 22.11 so I'm happy to help Aleisha out with this one (on a separate bug report).

Thank you. I've reported Bug 33621 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33615 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This important |This important release notes|architectural change |architectural change |removes the built css and |removes the built CSS and |javascript files from |JavaScript files from |source control and |source control and |introduces a build process |introduces a build process |and trigger into our |and trigger into our |packaging routines. |packaging routines. | |This |This |will both save space in the |will both save space in the |repository and lead to less |repository and lead to less |mistakes from developers by |mistakes from developers by |dropping the need to build, |dropping the need to build, |add and commit these files |add and commit these files |at release time. |at release time. | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39623 -- You are receiving this mail because: You are watching all bug changes.