[Bug 17417] New: Correct invalid markup around news on the staff client home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Bug ID: 17417 Summary: Correct invalid markup around news on the staff client home page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There are a couple of HTML validation errors in the area of the staff client home page template related to displaying news. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 56094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56094&action=edit Bug 17417 - Correct invalid markup around news on the staff client home page This patch fixes two minor errors in the markup around displaying news on the staff client home page: Adding a missing "class" attribute, and changing the container around news items from <p> to <div> (because news items might contain <p> and nesting them is incorrect). To test, apply the patch and view the staff client home page with news items showing. Validate the page and confirm that there are no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56094|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 56119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56119&action=edit Bug 17417 - Correct invalid markup around news on the staff client home page This patch fixes two minor errors in the markup around displaying news on the staff client home page: Adding a missing "class" attribute, and changing the container around news items from <p> to <div> (because news items might contain <p> and nesting them is incorrect). To test, apply the patch and view the staff client home page with news items showing. Validate the page and confirm that there are no errors. Signed-off-by: Marc <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56119|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 56552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56552&action=edit Bug 17417 [Revised] Correct invalid markup around news on the staff client home page This patch fixes two minor errors in the markup around displaying news on the staff client home page: Adding a missing "class" attribute, and changing the container around news items from <p> to <div> (because news items might contain <p> and nesting them is incorrect). To test, apply the patch and view the staff client home page with news items showing. Validate the page and confirm that there are no errors. Signed-off-by: Marc <veron@veron.ch> Revision for QA removes an extra </div> from elsewhere in the template to make the validator return no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56552|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56745&action=edit [PASSED QA] Bug 17417 [Revised] Correct invalid markup around news on the staff client home page This patch fixes two minor errors in the markup around displaying news on the staff client home page: Adding a missing "class" attribute, and changing the container around news items from <p> to <div> (because news items might contain <p> and nesting them is incorrect). To test, apply the patch and view the staff client home page with news items showing. Validate the page and confirm that there are no errors. Signed-off-by: Marc <veron@veron.ch> Revision for QA removes an extra </div> from elsewhere in the template to make the validator return no errors. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.06. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org