[Bug 17434] New: Moremember displaying primary and secondary phone number twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434 Bug ID: 17434 Summary: Moremember displaying primary and secondary phone number twice Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: bc@interleaf.ie QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Under certain circumstances the Primary and Secondary Phone will appear twice on the Patron record. When looking at the moremember.tt file line 236 has an IF block that displays the Primary and Secondary Phone value if the category_code ="P". I can't see any documentation as to why this is and what the "P" might mean. If a site adds their own category code and it equals "P", this duplication will occur. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56633&action=edit Bug 17434: Moremember displaying primary and secondary phone number twice Test plan: 1) Create patron category with category code "P" and create a patron with this category 2) Fill in either the primary or other phone number 3) Go to patron details page (moremember.pl) => without patch you see primary/other phone duplicated => with patch you should see the number only once as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Version|16.05 |master Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434 Lucio Moraes <lmoraes@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56633|0 |1 is obsolete| | --- Comment #2 from Lucio Moraes <lmoraes@catalyst.net.nz> --- Created attachment 56710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56710&action=edit Bug 17434: Moremember displaying primary and secondary phone number twice Test plan: 1) Create patron category with category code "P" and create a patron with this category 2) Fill in either the primary or other phone number 3) Go to patron details page (moremember.pl) => without patch you see primary/other phone duplicated => with patch you should see the number only once as expected Signed-off-by: Lucio Moraes <lmoraes@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434 Lucio Moraes <lmoraes@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434 Lucio Moraes <lmoraes@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56710|0 |1 is obsolete| | --- Comment #3 from Lucio Moraes <lmoraes@catalyst.net.nz> --- Created attachment 56711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56711&action=edit Bug 17434: Moremember displaying primary and secondary phone number twice Test plan: 1) Create patron category with category code "P" and create a patron with this category 2) Fill in either the primary or other phone number 3) Go to patron details page (moremember.pl) => without patch you see primary/other phone duplicated => with patch you should see the number only once as expected Signed-off-by: Lucio Moraes <lmoraes@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56711|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56832&action=edit Bug 17434: Moremember displaying primary and secondary phone number twice Test plan: 1) Create patron category with category code "P" and create a patron with this category 2) Fill in either the primary or other phone number 3) Go to patron details page (moremember.pl) => without patch you see primary/other phone duplicated => with patch you should see the number only once as expected Signed-off-by: Lucio Moraes <lmoraes@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Josef! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.06. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org