[Bug 10209] New: The ability to order multiple copies of the same item, from different fund classes, on the same order number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Bug ID: 10209 Summary: The ability to order multiple copies of the same item, from different fund classes, on the same order number Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: amit.gupta@osslabs.biz The ability to order multiple copies of the same item, from different fund classes, on the same order number -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com Assignee|koha-bugs@lists.koha-commun |amit.gupta@osslabs.biz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #1 from Amit Gupta <amit.gupta@osslabs.biz> --- Created attachment 18515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18515&action=edit The ability to order multiple copies of the same item, from different fund classes, on the same order number To Test: 1) Create basket. 2) Click on new order empty record. 3) Give title, quantity and select fund. 4) Order multiple copies of the same item click on Add fund and quantity button it will add one more fund and quantity by default quantity will be 1. 5) For delete fund and quantity simply click on Delete fund and quantity. Atleast one quantity and fund will be there if you try to delete it will show one error message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18515|0 |1 is obsolete| | --- Comment #2 from Amit <amitddng135@gmail.com> --- Created attachment 18588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18588&action=edit The ability to order multiple copies of the same item, from different fund classes, on the same order number Small typo fix in comma, The ability to order multiple copies of the same item, from different fund classes, on the same order number To Test: 1) Create basket. 2) Click on new order empty record. 3) Give title, quantity and select fund. 4) Order multiple copies of the same item click on Add fund and quantity button it will add one more fund and quantity by default quantity will be 1. 5) For delete fund and quantity simply click on Delete fund and quantity. Atleast one quantity and fund will be there if you try to delete it will show one error message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Amit, I know it works this way, but would you please consider changing it to create separate var names, like budget_1 quantity_1, budget_2 quantity_2 etc, and maybe maintain num_budgets var or similar. As I said, I know it works without it, but html spec does not guarantee submission of multiple values in any particular order. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #4 from Amit <amitddng135@gmail.com> --- Hi Srdjan Jankovic, If we have three row say budget1 quantity1, budget2 quantity2, budget3 quantity3 etc suppose if i delete the second row so i we identify the remaining items ID. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #5 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- You can maintain hidden num_budgets or max_budget input var. Upon submit, you go through budget1, budget2, ... budget[max_]budget], and skip if not set -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Amit, can you please take a look at Srdjan's comments? I would also like to point out that our use of budget/fund is a bit confusing, as we are actually displaying what we call a fund in Koha, but it's called budget all over the place in the code. Not sure if there is a way to resolve this at this point in time. Can you please also check the wording of the alert message? Failing the patch for now, because the Javascript contains untranslatable strings. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #7 from Amit <amitddng135@gmail.com> --- Hi Kartin, I am looking your and Srdjan's comments and will recreate the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18588|0 |1 is obsolete| | --- Comment #8 from Amit <amitddng135@gmail.com> --- Created attachment 18792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18792&action=edit The ability to order multiple copies of the same item, from different fund classes, on the same order number Hi Katrin and Srdjan Jankovic, I have applied your comment and recreate the patch please check. To Test: 1) Create a basket. 2) Click on new order empty record. 3) Give title, quantity and select fund. 4) Order multiple copies of the same item click on Add fund and quantity button it will add one more fund and quantity by default quantity will be 1. 5) For delete fund and quantity simply click on Delete fund and quantity. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #9 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Amit, You have a line there my $i = 0; $i is never used. Is that ok? Also, $$orderinfo{budget_id} is correct, however $orderinfo->{budget_id} is a bit easier to read, and I believe is standard in Koha. I'm going away for a month, so please ask someone else to sign it off if you are in a hurry. Otherwise, I'll do it when I'm back. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #10 from Amit <amitddng135@gmail.com> --- Hi Srdjan, By mistaken variable $i is declared i will clean up the code and send it to again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #11 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Oh yes, and another thing - I'm not sure if if ($b ne undef) works as you would expect. Usually you would say if (defined $b). But if ($b) should be enough (and best I believe, because it protects from ''). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18792|0 |1 is obsolete| | --- Comment #12 from Amit <amitddng135@gmail.com> --- Created attachment 18834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18834&action=edit The ability to order multiple copies of the same item, from different fund classes, on the same order number Hi Srdjan Jankovic, I have remove the variable $i and apply your comments also. Please have a look. To Test: 1) Create a basket. 2) Click on new order empty record. 3) Give title, quantity and select fund. 4) Order multiple copies of the same item click on Add fund and quantity button it will add one more fund and quantity by default quantity will be 1. 5) For delete fund and quantity simply click on Delete fund and quantity. You can not delete first budget and quantity. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18834|0 |1 is obsolete| | --- Comment #13 from Amit <amitddng135@gmail.com> --- Created attachment 18854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18854&action=edit The ability to order multiple copies of the same item, from different fund classes, on the same order number Hi Srdjan, I have apply your comment's. Please look the patch Test Plan: 1) Create a basket. 2) Click on new order empty record. 3) Give title, quantity and select fund. 4) Order multiple copies of the same item click on Add fund and quantity button it will add one more fund and quantity by default quantity will be 1. 5) For delete fund and quantity simply click on Delete fund and quantity. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #14 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Amit, it looks to me that you are creating multiple orders, with different ordernumber. Is that what you intended? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #15 from Amit <amitddng135@gmail.com> --- Yes creating multiple order with different ordernumber. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The ability to order |The ability to order |multiple copies of the same |multiple copies of the same |item, from different fund |item, from different fund |classes, on the same order |classes, with different |number |order number -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The ability to order |The ability to order |multiple copies of the same |multiple copies of the same |item, from different fund |item, from different fund |classes, with different |classes |order number | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #16 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- This won't work for AcqCreateItem 'ordering'. It will create all order items for the last order only. What needs to be done is store ordernumber and quantity from the loop (together with the first values), and use that when calling NewOrderItem(). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #17 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 10209 - The ability to order multiple copies of the same item, from different fund classes, on the same order number Using index info to reconstruct a base tree... M acqui/addorder.pl M koha-tmpl/intranet-tmpl/prog/en/js/additem.js M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/additem.js Auto-merging acqui/addorder.pl Patch failed at 0001 Bug 10209 - The ability to order multiple copies of the same item, from different fund classes, on the same order number The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 marjorie barry-vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #18 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- Hi, Is anyone working on this? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org