[Bug 24316] New: Fix non-English web installers by removing obsolete authorised value MANUAL_INV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Bug ID: 24316 Summary: Fix non-English web installers by removing obsolete authorised value MANUAL_INV Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 23049 Bug 23049 replaced the MANUAL_INV authorised value by a dedicated table, but missed to remove the authorised value sample data from the non English installers. Marking major as this causes errors in the web installer. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24314 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96677&action=edit Bug 24316: Remove obsolete sample data for MANUAL_INV authorised value Bug 23049 replaced the MANUAL_INV authorised value by a dedicated table, but missed to remove the authorised value sample data from the non-English installers. This patch corrects this oversight. Note: The German (de-DE) file was changed a bit more, adding 2 missing translations for the new RETURN_CLAIM_RESOLUTION and to match the sequence of the en file. To test: - Verify the SQL file changes are valid by loading those files OR - Run the installers for each language on an empty database - Verify there is no error loading the optional authorised value data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96677|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 96692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96692&action=edit Bug 24316: Remove obsolete sample data for MANUAL_INV authorised value Bug 23049 replaced the MANUAL_INV authorised value by a dedicated table, but missed to remove the authorised value sample data from the non-English installers. This patch corrects this oversight. Note: The German (de-DE) file was changed a bit more, adding 2 missing translations for the new RETURN_CLAIM_RESOLUTION and to match the sequence of the en file. To test: - Verify the SQL file changes are valid by loading those files OR - Run the installers for each language on an empty database - Verify there is no error loading the optional authorised value data Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with 24317 and a small followup for this bug for es-ES Tested doing clean install for de-DE es-ES fr-CA it-IT nb-NO pl-PL up to loading of all mandatory & optional data. All languages load without problems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 96693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96693&action=edit Bug 24316: (follow up) Fix es-ES web installer Same correction, as other languages, removing obsolete authorised value MANUAL_INV. Same test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |bgkriegel@gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Last patch needs a sign -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96693|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96699&action=edit Bug 24316: (follow up) Fix es-ES web installer Same correction, as other languages, removing obsolete authorised value MANUAL_INV. Same test Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Bernardo! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Should not we remove it (again) for existing installs? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's ok - since the authorised_value category was missing, this shoudl not have been installed in fresh installations. And for everyone updating it would have worked correctly, only fresh 19.11 would be in danger (and the sql was broken there). But we can still.. not blocking :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96692|0 |1 is obsolete| | Attachment #96699|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96736&action=edit Bug 24316: Remove obsolete sample data for MANUAL_INV authorised value Bug 23049 replaced the MANUAL_INV authorised value by a dedicated table, but missed to remove the authorised value sample data from the non-English installers. This patch corrects this oversight. Note: The German (de-DE) file was changed a bit more, adding 2 missing translations for the new RETURN_CLAIM_RESOLUTION and to match the sequence of the en file. To test: - Verify the SQL file changes are valid by loading those files OR - Run the installers for each language on an empty database - Verify there is no error loading the optional authorised value data Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with 24317 and a small followup for this bug for es-ES Tested doing clean install for de-DE es-ES fr-CA it-IT nb-NO pl-PL up to loading of all mandatory & optional data. All languages load without problems. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96737&action=edit Bug 24316: (follow up) Fix es-ES web installer Same correction, as other languages, removing obsolete authorised value MANUAL_INV. Same test Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Bug 24316 depends on bug 23049, which changed state. Bug 23049 Summary: Replace MANUAL_INV authorised value with a dedicated table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org