[Bug 18546] New: Add a 'Close' link to OPAC cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Bug ID: 18546 Summary: Add a 'Close' link to OPAC cart Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Opac cart has does not have a link "Empty and close", but no link or button for "Close". Would be nice to have one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545 [Bug 18545] Remove use of onclick from OPAC Cart -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- It's there, but it's hidden because of a collision with Bootstrap's CSS: <a class="hide close" href="opac-basket.pl">Hide window</a> The "hide" class makes it disappear :( I'm glad someone noticed because I didn't! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Summary|Add a 'Close' link to OPAC |Unhide the 'Hide window' |cart |link in OPAC cart -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 63777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63777&action=edit Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 --- Comment #3 from Marc Véron <veron@veron.ch> --- Note: I did not touch the second toolbar (Select all, Clear all etc.) It has a problem as well: On a small screen, it is hidden (with and without this patch. Maybe the whole cart window needs a rewrite - but that is out of my scope. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Marc Véron <veron@veron.ch> --- Setting to NSO. If there is a better solution, I'll be happy to sign off on an alternative patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- The "close" class on that link is what gives it its functionality. There's a globally-defined trigger for "windows.close()" on .close. Otherwise I think this is a good solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63777|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 63854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63854&action=edit Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. (Amended for comment #5 / 2017-05-30 mv) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63854|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 63884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63884&action=edit Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. (Amended for comment #5 / 2017-05-31 mv) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63884|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 63885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63885&action=edit [SIGNED-OFF] Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. (Amended for comment #5 / 2017-05-31 mv) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |BLOCKED --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Blocked by bug 18545? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #9)
Blocked by bug 18545?
Bug 18545 is now pushed master, rebase this one ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18545 --- Comment #11 from Marc Véron <veron@veron.ch> --- This solution does no longer work on top of Bug 18545 because the JavaScript is triggered by classes "brief", "detail" etc., and they display the original sprites / icons. As a result, we get two icons if we add the Famfamfam icons. For the original aim of this bug see comment #1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|BLOCKED |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Patch doesn't apply |RESOLVED --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- This looks to me to be fixed now. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org