[Bug 31473] New: Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Bug ID: 31473 Summary: Test about bad OpacHiddenItems conf fragile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org It tests for data truncation (when a two-letter string is passed for a tinyint(1) field) but there's been some behavior change in the way expressions are processed that makes the test fail: # Failed test at t/db_dependent/Koha/Items.t line 1754. # got: 'Truncated incorrect DECIMAL value: 'AB'' # expected: 'Truncated incorrect DOUBLE value: 'AB'' The fact the expression was tested as a DECIMAL or a DOUBLE first is not really relevant here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |arthur.suzuki@biblibre.com, | |lucas@bywatersolutions.com, | |victor@tuxayo.net Depends on| |28125 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 [Bug 28125] All OPAC holds blocked when OPACHiddenItems contains incorrect values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 139849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139849&action=edit Bug 31473: Fix fragile test about bad OpacHiddenItems conf There's been a behavior change in recent MariaDB that made some cases deal with truncated data in DOUBLE context instead of DECIMAL. Probably this: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-27380 This made the affected test fail consistently on those versions. This trick for checking OpacHiddenItems is correct (as introduced on bug 28125 doesn't really make use of the warning, just prints it in about.pl) so one option was to just check for a warning. I decided to keep the test, but add the optional DECIMAL|DOUBLE check on the qr. This way other eventual changes will make it fail and serve as a warning in case something more relevant changes. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate, | |rel_21_11_candidate, | |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks a lot :D Backport needed down to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 21.05.19 released in| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Disregarding the backport cascade workflow. Not a problem with this patch. Now test can pass again! Backported: Pushed to 21.05.x branch for 21.05.19 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 21.05.19 |22.11.00, 22.05.06, released in| |21.05.19 Status|Pushed to master |Pushed to stable --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06, |22.11.00,21.11, 22.05.06, released in|21.05.19 |21.05.19 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06, |22.11.00,22.05.06,21.11.12, released in|21.05.19 |21.05.19 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org