https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 mohamed <mohamednofal909@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug 31086 |DB update of bug 31086 | |fails: Cannot change column | |'branchcode': used in a | |foreign key constraint Depends on| |31086 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 [Bug 31086] Do not allow hold requests with no branchcode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141336&action=edit Bug 31673: (bug 31086 follow-up) Drop and constraint to allow updating column It seems that we cannot edit the column while it has a constraint. If we remove it, update the oclumn, then re-add it, the update succeeds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Keith Sorbo <keith@thesorbos.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |keith@thesorbos.com --- Comment #2 from Keith Sorbo <keith@thesorbos.com> --- To help those who don't use diff, I have extracted the relevant sql to the following: ALTER TABLE reserves DROP FOREIGN KEY reserves_ibfk_4; ALTER TABLE reserves MODIFY COLUMN `branchcode` VARCHAR(10) COLLATE utf8mb4_unicode_ci NOT NULL; ALTER TABLE reserves ADD CONSTRAINT reserves_ibfk_4 FOREIGN KEY (branchcode) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE; -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141336|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141512&action=edit Bug 31673: (bug 31086 follow-up) Drop and constraint to allow updating column It seems that we cannot edit the column while it has a constraint. If we remove it, update the oclumn, then re-add it, the update succeeds Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141599&action=edit Bug 31673: (QA follow-up) Check if FK exists before attempt to remove Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.06 release -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to stable |RESOLVED --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 21.05.x, it shouldn't be affected, no backport. Dodged a bullet again :P -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.