[Bug 35567] New: Host-item in "Show analytics" link can be translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35567 Bug ID: 35567 Summary: Host-item in "Show analytics" link can be translated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: kevin.carnes@ub.lu.se QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr, jonathan.druart+koha@gmail.com The "Show analytics" link is built using text which can be translated. The following languages have already translated Host-item: fa-Arab, fi-FI, nl-NL, pt-BR, ru-RU, sv-SE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35567 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kevin.carnes@ub.lu.se |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35567 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35567 --- Comment #1 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 159819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159819&action=edit Bug 35567: Prevent translation of Host-item in "Show analytics" link The "Show analytics" link is built using text which can be translated. The following languages have already translated Host-item: fa-Arab, fi-FI, nl-NL, pt-BR, ru-RU, sv-SE To test: 1. Install one of the affected languages: koha-translate --install sv-SE --dev kohadev 2. Modify and save the following system preferences: language: enable the language OPACLanguages: enable the language opaclanguagesdisplay: Allow EasyAnalyticalRecords: Show 3. View a record with holdings and copy the barcode of one the items 4. Select the Edit dropdown menu above the record details and click "Link to host record" 5. Paste the barcode, click Select, and click OK 6. Return to Normal view of the record and reload the page 7. There should now be a "Show analytics" link 8. Hover over the link and note that the link contains "Host-item" 9. Switch to one of the affected languages and note that "Host-item" is translated 10. View the record in the OPAC and confirm that the link is also translated 11. Apply the patch 12. Update the affected language: koha-translate --update sv-SE --dev kohadev 13. Restart Koha (restart_all) 14. Notice that the links are no longer translated 15. Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35567 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35567 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159819|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159914&action=edit Bug 35567: Prevent translation of Host-item in "Show analytics" link The "Show analytics" link is built using text which can be translated. The following languages have already translated Host-item: fa-Arab, fi-FI, nl-NL, pt-BR, ru-RU, sv-SE To test: 1. Install one of the affected languages: koha-translate --install sv-SE --dev kohadev 2. Modify and save the following system preferences: language: enable the language OPACLanguages: enable the language opaclanguagesdisplay: Allow EasyAnalyticalRecords: Show 3. View a record with holdings and copy the barcode of one the items 4. Select the Edit dropdown menu above the record details and click "Link to host record" 5. Paste the barcode, click Select, and click OK 6. Return to Normal view of the record and reload the page 7. There should now be a "Show analytics" link 8. Hover over the link and note that the link contains "Host-item" 9. Switch to one of the affected languages and note that "Host-item" is translated 10. View the record in the OPAC and confirm that the link is also translated 11. Apply the patch 12. Update the affected language: koha-translate --update sv-SE --dev kohadev 13. Restart Koha (restart_all) 14. Notice that the links are no longer translated 15. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35567 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159914|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 160782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160782&action=edit Bug 35567: Prevent translation of Host-item in "Show analytics" link The "Show analytics" link is built using text which can be translated. The following languages have already translated Host-item: fa-Arab, fi-FI, nl-NL, pt-BR, ru-RU, sv-SE To test: 1. Install one of the affected languages: koha-translate --install sv-SE --dev kohadev 2. Modify and save the following system preferences: language: enable the language OPACLanguages: enable the language opaclanguagesdisplay: Allow EasyAnalyticalRecords: Show 3. View a record with holdings and copy the barcode of one the items 4. Select the Edit dropdown menu above the record details and click "Link to host record" 5. Paste the barcode, click Select, and click OK 6. Return to Normal view of the record and reload the page 7. There should now be a "Show analytics" link 8. Hover over the link and note that the link contains "Host-item" 9. Switch to one of the affected languages and note that "Host-item" is translated 10. View the record in the OPAC and confirm that the link is also translated 11. Apply the patch 12. Update the affected language: koha-translate --update sv-SE --dev kohadev 13. Restart Koha (restart_all) 14. Notice that the links are no longer translated 15. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35567 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor@tuxayo.net --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35567 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35567 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35567 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35567 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org