[Bug 35686] New: Case missing from installer step 3 template title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Bug ID: 35686 Summary: Case missing from installer step 3 template title Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/installer/install.pl?step=3&op=updatestr ucture OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com There is a case missing from the conditionals around title display for the installer's step 3. When you're on the "Updating database structure" step the first part of the page title is empty: " > Web installer > Koha" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160467&action=edit Bug 35686: Case missing from installer step 3 template title This patch adds a missing case to the display of the title on step 3 of the web installer. This resulted in an empty first part of the title: " > Web installer > Koha" To test, apply the patch and reset the database version from the command line in Koha Testing Docker:
koha-mysql kohadev UPDATE systempreferences SET value = '23.1200002 WHERE variable = 'version'; quit Restart all
- Go to the staff interface. You should be taken to the web installer. - Log in to the web installer and proceed through until you get to the "Updating database structure" page. - Confirm that the page title is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160467|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 160593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160593&action=edit Bug 35686: Case missing from installer step 3 template title This patch adds a missing case to the display of the title on step 3 of the web installer. This resulted in an empty first part of the title: " > Web installer > Koha" To test, apply the patch and reset the database version from the command line in Koha Testing Docker:
koha-mysql kohadev UPDATE systempreferences SET value = '23.1200002 WHERE variable = 'version'; quit Restart all
- Go to the staff interface. You should be taken to the web installer. - Log in to the web installer and proceed through until you get to the "Updating database structure" page. - Confirm that the page title is correct. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a web browser release notes| |page title for the web | |installer - from " > Web | |installer > Koha" to | |"Updating database | |structure > Web installer | |> Koha". CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Does the title displayed on the page need updating as well? Most pages have this title pattern, for example: Web installer › Update database On the page that this bug fixes, the page title is just: Updating database structure Should this be: Web installer › Updating database structure Testing notes using KTD: 1. I used this statement to update the version: UPDATE systempreferences SET value = '23.1200000' WHERE variable = 'version'; 2. Restart everything: restart_all 3. Go to the staff interface 4. Upgrade starts - Use koha_kohadev as the user and password as the password - Grant more privileges to the koha_kohadev user: . mysql -uroot -ppassword -hkoha-db-1 . use mysql . grant all on koha_kohadev.* to koha_kohadev; . flush privileges; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160627&action=edit Bug 35686: (follow-up) Correct page heading -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Straightforward and simple fixes, no issues with the QA tool. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160593|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 160677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160677&action=edit Bug 35686: Case missing from installer step 3 template title This patch adds a missing case to the display of the title on step 3 of the web installer. This resulted in an empty first part of the title: " > Web installer > Koha" To test, apply the patch and reset the database version from the command line in Koha Testing Docker:
koha-mysql kohadev UPDATE systempreferences SET value = '23.1200002 WHERE variable = 'version'; quit Restart all
- Go to the staff interface. You should be taken to the web installer. - Log in to the web installer and proceed through until you get to the "Updating database structure" page. - Confirm that the page title is correct. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160627|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 160678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160678&action=edit Bug 35686: (follow-up) Correct page heading Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Merge conflicts with 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org