[Bug 35126] New: Remove the use of event attributes from opac-addbybiblionumber.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 Bug ID: 35126 Summary: Remove the use of event attributes from opac-addbybiblionumber.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org There are some event attributes in opac-addbybiblionumber.pl. These should be removed in favour of defining events in JavaScript. ./opac/opac-addbybiblionumber.pl: print "<html><meta http-equiv=\"refresh\" content=\"0\" /><body onload=\"window.opener.location.reload(true);self.close();\"></body></html>"; ./opac/opac-addbybiblionumber.pl: print "<html><meta http-equiv=\"refresh\" content=\"0\" /><body onload=\"self.close();\"></body></html>"; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 [Bug 34709] Eliminate event handler attributes in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- These instances I'm honestly not concerned about. I don't think there would be a benefit to trying to change the way these work. Anyone is free to re-open it if I'm not seeing an issue with this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to Owen Leonard from comment #1)
These instances I'm honestly not concerned about. I don't think there would be a benefit to trying to change the way these work.
Anyone is free to re-open it if I'm not seeing an issue with this.
There's not an immediate issue, but one day if/when we have a Content-Security-Policy, these will stop working. I haven't looked at the script specifically to see what the impact of that will be. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Should this be done before Bug 20397? Or should the challenges specific to 20397 be tackled first before coming back to this ticket? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Victor Grousset/tuxayo from comment #3)
Should this be done before Bug 20397? Or should the challenges specific to 20397 be tackled first before coming back to this ticket?
Yeah, it should be done before bug 20397. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au Resolution|WONTFIX |--- Status|RESOLVED |REOPENED --- Comment #5 from David Cook <dcook@prosentient.com.au> --- I'll reopen and take it as assignee. Probably won't do it right away but have it on my TODO list... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 --- Comment #6 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 172332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172332&action=edit Bug 35126: Remove onload from opac-addbybiblionumber.pl To test: Case a) Adding to a new list 1. Enable virtualshelves system preference 2. Search for any record and click it 3. On the right hand side of record view, click "Save to your lists" 4. A new pop up opens. 5. Under "Add to a new list", give any name to the list 6. Under "Add to a new list", click "Save" 7. Observe popup closing 8. Observe record view page reloading Case b) Adding to an existing list 1. Enable virtualshelves system preference 2. Search for any record and click it 3. On the right hand side of record view, click "Save to your lists" 4. A new pop up opens. 5. Under "Add to a list", select an existing list (it can be the same as the one you created in case a, it does not matter here) 6. Under "Add to a list", click "Save" 7. Observe popup closing 8. Unlike case a, observe record view page NOT reloading -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook@prosentient.com.au |lari.taskula@hypernova.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Just on a call at the moment, but I'm hoping to look at this today -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Yep, good enough. Works as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172332|0 |1 is obsolete| | --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Created attachment 173247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173247&action=edit Bug 35126: Remove onload from opac-addbybiblionumber.pl To test: Case a) Adding to a new list 1. Enable virtualshelves system preference 2. Search for any record and click it 3. On the right hand side of record view, click "Save to your lists" 4. A new pop up opens. 5. Under "Add to a new list", give any name to the list 6. Under "Add to a new list", click "Save" 7. Observe popup closing 8. Observe record view page reloading Case b) Adding to an existing list 1. Enable virtualshelves system preference 2. Search for any record and click it 3. On the right hand side of record view, click "Save to your lists" 4. A new pop up opens. 5. Under "Add to a list", select an existing list (it can be the same as the one you created in case a, it does not matter here) 6. Under "Add to a list", click "Save" 7. Observe popup closing 8. Unlike case a, observe record view page NOT reloading Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173247|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 174063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174063&action=edit Bug 35126: Remove onload from opac-addbybiblionumber.pl To test: Case a) Adding to a new list 1. Enable virtualshelves system preference 2. Search for any record and click it 3. On the right hand side of record view, click "Save to your lists" 4. A new pop up opens. 5. Under "Add to a new list", give any name to the list 6. Under "Add to a new list", click "Save" 7. Observe popup closing 8. Observe record view page reloading Case b) Adding to an existing list 1. Enable virtualshelves system preference 2. Search for any record and click it 3. On the right hand side of record view, click "Save to your lists" 4. A new pop up opens. 5. Under "Add to a list", select an existing list (it can be the same as the one you created in case a, it does not matter here) 6. Under "Add to a list", click "Save" 7. Observe popup closing 8. Unlike case a, observe record view page NOT reloading Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove the use of event |Remove the use of event |attributes from |attributes from when adding |opac-addbybiblionumber.pl |records to lists in the | |OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED --- Comment #14 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org