[Bug 10651] New: Use new DataTables include in administration templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10651 Bug ID: 10651 Summary: Use new DataTables include in administration templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 10649 Administration templates which use the DataTables plugin should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10651 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10651 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20968&action=edit Bug 10651 - Use new DataTables include in administration templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all administration-related pages which use DataTables. To test, view the following pages and confirm that table sorting is still working correctly: - Administration -> Budgets - Administration -> Authority types -> MARC structure - Administration -> Authorized values - Administration -> Library transfer limits - Administration -> Libraries and groups - Administration -> Patron types and categories - Administration -> Cities and towns - Administration -> Item types - Administration -> MARC bibliographic framework -> MARC structure - Administration -> System preferences - Administration -> System preferences -> Local use - Administration -> Z39.50 client targets -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10651 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20968|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21259&action=edit [SIGNED-OFF] Bug 10651 - Use new DataTables include in administration templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all administration-related pages which use DataTables. To test, view the following pages and confirm that table sorting is still working correctly: - Administration -> Budgets - Administration -> Authority types -> MARC structure - Administration -> Authorized values - Administration -> Library transfer limits - Administration -> Libraries and groups - Administration -> Patron types and categories - Administration -> Cities and towns - Administration -> Item types - Administration -> MARC bibliographic framework -> MARC structure - Administration -> System preferences - Administration -> System preferences -> Local use - Administration -> Z39.50 client targets Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10651 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10651 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21259|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21269&action=edit Bug 10651 - Use new DataTables include in administration templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all administration-related pages which use DataTables. To test, view the following pages and confirm that table sorting is still working correctly: - Administration -> Budgets - Administration -> Authority types -> MARC structure - Administration -> Authorized values - Administration -> Library transfer limits - Administration -> Libraries and groups - Administration -> Patron types and categories - Administration -> Cities and towns - Administration -> Item types - Administration -> MARC bibliographic framework -> MARC structure - Administration -> System preferences - Administration -> System preferences -> Local use - Administration -> Z39.50 client targets Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No koha-qa errors Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10651 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21270&action=edit Bug 10651 - Followup Use new DataTables include in administration templates The aqbudgets.tt needs to use the include file too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10651 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: The admin fund page was missing. Owen, could you explain me why the css file is not include in the include file please? Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10651 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #5)
Owen, could you explain me why the css file is not include in the include file please?
Perhaps it would have been better to do it that way. I was thinking of a time in the future when I would like to move all JavaScript to the end of each page instead of the beginning, and CSS would need to stay at the top. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10651 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org