[Bug 10868] New: Use new DataTables include in catalog templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868 Bug ID: 10868 Summary: Use new DataTables include in catalog templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Catalog templates which use the DataTables plugin should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20969&action=edit Bug 10868 - Use new DataTables include in catalog templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all catalog-related pages which use DataTables. The checkout history script has been altered to send unformatted dates to the template, and the template now uses the "title-string" sorting filter to enable sorting on unformatted dates. To test, view the following pages and confirm that table sorting is still working correctly: Catalog -> Biblio detail page Catalog -> Biblio detail page -> Checkout history -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20969|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21260&action=edit [SIGNED-OFF] Bug 10868 - Use new DataTables include in catalog templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all catalog-related pages which use DataTables. The checkout history script has been altered to send unformatted dates to the template, and the template now uses the "title-string" sorting filter to enable sorting on unformatted dates. To test, view the following pages and confirm that table sorting is still working correctly: Catalog -> Biblio detail page Catalog -> Biblio detail page -> Checkout history Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21260|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21271&action=edit Bug 10868 - Use new DataTables include in catalog templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all catalog-related pages which use DataTables. The checkout history script has been altered to send unformatted dates to the template, and the template now uses the "title-string" sorting filter to enable sorting on unformatted dates. To test, view the following pages and confirm that table sorting is still working correctly: Catalog -> Biblio detail page Catalog -> Biblio detail page -> Checkout history Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No koha-qa errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Note: On the issue history page: 1/ If the checkin on is empty (the item is currently checked out), the line is sorted in last. 2/ The Renewed column is not sorted by date. Before this patch, the sort was worse. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- I added a new test in qa tools in order to avoid new insertion of "jquery.dataTables.min.js". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org