[Bug 22646] New: Fix use of PrivacyPolicyURL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 Bug ID: 22646 Summary: Fix use of PrivacyPolicyURL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- Bug 20819 introduced two new sysprefs: GDPR_Policy and PrivacyPolicyURL. The latter is used in a couple of places in the code: * koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-patron-consent.tt, line 44: 38 [% IF Koha.Preference('GDPR_Policy') %] ... 44 <p>I have read the <a target="_blank" href="[% Koha.Preference('PrivacyPolicyURL') | url %]">privacy policy</a> and agree with your processing of my personal data as outlined therein.</p> * koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt, line 906: 901 [% IF Koha.Preference('GDPR_Policy') && action != 'edit' %] ... 906 <label></label><span><input type="checkbox" name="borrower_gdpr_proc_consent" value="agreed"> I agree with your processing of my personal data as outlined in the <a target="_blank" href="[% PrivacyPolicyURL | url %]">privacy policy</a>. <span class="required">Required</span></span> Two problems here: 1. The second occurence forgets to do Koha.Preference('PrivacyPolicyURL'), so no URL is included in the page 2. Neither occurence checks if PrivacyPolicyURL is defined before using it, but the description of PrivacyPolicyURL does not say that it is mandatory if GDPR_Policy is defined. So do we check if PrivacyPolicyURL is defined before displaying the link, or do we say that PrivacyPolicyURL is mandatory if GDPR_Policy is set? Personally I am under the impression that having a public privacy policy is part of being GDPR compliant, so I will submit a patch that adds a "mandatory" text to the sysprefs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 87439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87439&action=edit Bug 22646 - Fix use of PrivacyPolicyURL To test: PatronSelfRegistration = Allow PatronSelfRegistrationDefaultCategory = PT (or some other real category) GDPR_Policy = Enforced PrivacyPolicyURL = Some URL - Go to <opac>/cgi-bin/koha/opac-memberentry.pl and verify that the text "privacy policy" displays a link to the current page, not the URL in PrivacyPolicyURL - Go to Administration > System preferences > Patrons > Privacy - Verify that the descriptions of GDPR_Policy and PrivacyPolicyURL does not mention that PrivacyPolicyURL needs to be set if GDPR_Policy is set. - Apply the patch - Verify that opac-memberentry.pl now links to the URL in PrivacyPolicyURL - Verify that the syspref descriptions mention the relationship between them -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87439|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87452&action=edit Bug 22646: Fix use of PrivacyPolicyURL To test: PatronSelfRegistration = Allow PatronSelfRegistrationDefaultCategory = PT (or some other real category) GDPR_Policy = Enforced PrivacyPolicyURL = Some URL - Go to <opac>/cgi-bin/koha/opac-memberentry.pl and verify that the text "privacy policy" displays a link to the current page, not the URL in PrivacyPolicyURL - Go to Administration > System preferences > Patrons > Privacy - Verify that the descriptions of GDPR_Policy and PrivacyPolicyURL does not mention that PrivacyPolicyURL needs to be set if GDPR_Policy is set. - Apply the patch - Verify that opac-memberentry.pl now links to the URL in PrivacyPolicyURL - Verify that the syspref descriptions mention the relationship between them Signed-off-by: Liz Rea <wizzyrea@gmail.com> Fixed commit message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 Bin <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87452|0 |1 is obsolete| | --- Comment #3 from Bin <bin.wen@inlibro.com> --- Created attachment 87454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87454&action=edit Bug 22646: Fix use of PrivacyPolicyURL To test: PatronSelfRegistration = Allow PatronSelfRegistrationDefaultCategory = PT (or some other real category) GDPR_Policy = Enforced PrivacyPolicyURL = Some URL - Go to <opac>/cgi-bin/koha/opac-memberentry.pl and verify that the text "privacy policy" displays a link to the current page, not the URL in PrivacyPolicyURL - Go to Administration > System preferences > Patrons > Privacy - Verify that the descriptions of GDPR_Policy and PrivacyPolicyURL does not mention that PrivacyPolicyURL needs to be set if GDPR_Policy is set. - Apply the patch - Verify that opac-memberentry.pl now links to the URL in PrivacyPolicyURL - Verify that the syspref descriptions mention the relationship between them Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |magnus@libriotech.no |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87454|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87468&action=edit Bug 22646: Fix use of PrivacyPolicyURL To test: PatronSelfRegistration = Allow PatronSelfRegistrationDefaultCategory = PT (or some other real category) GDPR_Policy = Enforced PrivacyPolicyURL = Some URL - Go to <opac>/cgi-bin/koha/opac-memberentry.pl and verify that the text "privacy policy" displays a link to the current page, not the URL in PrivacyPolicyURL - Go to Administration > System preferences > Patrons > Privacy - Verify that the descriptions of GDPR_Policy and PrivacyPolicyURL does not mention that PrivacyPolicyURL needs to be set if GDPR_Policy is set. - Apply the patch - Verify that opac-memberentry.pl now links to the URL in PrivacyPolicyURL - Verify that the syspref descriptions mention the relationship between them Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20819 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 18.05.x, not backporting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org