[Bug 22595] New: Items search is mixing inputs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Bug ID: 22595 Summary: Items search is mixing inputs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Items search is using inputs and selects from search form to create an Ajax call. In this call selects are parsed before inputs. But a custom search field can be used with authorised values and used after a regular search field. In this case the "q" param is not ordered like the "name" param. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20888 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 [Bug 22596] html TT filter is breaking items search with custom field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 87076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87076&action=edit Bug 22595: Items search is mixing inputs Items search is using inputs and selects from search form to create an Ajax call. In this call selects are parsed before inputs. But a custom search field can be used with authorised values and used after a regular search field. In this case the "q" param is not ordered like the "name" param. Test plan : 1) Go to Administration > Item search fields 2) Define a search field with an authorised values category 3) Go to items search 4) Use a regular filter like call number 5) Click on new field 6) Use custom field with an authorised value 7) Perform search => Without patch you get wrong resuts, authorised value is used as value for first field => You can see this by listening traffic in Firebug, look at params "f" and "q" 8) Check some combinaison of select and input filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87076|0 |1 is obsolete| | --- Comment #2 from Michal Denar <black23@gmail.com> --- Created attachment 87480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87480&action=edit Bug 22595: Items search is mixing inputs Items search is using inputs and selects from search form to create an Ajax call. In this call selects are parsed before inputs. But a custom search field can be used with authorised values and used after a regular search field. In this case the "q" param is not ordered like the "name" param. Test plan : 1) Go to Administration > Item search fields 2) Define a search field with an authorised values category 3) Go to items search 4) Use a regular filter like call number 5) Click on new field 6) Use custom field with an authorised value 7) Perform search => Without patch you get wrong resuts, authorised value is used as value for first field => You can see this by listening traffic in Firebug, look at params "f" and "q" 8) Check some combinaison of select and input filters Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87480|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87562&action=edit Bug 22595: Items search is mixing inputs Items search is using inputs and selects from search form to create an Ajax call. In this call selects are parsed before inputs. But a custom search field can be used with authorised values and used after a regular search field. In this case the "q" param is not ordered like the "name" param. Test plan : 1) Go to Administration > Item search fields 2) Define a search field with an authorised values category 3) Go to items search 4) Use a regular filter like call number 5) Click on new field 6) Use custom field with an authorised value 7) Perform search => Without patch you get wrong resuts, authorised value is used as value for first field => You can see this by listening traffic in Firebug, look at params "f" and "q" 8) Check some combinaison of select and input filters Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependency for 18.05.x, wont backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org