[Bug 14112] New: Silence warnings t/Charset.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Bug ID: 14112 Summary: Silence warnings t/Charset.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: gmcharlt@gmail.com Self-explanitory. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |8879 Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38753&action=edit Bug 14112: Silence warnings in t/Charset.t Running prove on t/Charset.t had a complaint about a better way to write \c3. This suppresses it. TEST PLAN --------- 1) $ prove t/Charset.t -- get a warning 2) apply patch 3) $ prove t/Charset.t 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38753|0 |1 is obsolete| | --- Comment #2 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39014&action=edit Bug 14112: Silence warnings in t/Charset.t Running prove on t/Charset.t had a complaint about a better way to write \c3. This suppresses it. TEST PLAN --------- 1) $ prove t/Charset.t -- get a warning 2) apply patch 3) $ prove t/Charset.t 4) run koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39014|0 |1 is obsolete| | --- Comment #3 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39015&action=edit Bug 14112: Silence warnings in t/Charset.t Running prove on t/Charset.t had a complaint about a better way to write \c3. This suppresses it. TEST PLAN --------- 1) $ prove t/Charset.t -- get a warning 2) apply patch 3) $ prove t/Charset.t 4) run koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- I am not sure it's the right way to fix it, have a look at http://perldoc.perl.org/perldiag.html#Character-following-%22\c%22-must-be-printable-ASCII -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39015|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39406&action=edit Bug 14112 - Silence warnings in t/Charset.t After Jonathan said this was the wrong way to correct the issue, www.utf8-chartable.de made it clear to me that the \c3\a9 were missing x's. TEST PLAN --------- 1) prove t/Charset.t -- noise 2) apply patch 3) prove t/Charset.t -- no noise 4) koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39406|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 39545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39545&action=edit Bug 14112 - Silence warnings in t/Charset.t After Jonathan said this was the wrong way to correct the issue, www.utf8-chartable.de made it clear to me that the \c3\a9 were missing x's. TEST PLAN --------- 1) prove t/Charset.t -- noise 2) apply patch 3) prove t/Charset.t -- no noise 4) koha qa test tools Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39545|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39570&action=edit Bug 14112 - Silence warnings in t/Charset.t After Jonathan said this was the wrong way to correct the issue, www.utf8-chartable.de made it clear to me that the \c3\a9 were missing x's. TEST PLAN --------- 1) prove t/Charset.t -- noise 2) apply patch 3) prove t/Charset.t -- no noise 4) koha qa test tools Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #10 from Liz Rea <wizzyrea@gmail.com> --- Patch pushed to 3.18.x will be in 3.18.08 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org