[Bug 14203] New: koha-translate error string for non-existent lang removal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Bug ID: 14203 Summary: koha-translate error string for non-existent lang removal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: indradg@gmail.com Reporter: indradg@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com An attempt to remove a language that is not installed shows the message: "Error: the selected language is not already installed." I feel that it will be nicer to just have "Error: the selected language is not installed." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 --- Comment #1 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39202&action=edit Bug 14203 - Message for non-existent lang removal A trivial string patch to update the error message displayed to user if koha-translate is used to attempt removal of a language that is not installed. Test plan ========= 1/ attempt to remove a non-existent language by <installdir>/debian/scripts/koha-translate --remove <langcode> 2/ it should show "Error: the selected language is not already installed." 3/ apply patch 4/ repeat step 1; it should show "Error: the selected language is not installed." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39202|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 39204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39204&action=edit [SIGNED OFF] Bug 14203 - Message for non-existent lang removal A trivial string patch to update the error message displayed to user if koha-translate is used to attempt removal of a language that is not installed. Test plan ========= 1/ attempt to remove a non-existent language by <installdir>/debian/scripts/koha-translate --remove <langcode> 2/ it should show "Error: the selected language is not already installed." 3/ apply patch 4/ repeat step 1; it should show "Error: the selected language is not installed." Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39204|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39422&action=edit Bug 14203 - Message for non-existent lang removal A trivial string patch to update the error message displayed to user if koha-translate is used to attempt removal of a language that is not installed. Test plan ========= 1/ attempt to remove a non-existent language by <installdir>/debian/scripts/koha-translate --remove <langcode> 2/ it should show "Error: the selected language is not already installed." 3/ apply patch 4/ repeat step 1; it should show "Error: the selected language is not installed." Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39423&action=edit [PASSED QA] Bug 14203 - Message for non-existent lang removal A trivial string patch to update the error message displayed to user if koha-translate is used to attempt removal of a language that is not installed. Test plan ========= 1/ attempt to remove a non-existent language by <installdir>/debian/scripts/koha-translate --remove <langcode> 2/ it should show "Error: the selected language is not already installed." 3/ apply patch 4/ repeat step 1; it should show "Error: the selected language is not installed." Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Attachment #39423|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Comment on attachment 39423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39423 [PASSED QA] Bug 14203 - Message for non-existent lang removal Obsoleting because Jonathan beat me to it! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Indranil! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Patch pushed to 3.18.x will be in 3.18.08 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org