[Bug 39229] New: Search unique extended attributes on patron quicksearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 Bug ID: 39229 Summary: Search unique extended attributes on patron quicksearch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The patron search can be very slow when the number of patrons becomes sufficiently large. At our we routinely search for social security number for example (which is a unique extended patron attribute), and this could be so much faster if unique attributes where first queried in the same manner as librarycard is in member.pl (when quicksearch is set). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178892&action=edit Bug 39229: Search unique extended attributes on patron quicksearch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 --- Comment #2 from David Gustafsson <glasklas@gmail.com> --- Forgot to add how to test etc in commit message, will do so tomorrow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178892|0 |1 is obsolete| | --- Comment #3 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178932&action=edit Bug 39229: Search unique extended attributes on patron quicksearch To test: 1) Apply patch 2) Create a unique extended patron attribute, set it to "Searchable" and and "Searched by default" 3) Edit a patron and set a value for the created attribute. 4) Enable UniqueExtendedAttributesQuickSearch syspref 5) Edit memebers/member.pl, after the if (@attributes_conditinos) block, around line 93, write "exit;" and save the file. 6) Perforn a search on the patron attribute value 7) A redirect to the patron page should occur 8) Search for something else not matching the attribute 9) You should now recieve a 500 error (since the script exits prematurely, and the normal search is never run) Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 --- Comment #4 from David Gustafsson <glasklas@gmail.com> --- I now created a test plan, but it's unfortunately pretty convoluted. If one has access to a koha instance with at least tens of thousands of patrons, preferably more, there would be a clear difference in response time. But if the number is smaller, it is very hard to notice a difference and hard to test. Exiting the script after the unique attributes quicksearch has been performed was the only way I could figure out, but other suggestions are welcome. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178932|0 |1 is obsolete| | --- Comment #5 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178970&action=edit Bug 39229: Search unique extended attributes on patron quicksearch To test: 1) Apply patch 2) Create a unique extended patron attribute, set it to "Searchable" and and "Searched by default" 3) Edit a patron and set a value for the created attribute. 4) Enable UniqueExtendedAttributesQuickSearch syspref 5) Edit memebers/member.pl, before "my $searchfieldstype = ..." around line 94, write "exit;" and save the file. 6) Perform a search on the patron attribute value 7) A redirect to the patron page should occur 8) Search for something else not matching the attribute 9) You should now recieve a 500 error (since the script exits prematurely, and the normal search is never run) Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 --- Comment #6 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178971&action=edit Bug 39229: Also try to find patron by borrowernumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178970|0 |1 is obsolete| | --- Comment #7 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178972&action=edit Bug 39229: Search unique extended attributes on patron quicksearch To test: 1) Apply patch 2) Create a unique extended patron attribute, set it to "Searchable" and and "Searched by default" 3) Edit a patron and set a value for the created attribute. 4) Enable UniqueExtendedAttributesQuickSearch syspref 5) Edit memebers/member.pl, before "my $searchfieldstype = ..." around line 94, write "exit;" and save the file. 6) Perform a search on the patron attribute value 7) A redirect to the patron page should occur 8) Search for something else not matching the attribute 9) You should now recieve a 500 error (since the script exits prematurely, and the normal search is never run) 10) Repeat steps 6 to 9 using borrowernumber instead of extended attribute value Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178971|0 |1 is obsolete| | --- Comment #8 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178973&action=edit Bug 39229: Also try to find patron by borrowernumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search unique extended |Search additional unique |attributes on patron |patron properties on patron |quicksearch |quicksearch --- Comment #9 from David Gustafsson <glasklas@gmail.com> --- I also added quicksearch using borrowernumber. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 --- Comment #10 from David Gustafsson <glasklas@gmail.com> --- I also added finding patron by borrowernumber quicksearch and edited the bug name to reflect the change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178972|0 |1 is obsolete| | --- Comment #11 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178974&action=edit Bug 39229: Search unique extended attributes on patron quicksearch To test: 1) Apply patch 2) Create a unique extended patron attribute, set it to "Searchable" and and "Searched by default" 3) Edit a patron and set a value for the created attribute. 4) Enable UniqueExtendedAttributesQuickSearch syspref 5) Edit memebers/member.pl, before "my $searchfieldstype = ..." around line 94, write "exit;" and save the file. 6) Perform a search on the patron attribute value 7) A redirect to the patron page should occur 8) Search for something else not matching the attribute 9) You should now recieve a 500 error (since the script exits prematurely, and the normal search is never run) 10) Repeat steps 6 to 9 using borrowernumber instead of extended attribute value Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178973|0 |1 is obsolete| | --- Comment #12 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178975&action=edit Bug 39229: Also try to find patron by borrowernumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178975|0 |1 is obsolete| | --- Comment #13 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178995&action=edit Bug 39229: Also try to find patron by userid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 --- Comment #14 from David Gustafsson <glasklas@gmail.com> --- My mistake, should have been userid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178974|0 |1 is obsolete| | --- Comment #15 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178996&action=edit Bug 39229: Search unique extended attributes on patron quicksearch To test: 1) Apply patch 2) Create a unique extended patron attribute, set it to "Searchable" and and "Searched by default" 3) Edit a patron and set a value for the created attribute. 4) Enable UniqueExtendedAttributesQuickSearch syspref 5) Edit memebers/member.pl, before "my $searchfieldstype = ..." around line 94, write "exit;" and save the file. 6) Perform a search on the patron attribute value 7) A redirect to the patron page should occur 8) Search for something else not matching the attribute 9) You should now recieve a 500 error (since the script exits prematurely, and the normal search is never run) 10) Repeat steps 6 to 9 using userid instead of extended attribute value Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178995|0 |1 is obsolete| | --- Comment #16 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178997&action=edit Bug 39229: Also try to find patron by userid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 --- Comment #17 from David Gustafsson <glasklas@gmail.com> --- Created attachment 180780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180780&action=edit Bug 39229: Also handle the case when performing a patron checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com --- Comment #18 from Esther Melander <esther.melander@bywatersolutions.com> --- I tested this and got to step 6. Is the quicksearch done in the green tool bar at top? If that is the case, I did not get a redirect to the patron page and received a 500 error. Searches for other terms that were not an attribute also returned a 500 error. I also did the search from the Patron module using the search form on the left side of the page. I searched for the attribute using the standard parameter.The patron was in the patron search results list. Searching for other terms gave blank results and no 500 error. I stopped at this point because I wasn't sure if I was following the test plan correctly. I did edit the members/member.pl file as instructed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- Automated patch testing results: [FAIL] PATCH DOES NOT APPLY One or more patches do not apply cleanly to the current codebase. Please rebase your patches and upload new versions. **Patch Results:** [FAIL] Bug-39229-Also-handle-the-case-when-performing-a-p.patch (ID: 180780) Status: FAILURE - Patch does not apply Error: error: patch failed: members/member.pl:60 [FAIL] Bug-39229-Also-try-to-find-patron-by-userid.patch (ID: 178997) Status: FAILURE - Patch does not apply Error: error: patch failed: members/member.pl:68 [PASS] Bug-39229-Search-unique-extended-attributes-on-pat.patch (ID: 178996) Status: SUCCESS + Patch applies cleanly --- This is an automated message from the patch testing system. Tested against branch: main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 --- Comment #20 from Chris Cormack <chris@bigballofwax.co.nz> --- Automated patch testing results: [FAIL] PATCH DOES NOT APPLY One or more patches do not apply cleanly to the current codebase. Please rebase your patches and upload new versions. **Patch Results:** [FAIL] Bug-39229-Also-handle-the-case-when-performing-a-p.patch (ID: 180780) Status: FAILURE - Patch does not apply [FAIL] Bug-39229-Also-try-to-find-patron-by-userid.patch (ID: 178997) Status: FAILURE - Patch does not apply [PASS] Bug-39229-Search-unique-extended-attributes-on-pat.patch (ID: 178996) Status: SUCCESS + Patch applies cleanly --- This is an automated message from the patch testing system. Tested against branch: main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178996|0 |1 is obsolete| | --- Comment #21 from David Gustafsson <glasklas@gmail.com> --- Created attachment 189937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189937&action=edit Bug 39229: Search unique extended attributes on patron quicksearch To test: 1) Apply patch 2) Create a unique extended patron attribute, set it to "Searchable" and and "Searched by default" 3) Edit a patron and set a value for the created attribute. 4) Enable UniqueExtendedAttributesQuickSearch syspref 5) Edit members/member.pl, before "my $searchfieldstype = ..." around line 101, write "exit;" and save the file. 6) Perform a search on the patron attribute value 7) A redirect to the patron page should occur 8) Search for something else not matching the attribute 9) You should now recieve a 500 error (since the script exits prematurely, and the normal search is never run) 10) Repeat steps 6 to 9 using userid instead of extended attribute value Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178997|0 |1 is obsolete| | --- Comment #22 from David Gustafsson <glasklas@gmail.com> --- Created attachment 189938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189938&action=edit Bug 39229: Also try to find patron by userid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180780|0 |1 is obsolete| | --- Comment #23 from David Gustafsson <glasklas@gmail.com> --- Created attachment 189939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189939&action=edit Bug 39229: Also handle the case when performing a patron checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #24 from David Gustafsson <glasklas@gmail.com> --- It applied cleanly for me, so no rebase appeared to be needed. But fixed some typos in the test plan. @Esther Melander I tested it out and worked for me, perhaps you forgot to make the attribute unique? The testplan could perhaps be made clearer on that point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This requires a little work as we changed how system preferences are added: https://wiki.koha-community.org/wiki/System_Preferences The changes will be required for sysprefs.sql and the atomic update file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189937|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189938|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 --- Comment #26 from David Gustafsson <glasklas@gmail.com> --- Created attachment 208310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208310&action=edit Bug 39229: Search unique extended attributes on patron quicksearch To test: 1) Apply patch 2) Create a unique extended patron attribute, set it to "Searchable" and and "Searched by default" 3) Edit a patron and set a value for the created attribute. 4) Enable UniqueExtendedAttributesQuickSearch syspref 5) Edit members/member.pl, before "my $searchfieldstype = ..." around line 101, write "exit;" and save the file. 6) Perform a search on the patron attribute value 7) A redirect to the patron page should occur 8) Search for something else not matching the attribute 9) You should now recieve a 500 error (since the script exits prematurely, and the normal search is never run) 10) Repeat steps 6 to 9 using userid instead of extended attribute value Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 --- Comment #27 from David Gustafsson <glasklas@gmail.com> --- Created attachment 208311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208311&action=edit Bug 39229: Also try to find patron by userid Patch from commit df79af2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 --- Comment #28 from David Gustafsson <glasklas@gmail.com> --- Created attachment 208312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208312&action=edit Bug 39229: Also handle the case when performing a patron checkout Patch from commit decba17 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 --- Comment #29 from David Gustafsson <glasklas@gmail.com> --- Created attachment 208313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208313&action=edit Add custom special handling of extended attributes PNR and PNR12 Patch from commit 37b4b01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 --- Comment #30 from David Gustafsson <glasklas@gmail.com> --- Created attachment 208314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208314&action=edit KOHA-2094 Try 1900 and 2000 for 10 digit PNR against PNR12 in quicksearch Patch from commit f3d72c6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39229 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #31 from David Gustafsson <glasklas@gmail.com> --- Rebased against main. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org