[Bug 41563] New: Tidy kohaTable block - acqui
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Bug ID: 41563 Summary: Tidy kohaTable block - acqui Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 41324 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 [Bug 41324] Tidy kohaTable block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191069&action=edit Bug 41563: Tidy kohaTable - acqui/acqui-home.tt See bug 41324 comment 6 1. Variable serialization -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191070&action=edit Bug 41563: Tidy kohaTable - acqui/basket.tt See bug 41324 comment 6 1. Variable serialization 3. "table_settings" variable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191071&action=edit Bug 41563: Tidy kohaTable - acqui/basketgroup.tt See bug 41324 comment 6 1. Variable serialization -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191072&action=edit Bug 41563: Tidy kohaTable - acqui/duplicate_orders.tt See bug 41324 comment 6 1. Variable serialization -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191073&action=edit Bug 41563: Tidy kohaTable - acqui/histsearch.tt See bug 41324 comment 6 1. Variable serialization -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191074&action=edit Bug 41563: Tidy kohaTable - acqui/invoice.tt See bug 41324 comment 6 1. Variable serialization -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191075&action=edit Bug 41563: Tidy kohaTable - acqui/lateorders.tt See bug 41324 comment 6 1. Variable serialization -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191076&action=edit Bug 41563: Tidy kohaTable - acqui/newordersuggestion.tt See bug 41324 comment 6 1. Variable serialization -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191077&action=edit Bug 41563: Tidy kohaTable - acqui/orderreceive.tt See bug 41324 comment 6 1. Variable serialization 2. Use of permissions and sysprefs We also removed 'UniqueItemFields' from the controller. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191078&action=edit Bug 41563: Tidy kohaTable - acqui/parcel.tt See bug 41324 comment 6 1. Variable serialization 2. Use of permissions and sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191079&action=edit Bug 41563: Tidy kohaTable - acqui/vendor_issues.tt See bug 41324 comment 6 1. Variable serialization -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191080&action=edit Bug 41563: acqui - auto tidy Patch from commit d0220eb -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39715 [Bug 39715] Do not quote DataTables options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41562 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41562 [Bug 41562] Introduce the concept of "stores" for regular javascript -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191069|0 |1 is obsolete| | Attachment #191070|0 |1 is obsolete| | Attachment #191071|0 |1 is obsolete| | Attachment #191072|0 |1 is obsolete| | Attachment #191073|0 |1 is obsolete| | Attachment #191074|0 |1 is obsolete| | Attachment #191075|0 |1 is obsolete| | Attachment #191076|0 |1 is obsolete| | Attachment #191077|0 |1 is obsolete| | Attachment #191078|0 |1 is obsolete| | Attachment #191079|0 |1 is obsolete| | Attachment #191080|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191290&action=edit Bug 41563: Tidy kohaTable - acqui/acqui-home.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191291&action=edit Bug 41563: Tidy kohaTable - acqui/basket.tt See bug 41324 comment 6 1. Variable serialization 3. "table_settings" variable Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191292&action=edit Bug 41563: Tidy kohaTable - acqui/basketgroup.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191293&action=edit Bug 41563: Tidy kohaTable - acqui/duplicate_orders.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191294&action=edit Bug 41563: Tidy kohaTable - acqui/histsearch.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191295&action=edit Bug 41563: Tidy kohaTable - acqui/invoice.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191296&action=edit Bug 41563: Tidy kohaTable - acqui/lateorders.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191297&action=edit Bug 41563: Tidy kohaTable - acqui/newordersuggestion.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191298&action=edit Bug 41563: Tidy kohaTable - acqui/orderreceive.tt See bug 41324 comment 6 1. Variable serialization 2. Use of permissions and sysprefs We also removed 'UniqueItemFields' from the controller. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191299&action=edit Bug 41563: Tidy kohaTable - acqui/parcel.tt See bug 41324 comment 6 1. Variable serialization 2. Use of permissions and sysprefs Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191300&action=edit Bug 41563: Tidy kohaTable - acqui/vendor_issues.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191301&action=edit Bug 41563: acqui - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191302&action=edit Bug 41563: (follow-up) Fix two typos -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191303&action=edit Bug 41563: (follow-up) Tidy parcel.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192026&action=edit Bug 41563: Remove JS error from newordersuggestion Not caused by this patchset but it's a good place to fix it (and not add a conflict) Uncaught TypeError: can't access property "DataTable", suggestionst is undefined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191303|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192026|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192730&action=edit Bug 41563: (follow-up) Tidy parcel.tt Patch from commit d3cee2d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192731&action=edit Bug 41563: Remove JS error from newordersuggestion Not caused by this patchset but it's a good place to fix it (and not add a conflict) Uncaught TypeError: can't access property "DataTable", suggestionst is undefined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- Fixed conflict with bug 41420 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191290|0 |1 is obsolete| | --- Comment #31 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192748&action=edit Bug 41563: Tidy kohaTable - acqui/acqui-home.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191291|0 |1 is obsolete| | --- Comment #32 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192749&action=edit Bug 41563: Tidy kohaTable - acqui/basket.tt See bug 41324 comment 6 1. Variable serialization 3. "table_settings" variable Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191292|0 |1 is obsolete| | --- Comment #33 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192750&action=edit Bug 41563: Tidy kohaTable - acqui/basketgroup.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191293|0 |1 is obsolete| | --- Comment #34 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192751&action=edit Bug 41563: Tidy kohaTable - acqui/duplicate_orders.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191294|0 |1 is obsolete| | --- Comment #35 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192752&action=edit Bug 41563: Tidy kohaTable - acqui/histsearch.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191295|0 |1 is obsolete| | --- Comment #36 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192753&action=edit Bug 41563: Tidy kohaTable - acqui/invoice.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191296|0 |1 is obsolete| | --- Comment #37 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192754&action=edit Bug 41563: Tidy kohaTable - acqui/lateorders.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191297|0 |1 is obsolete| | --- Comment #38 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192755&action=edit Bug 41563: Tidy kohaTable - acqui/newordersuggestion.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191298|0 |1 is obsolete| | --- Comment #39 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192756&action=edit Bug 41563: Tidy kohaTable - acqui/orderreceive.tt See bug 41324 comment 6 1. Variable serialization 2. Use of permissions and sysprefs We also removed 'UniqueItemFields' from the controller. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191299|0 |1 is obsolete| | --- Comment #40 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192757&action=edit Bug 41563: Tidy kohaTable - acqui/parcel.tt See bug 41324 comment 6 1. Variable serialization 2. Use of permissions and sysprefs Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191300|0 |1 is obsolete| | --- Comment #41 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192758&action=edit Bug 41563: Tidy kohaTable - acqui/vendor_issues.tt See bug 41324 comment 6 1. Variable serialization Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191301|0 |1 is obsolete| | --- Comment #42 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192759&action=edit Bug 41563: acqui - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191302|0 |1 is obsolete| | --- Comment #43 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192760&action=edit Bug 41563: (follow-up) Fix two typos Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192730|0 |1 is obsolete| | --- Comment #44 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192761&action=edit Bug 41563: (follow-up) Tidy parcel.tt Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192731|0 |1 is obsolete| | --- Comment #45 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192762&action=edit Bug 41563: Remove JS error from newordersuggestion Not caused by this patchset but it's a good place to fix it (and not add a conflict) Uncaught TypeError: can't access property "DataTable", suggestionst is undefined Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41807 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41807 [Bug 41807] Fix automatic tab selection on basket groups page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #46 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 --- Comment #47 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192963&action=edit Bug 41563: (follow-up 2) Tidy parcel.tt Patch from commit 9ee2576 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords|additional_work_needed | --- Comment #48 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41848 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41848 [Bug 41848] Typo in parcel.tt prevents receiving -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42603 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42603 [Bug 42603] Cannot 'receive selected' because of typo in variable name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #49 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42702 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |david@davidnind.com Status|Needs documenting |RESOLVED --- Comment #50 from David Nind <david@davidnind.com> --- Relates to tidying the source files, so no changes required to the manual as far as I can tell. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org