https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 --- Comment #1 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 64255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64255&action=edit Bug 18795: DELETE (anonymize) checkout history Anonymize patron's checkout history via REST API DELETE /checkouts/history?borrowernumber=123 To test: 1. prove t/db_dependent/api/v1/checkoutshistory.t 2. Manually send DELETE request to /api/v1/checkouts/history?borrowernumber=123 where 123 is your patron's borrowernumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Web services |REST api QA Contact|testopia@bugs.koha-communit | |y.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa@koha-suomi.fi Assignee|koha-bugs@lists.koha-commun |johanna.raisa@koha-suomi.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 --- Comment #5 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 94548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94548&action=edit Bug 18795: (follow-up) Check whether patrons exists before deleting history Running $patrons->anonymise_issue_history after checking patrons exists is more logical even though $patrons->anonymise_issue_history() can handle 0 patrons returned in the search. Also this way we don't have to run anonymise_issue_history() code unless needed, thus making the code finish faster. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94548|0 |1 is obsolete| | --- Comment #7 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 94552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94552&action=edit Bug 18795: (follow-up) Check whether patrons exists before deleting history Running $patrons->anonymise_issue_history after checking patrons exists is more logical even though $patrons->anonymise_issue_history() can handle 0 patrons returned in the search. Also this way we don't have to run anonymise_issue_history() code unless needed, thus making the code finish faster. Signed-off-by: Johanna Raisa <johanna.raisa@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani@inlibro.com --- Comment #10 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Hi, Please rebase this patch. Bug 18795 - REST API: DELETE (anonymize) checkout history 94547 - Bug 18795: DELETE (anonymize) checkout history 94552 - Bug 18795: (follow-up) Check whether patrons exists before deleting history 94555 - Bug 18795: (follow-up) Unify error message to be same across codebase Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18795: DELETE (anonymize) checkout history Using index info to reconstruct a base tree... M Koha/REST/V1/Checkouts.pm M api/v1/swagger/paths.json Falling back to patching base and 3-way merge... Auto-merging api/v1/swagger/paths.json CONFLICT (content): Merge conflict in api/v1/swagger/paths.json Auto-merging Koha/REST/V1/Checkouts.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 18795: DELETE (anonymize) checkout history The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18795-DELETE-anonymize-checkout-history-G3iEhh.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94552|0 |1 is obsolete| | --- Comment #12 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 95247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95247&action=edit Bug 18795: (follow-up) Check whether patrons exists before deleting history Rebased patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 --- Comment #15 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 95266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95266&action=edit Bug 18795: (follow-up) Check whether patrons exists before deleting history Running $patrons->anonymise_issue_history after checking patrons exists is more logical even though $patrons->anonymise_issue_history() can handle 0 patrons returned in the search. Also this way we don't have to run anonymise_issue_history() code unless needed, thus making the code finish faster. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95248|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95265|0 |1 is obsolete| | --- Comment #17 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 95463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95463&action=edit Bug 18795: DELETE (anonymize) checkout history Anonymize patron's checkout history via REST API DELETE /checkouts/history?patron_id=123 To test: 1. prove t/db_dependent/api/v1/checkouts.t 2. Manually send DELETE request to /api/v1/checkouts/history?patron_id=123 where 123 is your patron's borrowernumber Sponsored-by: Koha-Suomi Oy Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95267|0 |1 is obsolete| | --- Comment #19 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 95465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95465&action=edit Bug 18795: (follow-up) Unify error message to be same across codebase In Koha/REST/V1/Patrons.pm the error message for not finding patron is "Patron not found" so let's use the same here. Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi Johanna. Nice and clean work! A few remarks from the QA POV: - Our API design mojo is: 'As RESTful as we can'. In this context, we should consider the 'checkout history of a patron' a resource, and as such it feels more appropriate to put the patron id on the path, like in: DELETE /patrons/{patron_id}/checkouts/history Then we can reserve this route you were using for batch anonymizing :-D like in DELETE /checkouts/history?q=more_complex_query_on_patrons - There are some response definitions missing on the spec, (503 for maintenance mode, 500 for internal server error, and so on). - Put the tests on a separate subtest please to avoid interference if some changes are made to the previous tests/data. -- You are receiving this mail because: You are watching all bug changes.