[Bug 27062] New: pickup_location tests don't deal correctly with existing libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Bug ID: 27062 Summary: pickup_location tests don't deal correctly with existing libraries Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 26984, 27002, 26963 If there are existing libraries in the DB, the tests will fail. There were several changes related to those tests recently, this bug report is a follow-up for them. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963 [Bug 26963] Improve Koha::Item::pickup_locations performance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984 [Bug 26984] Tests are failing if AnonymousPatron is configured https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27002 [Bug 27002] Make Koha::Biblio->pickup_locations return a Koha::Libraries resultset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25540 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Was failing a lot today https://jenkins.koha-community.org/job/Koha_Master_U18/954/consoleFull https://jenkins.koha-community.org/job/Koha_Master_U16/134/consoleFull https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/449/console... 08:38:45 koha_1 | # Failed test 'ReservesControlBranch: ItemHomeLibrary, biblio1, patron1 should return 27 but returns 18' 08:38:45 koha_1 | # at t/db_dependent/Koha/Biblio.t line 405. 08:38:45 koha_1 | 08:38:45 koha_1 | # Failed test 'ReservesControlBranch: PatronLibrary, biblio1, patron1 should return 27 but returns 18' 08:38:45 koha_1 | # at t/db_dependent/Koha/Biblio.t line 405. 08:38:45 koha_1 | # Looks like you failed 2 tests of 8. 08:38:45 koha_1 | 08:38:45 koha_1 | # Failed test 'pickup_locations' 08:38:45 koha_1 | # at t/db_dependent/Koha/Biblio.t line 422. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113868&action=edit Bug 27062: Fix pickup_location tests when existing libraries exist If there are existing libraries in the DB, the tests will fail. There were several changes related to those tests recently, this bug report is a follow-up for them. bug 26984, bug 27002 and bug 26963. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is not perfect, but I need the jenkins happy. Feel free to follow-up if you have a better fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Bug 27062 depends on bug 27002, which changed state. Bug 27002 Summary: Make Koha::Biblio->pickup_locations return a Koha::Libraries resultset https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27002 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Bug 27062 depends on bug 26984, which changed state. Bug 26984 Summary: Tests are failing if AnonymousPatron is configured https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Doesn't apply cleanly to 20.05, please rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- No need to backport I'd say. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |CLOSED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Andrew, actually all the 20.05 jobs are failing because of this. The patch applies correctly now, can you backport it and see if it fixes the failure? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org