http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5878 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-16 02:51:41 UTC --- Created attachment 3316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3316 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5878 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-19 17:27:15 UTC --- Tried testing this, here are my notes: 1) The default settings for items.content do not make much sense to me: -my $itemscontent = join( ',', qw( date_due title barcode author itemnumber ) ); +my $itemscontent = join( ',', qw( issuedate title barcode author biblionumber date_due) ); itemnumber is better than biblionumber, although both are only confusing for patrons. date_due makes sense. I would perhaps suggest: my $itemscontent = join( ',', qw( date_due title author callnumber barcode) ) 2) Running overdue_notices.pl creates a lot of output on command line: no query in themelanguage at /home/katrin/kohaclone/C4/Output.pm line 152. --- altcity: Alternative City altnotes: Alternative Contact Notes altphone: Alternative Phone altrelationship: Relationship of Alternative Contact altstreetaddress: ' Alternative Street Address' altsuburb: Alternative Suburb area: Area author: Author barcode: Barcode biblio.author: Author biblio.datecreated: Creation Date biblio.frameworkcode: Framework Code biblio.timestamp: Modification Date [...] 3) Using -html to create print notices with <item> syntax in overdue template creates a lot of error messages (additional to output above) ODUE: <item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Fine: <fine>EUR</fine></item> Error messages from overdue_notices.pl with patch applied: Use of uninitialized value in join or string at ./overdue_notices.pl line 502. Use of uninitialized value in join or string at ./overdue_notices.pl line 502. issuedatetitlebarcodeauthorbiblionumberdate_due at ./overdue_notices.pl line 503. Use of uninitialized value in concatenation (.) or string at ./overdue_notices.pl line 504. Use of uninitialized value in concatenation (.) or string at ./overdue_notices.pl line 504. ;Title;Barcode;Author;Biblio Number (koha internal);; at ./overdue_notices.pl line 504. Use of uninitialized value $fine in string at ./overdue_notices.pl line 706. Use of uninitialized value $fine in string at ./overdue_notices.pl line 706. Error messages from master branch in comparison: Use of uninitialized value $fine in string at ./overdue_notices.pl line 671. Use of uninitialized value $fine in string at ./overdue_notices.pl line 671. Wide character in print at ./overdue_notices.pl line 579. 4) -html with items.content in overdue notice template: With patch applied: [...] Use of uninitialized value in join or string at ./overdue_notices.pl line 502. Use of uninitialized value in join or string at ./overdue_notices.pl line 502. issuedatetitlebarcodeauthorbiblionumberdate_due at ./overdue_notices.pl line 503. Use of uninitialized value in concatenation (.) or string at ./overdue_notices.pl line 504. Use of uninitialized value in concatenation (.) or string at ./overdue_notices.pl line 504. ;Title;Barcode;Author;Biblio Number (koha internal);; at ./overdue_notices.pl line 504. On master: no output from overdue_notices.pl 5) In the created html file the headings for columns issue_date and date_due are missing. In general the created files and mails looked ok, but lot of error messages and additional created from running overdue_notices.pl. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5878 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kyle.m.hall@gmail.com |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5878 --- Comment #4 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-09 09:25:31 UTC --- This bug is mentioned in: Bug 5878 : overdue printing fixes and improvements http://lists.koha-community.org/pipermail/koha-patches/2011-March/014073.htm... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5878 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3316|0 |1 is obsolete| | --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-06-29 19:36:01 UTC --- Created attachment 4533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4533 rebased patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5878 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-06-29 20:39:31 UTC --- Created attachment 4535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4535 follow-up fixing perl warnings -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5878 --- Comment #10 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> 2011-07-08 12:09:38 UTC --- Created attachment 4601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4601 only removing some warn left Trivial patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5878 --- Comment #11 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> 2011-07-08 12:15:02 UTC --- Tested with each possible argument separatly 2 warn left in code were generating warning during execution. They were removed in the last follow-up patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5878 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-11 20:02:12 UTC --- Applied all 3 patches attached to this bug, going through the comments and tests I might on this earlier. 1) Still stands: -my $itemscontent = join( ',', qw( date_due title barcode author itemnumber ) ); +my $itemscontent = join( ',', qw( issuedate title barcode author biblionumber date_due) ); I think neither itemnumber nor biblionumber are of any help for patrons. Also having 2 dates can be confusing. I think we should keep the default as simple as possible. Still voting for: date_due title author callnumber barcode Something else: changing the default value might cause disappointment for installations using the curent default. 2) Is resolved. 3) <item> syntax in ODUE <item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Gebühr: <fine>EUR</fine></item> 3 a) Create overdues normally using overdue_notices.pl -t OK. 3 b) Create overdues as html notices using perl overdue_notices.pl -t -html ./ Erorrs output: Use of uninitialized value in join or string at overdue_notices.pl line 504. Use of uninitialized value in join or string at overdue_notices.pl line 504. HTML file looks ok, but errors should be dealt with. 4) <<items.content>> syntax in ODUE 4 a) Create overdues normally using overdue_notices.pl -t OK. 4 b) Create overdues as html notices using perl overdue_notices.pl -t -html ./ Use of uninitialized value in join or string at overdue_notices.pl line 504. Use of uninitialized value in join or string at overdue_notices.pl line 504. Errors should be fixed. HTML is created. Output overall ok, problems see 5) 5) HTML notices with <<items.content>> Some column headings are missing: Title Barcode Author Biblio Number (koha internal) 08/11/2011 Handbuch der Religionspädagogik. MPL11070003 7 08/09/2011 Missing are: issue_date, barcode, date_due. Another improvement I would suggest is that the headings should align right. We have no table borders and aligning them center makes the list hard to read. 6) wrong documentation for -html overdue_notices.pl -h give me following instructions: -html <filename> Output html to file Should be something like: -html <directory> Output notices as html files to directory -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5878 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5878 --- Comment #16 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-11 20:30:53 UTC --- Okay, as per my early statement and the outcomes of Katrin's testing, I'm going to ask that this patch be broken down into it's constituent features, each filed against its's own bug report, all of which will be linked to this one as bugs that this one "depends on". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5878 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P1 Version|rel_3_4 |rel_3_6 Patch Status|Failed QA |--- --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-31 14:55:42 UTC --- oups, this bug is a duplicate of 6030, please test the 6030 instead. Once 6030 has been applied a small part (for printoverdues.sh) will have to be rewritten -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.