http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5878 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-11 20:02:12 UTC --- Applied all 3 patches attached to this bug, going through the comments and tests I might on this earlier. 1) Still stands: -my $itemscontent = join( ',', qw( date_due title barcode author itemnumber ) ); +my $itemscontent = join( ',', qw( issuedate title barcode author biblionumber date_due) ); I think neither itemnumber nor biblionumber are of any help for patrons. Also having 2 dates can be confusing. I think we should keep the default as simple as possible. Still voting for: date_due title author callnumber barcode Something else: changing the default value might cause disappointment for installations using the curent default. 2) Is resolved. 3) <item> syntax in ODUE <item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Gebühr: <fine>EUR</fine></item> 3 a) Create overdues normally using overdue_notices.pl -t OK. 3 b) Create overdues as html notices using perl overdue_notices.pl -t -html ./ Erorrs output: Use of uninitialized value in join or string at overdue_notices.pl line 504. Use of uninitialized value in join or string at overdue_notices.pl line 504. HTML file looks ok, but errors should be dealt with. 4) <<items.content>> syntax in ODUE 4 a) Create overdues normally using overdue_notices.pl -t OK. 4 b) Create overdues as html notices using perl overdue_notices.pl -t -html ./ Use of uninitialized value in join or string at overdue_notices.pl line 504. Use of uninitialized value in join or string at overdue_notices.pl line 504. Errors should be fixed. HTML is created. Output overall ok, problems see 5) 5) HTML notices with <<items.content>> Some column headings are missing: Title Barcode Author Biblio Number (koha internal) 08/11/2011 Handbuch der Religionspädagogik. MPL11070003 7 08/09/2011 Missing are: issue_date, barcode, date_due. Another improvement I would suggest is that the headings should align right. We have no table borders and aligning them center makes the list hard to read. 6) wrong documentation for -html overdue_notices.pl -h give me following instructions: -html <filename> Output html to file Should be something like: -html <directory> Output notices as html files to directory -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.