[Bug 40067] New: "Receive shipments" opens in a new tab/window
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Bug ID: 40067 Summary: "Receive shipments" opens in a new tab/window Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 38010 On the vendor view: http://localhost:8081/cgi-bin/koha/acquisition/vendors/1 click "Receive shipments" in the toolbar http://localhost:8081//cgi-bin/koha/acqui/parcels.pl?booksellerid=1 is opened in a separate tab/window Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 [Bug 38010] Migrate vendors to Vue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |unspecified -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182934&action=edit Bug 40067: Prevent receive shipments opening in a new tab Test plan: 1) Navigate to a vendor record 2) Click the Receive shipments button 3) It will open in a new tab 4) Apply patch - yarn js:build 5) Hard refresh the browser 6) Repeat steps 1 - 2 7) The page will open in the same tab -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@openfifth.c | |o.uk Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182949&action=edit Bug 40067: Simplify code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182934|0 |1 is obsolete| | Attachment #182949|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182950&action=edit Bug 40067: Prevent receive shipments opening in a new tab Test plan: 1) Navigate to a vendor record 2) Click the Receive shipments button 3) It will open in a new tab 4) Apply patch - yarn js:build 5) Hard refresh the browser 6) Repeat steps 1 - 2 7) The page will open in the same tab Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182951&action=edit Bug 40067: Simplify code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- I think we need a test here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182972&action=edit Bug 40067: Add a cypress test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38899 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 [Bug 38899] Allow the Vue toolbar to be sticky -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Matt Blenkinsop from comment #6)
Created attachment 182972 [details] [review] Bug 40067: Add a cypress test
Have a look at bug 40051, we should not use cy.wait(delay). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182972|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182981&action=edit Bug 40067: Add a cypress test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182950|0 |1 is obsolete| | Attachment #182951|0 |1 is obsolete| | Attachment #182981|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183000&action=edit Bug 40067: Prevent receive shipments opening in a new tab Test plan: 1) Navigate to a vendor record 2) Click the Receive shipments button 3) It will open in a new tab 4) Apply patch - yarn js:build 5) Hard refresh the browser 6) Repeat steps 1 - 2 7) The page will open in the same tab Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183001&action=edit Bug 40067: Simplify code Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183002&action=edit Bug 40067: Add a cypress test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183003&action=edit Bug 40067: Improve waits and intercepts Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Receive shipments" opens |"Receive shipments" should |in a new tab/window |not open in a new | |tab/window -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the "Receive release notes| |shipments" action from a | |vendor page in acquisition | |- it now opens the receive | |shipment form in the same | |window, instead of opening | |in a new tab or window. --- Comment #15 from David Nind <david@davidnind.com> --- Noticed when writing the release note. It also opens in a new tab/window when you click "Receive shipments" in the actions column from the list of vendors: 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments". 3. Note that the receive shipment from vendor [name] page opens in a new tab/window. 4. Repeat step 1 5. In the actions column, click "Edit". 6. Note that the edit action edit vendor page opens in the same tab/window (that is, it doesn't open in a new tab/window like the "Receive shipments" action). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40318 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Nind from comment #15)
Noticed when writing the release note.
It also opens in a new tab/window when you click "Receive shipments" in the actions column from the list of vendors: 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments". 3. Note that the receive shipment from vendor [name] page opens in a new tab/window. 4. Repeat step 1 5. In the actions column, click "Edit". 6. Note that the edit action edit vendor page opens in the same tab/window (that is, it doesn't open in a new tab/window like the "Receive shipments" action).
Opened bug 40318. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 [Bug 40318] "Receive shipments" should not open in a new tab/window - vendor list view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #17 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Depends on Bug 38010, not backported to 24.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40430 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- The new test is failing, opening a new bug report. bug 40430. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 [Bug 40430] Toolbar_spec.ts is failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #19 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Nothing to change in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org