[Bug 38899] New: Allow the Vue toolbar to be sticky
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Bug ID: 38899 Summary: Allow the Vue toolbar to be sticky Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com We have sticky toolbars throughout Koha but this is not yet supported in Vue apps. The Toolbar component should have a sticky mode enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 [Bug 38010] Migrate vendors to Vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38010 Blocks|38010 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 [Bug 38010] Migrate vendors to Vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176545&action=edit Bug 38899: Add a sticky toolbar This patch adds a sticky toolbar to the vendors form Test plan: N.B: This patchset will not work on a sandbox 1) Navigate to Acquisitions and click New vendor 2) The toolbar should appear at the top of the page underneath Add vendor 3) Scroll down, the toolbar should stick and be given the 'floating' class 4) Scroll back up and the toolbar should unstick and lose the 'floating' class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176546&action=edit Bug 38899: Add a cypress test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |brendan@bywatersolutions.co | |m --- Comment #3 from Brendan Gallagher <brendan@bywatersolutions.com> --- error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorFormAdd.vue). error: could not build fake ancestor Could be my problem? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Needs a rebase! I'll pick that up when I get a chance -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- We need that for 25.05 IMO, it's a regression (on the vendor edit page). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176545|0 |1 is obsolete| | --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181822&action=edit Bug 38899: Add a sticky toolbar This patch adds a sticky toolbar to the vendors form Test plan: N.B: This patchset will not work on a sandbox 1) Navigate to Acquisitions and click New vendor 2) The toolbar should appear at the top of the page underneath Add vendor 3) Scroll down, the toolbar should stick and be given the 'floating' class 4) Scroll back up and the toolbar should unstick and lose the 'floating' class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176546|0 |1 is obsolete| | --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181823&action=edit Bug 38899: Add a cypress test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |no-sandbox CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- What is required to make this work so I can test it? At the moment, after applying bug 38010 and doing a yarn build, restart_all, and using a browser with the cache cleared, I get a 404 page not found when going to Acquisitions > +New vendor. It might be obvious if you are a Vue developer what is required, but not to me 8-). Testing notes so far (using KTD): 1. This bug is related to bug 38010 - migrating vendors in the acquisitions module to using Vue. 2. Before bug 38010, the toolbar when adding a vendor (Acquisitions > + New vendor) was sticky. 3. After bug 38010, the toolbar is no longer sticky, as there is no sticky component/code in the Koha Vue code - this bug adds that. (My understanding so far.) 4. Before applying any patches, go to add a vendor in the acquisitions module (Acquisitions > + New vendor). 5. Note that as you scroll down the page, a sticky menu appears. 6. Apply the patches (and dependencies) for bug 38010. 7. Rebuild things: yarn build 8. Restart everything: restart_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Hi David, there is an apache redirect that needs to be in place - a reset_all will do this for you -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #10 from David Nind <david@davidnind.com> --- (In reply to Matt Blenkinsop from comment #9)
Hi David, there is an apache redirect that needs to be in place - a reset_all will do this for you
Thanks Matt! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181822|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 181851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181851&action=edit Bug 38899: Add a sticky toolbar This patch adds a sticky toolbar to the vendors form Test plan: N.B: This patchset will not work on a sandbox 1) Navigate to Acquisitions and click New vendor 2) The toolbar should appear at the top of the page underneath Add vendor 3) Scroll down, the toolbar should stick and be given the 'floating' class 4) Scroll back up and the toolbar should unstick and lose the 'floating' class Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181823|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 181852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181852&action=edit Bug 38899: Add a cypress test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This restores the sticky release notes| |toolbar when adding a | |vendor in the acquisitions | |module (Acquisitions > + | |New vendor). This is | |related to bug 38010, which | |migrates vendors in the | |acquisitions module to | |using Vue - the sticky menu | |was not included in this. --- Comment #13 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. This bug is related to bug 38010 - migrating vendors in the acquisitions module to using Vue. 2. Before bug 38010, the toolbar when adding a vendor (Acquisitions > + New vendor) was sticky. 3. After bug 38010, the toolbar is no longer sticky, as there is no sticky component/code in the Koha Vue code - this bug adds that. 4. Before applying any patches, go to add a vendor in the acquisitions module (Acquisitions > + New vendor). 5. Note that as you scroll down the page, a sticky menu appears. 6. Apply the patches (and dependencies) for bug 38010. 7. Reset everything (required for an Apache redirect): reset_all 8. Go to add a vendor in the acquisitions module (Acquisitions > + New vendor). 7. Note that as you scroll down the page, the sticky menu in step 5 no longer appears. 8. Apply the patches for this bug (38899). 9. Rebuild things: yarn build 10. Restart everything: restart_all 11. Go to add a vendor in the acquisitions module (Acquisitions > + New vendor). 12. Note that the sticky toolbar is back! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #14 from David Nind <david@davidnind.com> --- 13. The tests should pass: yarn cypress run --spec t/cypress/integration/Toolbar_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.derscheid@lmscloud.de --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Is this just me being dumb? jquery-migrate-3.3.2.min_24.1200036.js:2 JQMIGRATE: Migrate is installed, version 3.3.2 flatpickr.min_24.1200036.js:2 TypeError: Cannot read properties of undefined (reading 'appendChild') at Object.onReady (shortcut-buttons-flatpickr.min_24.1200036.js:2:3024) at pe (flatpickr.min_24.1200036.js:2:34535) at flatpickr.min_24.1200036.js:2:48317 at E (flatpickr.min_24.1200036.js:2:48331) at k (flatpickr.min_24.1200036.js:2:48618) at jQuery.fn.jQuery.fn.flatpickr (flatpickr.min_24.1200036.js:2:49426) at apply_flatpickr (acqui-home.pl:1585:7166) at HTMLInputElement.<anonymous> (acqui-home.pl:1585:7823) at S.each (jquery-3.6.0.min_24.1200036.js:2:3003) at s.fn.init.each (jquery-3.6.0.min_24.1200036.js:2:1481) k @ flatpickr.min_24.1200036.js:2 jQuery.fn.jQuery.fn.flatpickr @ flatpickr.min_24.1200036.js:2 apply_flatpickr @ acqui-home.pl:1585 (anonymous) @ acqui-home.pl:1585 each @ jquery-3.6.0.min_24.1200036.js:2 each @ jquery-3.6.0.min_24.1200036.js:2 (anonymous) @ acqui-home.pl:1585 e @ jquery-3.6.0.min_24.1200036.js:2 t @ jquery-3.6.0.min_24.1200036.js:2 setTimeout (anonymous) @ jquery-3.6.0.min_24.1200036.js:2 c @ jquery-3.6.0.min_24.1200036.js:2 fireWith @ jquery-3.6.0.min_24.1200036.js:2 fire @ jquery-3.6.0.min_24.1200036.js:2 c @ jquery-3.6.0.min_24.1200036.js:2 fireWith @ jquery-3.6.0.min_24.1200036.js:2 ready @ jquery-3.6.0.min_24.1200036.js:2 B @ jquery-3.6.0.min_24.1200036.js:2 flatpickr.min_24.1200036.js:2 TypeError: Cannot read properties of undefined (reading 'appendChild') at Object.onReady (shortcut-buttons-flatpickr.min_24.1200036.js:2:3024) at pe (flatpickr.min_24.1200036.js:2:34535) at flatpickr.min_24.1200036.js:2:48317 at E (flatpickr.min_24.1200036.js:2:48331) at k (flatpickr.min_24.1200036.js:2:48618) at jQuery.fn.jQuery.fn.flatpickr (flatpickr.min_24.1200036.js:2:49426) at apply_flatpickr (acqui-home.pl:1585:7166) at HTMLInputElement.<anonymous> (acqui-home.pl:1585:7823) at S.each (jquery-3.6.0.min_24.1200036.js:2:3003) at s.fn.init.each (jquery-3.6.0.min_24.1200036.js:2:1481) k @ flatpickr.min_24.1200036.js:2 jQuery.fn.jQuery.fn.flatpickr @ flatpickr.min_24.1200036.js:2 apply_flatpickr @ acqui-home.pl:1585 (anonymous) @ acqui-home.pl:1585 each @ jquery-3.6.0.min_24.1200036.js:2 each @ jquery-3.6.0.min_24.1200036.js:2 (anonymous) @ acqui-home.pl:1585 e @ jquery-3.6.0.min_24.1200036.js:2 t @ jquery-3.6.0.min_24.1200036.js:2 setTimeout (anonymous) @ jquery-3.6.0.min_24.1200036.js:2 c @ jquery-3.6.0.min_24.1200036.js:2 fireWith @ jquery-3.6.0.min_24.1200036.js:2 fire @ jquery-3.6.0.min_24.1200036.js:2 c @ jquery-3.6.0.min_24.1200036.js:2 fireWith @ jquery-3.6.0.min_24.1200036.js:2 ready @ jquery-3.6.0.min_24.1200036.js:2 B @ jquery-3.6.0.min_24.1200036.js:2 AcquisitionsMenu.vue:309 [Vue warn]: injection "permissionsStore" not found. at <App ordermanage=1 orderreceive=1 edifact=0 ... > warn @ runtime-core.esm-bundler.js:38 inject @ runtime-core.esm-bundler.js:1646 setup @ AcquisitionsMenu.vue:309 callWithErrorHandling @ runtime-core.esm-bundler.js:155 setupStatefulComponent @ runtime-core.esm-bundler.js:7204 setupComponent @ runtime-core.esm-bundler.js:7159 mountComponent @ runtime-core.esm-bundler.js:5508 processComponent @ runtime-core.esm-bundler.js:5483 patch @ runtime-core.esm-bundler.js:5085 render @ runtime-core.esm-bundler.js:6244 render @ runtime-dom.esm-bundler.js:1548 _update @ runtime-dom.esm-bundler.js:591 resolve @ runtime-dom.esm-bundler.js:544 _resolveDef @ runtime-dom.esm-bundler.js:551 connectedCallback @ runtime-dom.esm-bundler.js:478 (anonymous) @ islands.ts:110 step @ index.mjs:34 (anonymous) @ index.mjs:34 asyncGeneratorStep @ index.mjs:34 _next @ index.mjs:34 Promise.then asyncGeneratorStep @ index.mjs:34 _next @ index.mjs:34 (anonymous) @ index.mjs:34 (anonymous) @ index.mjs:34 (anonymous) @ islands.ts:103 (anonymous) @ islands.ts:103 step @ index.mjs:34 (anonymous) @ index.mjs:34 asyncGeneratorStep @ index.mjs:34 _next @ index.mjs:34 (anonymous) @ index.mjs:34 (anonymous) @ index.mjs:34 requestIdleCallback hydrate @ islands.ts:87 (anonymous) @ acqui-home.pl:1187 islands.ts:110 [Vue warn]: Unhandled error during execution of setup function at <App ordermanage=1 orderreceive=1 edifact=0 ... > warn @ runtime-core.esm-bundler.js:38 logError @ runtime-core.esm-bundler.js:212 handleError @ runtime-core.esm-bundler.js:204 callWithErrorHandling @ runtime-core.esm-bundler.js:158 setupStatefulComponent @ runtime-core.esm-bundler.js:7204 setupComponent @ runtime-core.esm-bundler.js:7159 mountComponent @ runtime-core.esm-bundler.js:5508 processComponent @ runtime-core.esm-bundler.js:5483 patch @ runtime-core.esm-bundler.js:5085 render @ runtime-core.esm-bundler.js:6244 render @ runtime-dom.esm-bundler.js:1548 _update @ runtime-dom.esm-bundler.js:591 resolve @ runtime-dom.esm-bundler.js:544 _resolveDef @ runtime-dom.esm-bundler.js:551 connectedCallback @ runtime-dom.esm-bundler.js:478 (anonymous) @ islands.ts:110 step @ index.mjs:34 (anonymous) @ index.mjs:34 asyncGeneratorStep @ index.mjs:34 _next @ index.mjs:34 Promise.then asyncGeneratorStep @ index.mjs:34 _next @ index.mjs:34 (anonymous) @ index.mjs:34 (anonymous) @ index.mjs:34 (anonymous) @ islands.ts:103 (anonymous) @ islands.ts:103 step @ index.mjs:34 (anonymous) @ index.mjs:34 asyncGeneratorStep @ index.mjs:34 _next @ index.mjs:34 (anonymous) @ index.mjs:34 (anonymous) @ index.mjs:34 requestIdleCallback hydrate @ islands.ts:87 (anonymous) @ acqui-home.pl:1187 runtime-core.esm-bundler.js:218 Uncaught TypeError: Cannot destructure property 'isUserPermitted' of 'permissionsStore' as it is undefined. at setup (AcquisitionsMenu.vue:310:17) at callWithErrorHandling (runtime-core.esm-bundler.js:155:1) at setupStatefulComponent (runtime-core.esm-bundler.js:7204:1) at setupComponent (runtime-core.esm-bundler.js:7159:1) at mountComponent (runtime-core.esm-bundler.js:5508:1) at processComponent (runtime-core.esm-bundler.js:5483:1) at patch (runtime-core.esm-bundler.js:5085:1) at Object.render (runtime-core.esm-bundler.js:6244:1) at render (runtime-dom.esm-bundler.js:1548:1) at HTMLElement._update (runtime-dom.esm-bundler.js:591:1) setup @ AcquisitionsMenu.vue:310 callWithErrorHandling @ runtime-core.esm-bundler.js:155 setupStatefulComponent @ runtime-core.esm-bundler.js:7204 setupComponent @ runtime-core.esm-bundler.js:7159 mountComponent @ runtime-core.esm-bundler.js:5508 processComponent @ runtime-core.esm-bundler.js:5483 patch @ runtime-core.esm-bundler.js:5085 render @ runtime-core.esm-bundler.js:6244 render @ runtime-dom.esm-bundler.js:1548 _update @ runtime-dom.esm-bundler.js:591 resolve @ runtime-dom.esm-bundler.js:544 _resolveDef @ runtime-dom.esm-bundler.js:551 connectedCallback @ runtime-dom.esm-bundler.js:478 (anonymous) @ islands.ts:110 step @ index.mjs:34 (anonymous) @ index.mjs:34 asyncGeneratorStep @ index.mjs:34 _next @ index.mjs:34 Promise.then asyncGeneratorStep @ index.mjs:34 _next @ index.mjs:34 (anonymous) @ index.mjs:34 (anonymous) @ index.mjs:34 (anonymous) @ islands.ts:103 (anonymous) @ islands.ts:103 step @ index.mjs:34 (anonymous) @ index.mjs:34 asyncGeneratorStep @ index.mjs:34 _next @ index.mjs:34 (anonymous) @ index.mjs:34 (anonymous) @ index.mjs:34 requestIdleCallback hydrate @ islands.ts:87 (anonymous) @ acqui-home.pl:1187 And also: Sticky toolbar 1) Should stick on scroll 0 passing (3s) 1 failing 1) Sticky toolbar Should stick on scroll: TypeError: The following error originated from your application code, not from Cypress.
Cannot destructure property 'isUserPermitted' of 'permissionsStore' as it is undefined.
When Cypress detects uncaught errors originating from your application it will automatically fail the current test. This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event. https://on.cypress.io/uncaught-exception-from-application at setup (http://localhost:8081/intranet-tmpl/prog/js/vue/dist/acquisitions-menu.09f78...) at callWithErrorHandling (http://localhost:8081/intranet-tmpl/prog/js/vue/dist/islands.esm_24.1200036....) at setupStatefulComponent (http://localhost:8081/intranet-tmpl/prog/js/vue/dist/islands.esm_24.1200036....) at setupComponent (http://localhost:8081/intranet-tmpl/prog/js/vue/dist/islands.esm_24.1200036....) at mountComponent (http://localhost:8081/intranet-tmpl/prog/js/vue/dist/islands.esm_24.1200036....) at processComponent (http://localhost:8081/intranet-tmpl/prog/js/vue/dist/islands.esm_24.1200036....) at patch (http://localhost:8081/intranet-tmpl/prog/js/vue/dist/islands.esm_24.1200036....) at Object.render (http://localhost:8081/intranet-tmpl/prog/js/vue/dist/islands.esm_24.1200036....) at render (http://localhost:8081/intranet-tmpl/prog/js/vue/dist/islands.esm_24.1200036....) at HTMLElement._update (http://localhost:8081/intranet-tmpl/prog/js/vue/dist/islands.esm_24.1200036....) I am unsure whether I applied something wrong, or whether this is a real failure? Setting this to FQA, please reset to 'Signed off' if I made a mistake somewhere: - Applied this bug and all dependencies onto current upstream/main - reset_all as suggested - yarn build - restart_all - Manually tested stickyness (which works and is not the reason for FQA) - Saw the above mentioned errors + warnings in the console acqui-home.pl - Ran the cypress spec, ran into above failure -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- It works for me, however can we make it match the patron toolbar? https://snipboard.io/VBxNCj.jpg vs https://snipboard.io/v2JSHZ.jpg 1. Missing "save" icon 2. Cancel misaligned and not green (appears grey) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|no-sandbox | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181965&action=edit Bug 38899: (QA follow-up) Match buttons to patron toolbar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Looks good, works good. Do we need to tidy vue and ts files? FAIL koha-tmpl/intranet-tmpl/prog/js/vue/components/ButtonSubmit.vue FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/js/vue/components/ButtonSubmit.vue` FAIL koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181965|0 |1 is obsolete| | --- Comment #19 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182151&action=edit Bug 38899: (QA follow-up) Match buttons to patron toolbar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #20 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Tidied and squashed to last commit - not sure why the pre-commit hook tidy didn't catch those but QA tests are passing now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Still noticing a tiny difference between the 2 versions of the toolbar (comparing vendor edit and patron edit): I think it's coming from the use of <font-awesome-icon> vs <i>. Actually the Vue version is better (the vertical alignment) now IMO :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- There is something wrong. Cypress tests are now failing, because you renamed #vendor_add with #add_vendor. But renaming in the test is not enough, as I think it's not consistent: * the naming is not "add_vendor" vs "vendors_list", etc. * the block on which the id is is not consistent: main #vendors_list #toolbar .page-section the content vs main h1 #add_vendor #toolbar the content -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182249&action=edit Bug 38899: Fix cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182250&action=edit Bug 38899: Move the toolbar out of the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Well, the tests are still failing. AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Submit' within the element: <form#add_vendor> but never did. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #26 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182255&action=edit Bug 38899: Improve HTML consistency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Matt Blenkinsop from comment #26)
Created attachment 182255 [details] [review] Bug 38899: Improve HTML consistency
No, this is wrong. We now have 2 "main". I think we should have: main #vendors_add #toolbar .page-section form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182449&action=edit Bug 38899: Remove code duplication -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Where are we at here? I think this is still needed for 25.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #30 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182580&action=edit Bug 38899: Restore id attribute to the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #31 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- This is the closest I can get with the stickyness still working - if I replace the template tag with a div, the toolbar just scrolls up with the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I'm still seeing failing cypress tests for this I'm afraid. Vendors in particular. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182249|0 |1 is obsolete| | --- Comment #33 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182646&action=edit Bug 38899: Fix cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Let's aim for this one early next cycle? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #35 from David Nind <david@davidnind.com> --- I've changed this from an enhancement to a normal bug. While it is an enhancement to Vue, it restores something that existed before, for vendors in the acquisitions module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40067 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 [Bug 40067] "Receive shipments" opens in a new tab/window -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181851|0 |1 is obsolete| | --- Comment #36 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182973&action=edit Bug 38899: Add a sticky toolbar This patch adds a sticky toolbar to the vendors form Test plan: N.B: This patchset will not work on a sandbox 1) Navigate to Acquisitions and click New vendor 2) The toolbar should appear at the top of the page underneath Add vendor 3) Scroll down, the toolbar should stick and be given the 'floating' class 4) Scroll back up and the toolbar should unstick and lose the 'floating' class Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181852|0 |1 is obsolete| | --- Comment #37 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182974&action=edit Bug 38899: Add a cypress test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182151|0 |1 is obsolete| | --- Comment #38 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182975&action=edit Bug 38899: (QA follow-up) Match buttons to patron toolbar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182250|0 |1 is obsolete| | --- Comment #39 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182976&action=edit Bug 38899: Move the toolbar out of the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182255|0 |1 is obsolete| | --- Comment #40 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182977&action=edit Bug 38899: Improve HTML consistency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182449|0 |1 is obsolete| | --- Comment #41 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182978&action=edit Bug 38899: Remove code duplication -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182580|0 |1 is obsolete| | --- Comment #42 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182979&action=edit Bug 38899: Restore id attribute to the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182646|0 |1 is obsolete| | --- Comment #43 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182980&action=edit Bug 38899: Fix cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182973|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183114&action=edit Bug 38899: Add a sticky toolbar This patch adds a sticky toolbar to the vendors form Test plan: N.B: This patchset will not work on a sandbox 1) Navigate to Acquisitions and click New vendor 2) The toolbar should appear at the top of the page underneath Add vendor 3) Scroll down, the toolbar should stick and be given the 'floating' class 4) Scroll back up and the toolbar should unstick and lose the 'floating' class Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182974|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183115&action=edit Bug 38899: Add a cypress test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182975|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183116&action=edit Bug 38899: (QA follow-up) Match buttons to patron toolbar Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182976|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183117&action=edit Bug 38899: Move the toolbar out of the form Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182977|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183118&action=edit Bug 38899: Improve HTML consistency Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182978|0 |1 is obsolete| | --- Comment #49 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183119&action=edit Bug 38899: Remove code duplication Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182979|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183120&action=edit Bug 38899: Restore id attribute to the form Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182980|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183121&action=edit Bug 38899: Fix cypress tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #52 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #53 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #54 from Jonathan Druart <jonathan.druart@gmail.com> --- @ koha-tmpl/intranet-tmpl/prog/js/vue/components/ButtonSubmit.vue:4 @ <template> - <button type="submit" class="btn btn-primary"> + <button v-if="form" @click="form.requestSubmit()" class="btn btn-primary"> + <font-awesome-icon v-if="icon" :icon="icon" /> + {{ text }} + </button> This makes some Cypress tests fail. 18:46:27 koha_1 | <failure message="Timed out retrying after 10000ms: Expected to find element: `#report_builder .default-report .action input`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find element: `#report_builder .default-report .action input`, but never found it. 18:46:27 koha_1 | at Context.eval (webpack://koha/./t/cypress/integration/ERM/UsageReports_spec.ts:108:11)]]></failure> 18:43:25 koha_1 | <testcase name="Data provider tab options Should allow manual file upload" time="0.000" classname="Should allow manual file upload"> 18:43:25 koha_1 | <failure message="Timed out retrying after 10000ms: Expected to find element: `#files > form > fieldset > input[type=submit]`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find element: `#files > form > fieldset > input[type=submit]`, but never found it. 18:43:25 koha_1 | at Context.eval (webpack://koha/./t/cypress/integration/ERM/DataProviders_spec.ts:639:11)]]></failure> Patch incoming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #55 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183823&action=edit Bug 38899: Fix Cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 --- Comment #56 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #57 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38010 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 Bug 38899 depends on bug 40067, which changed state. Bug 40067 Summary: "Receive shipments" should not open in a new tab/window https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org