http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: it's a tiny patch, but on OPAC, it's written "login" on opac-user.pl too, so it's inconsistent to fix it here. Marking failed QA. (As it's string freeze for 3.10 today, this patch won't be in 3.10 even if a fix is provided soon) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- I'm running through the Failed QA's trying to see if there is anything I can rescue. I don't understand why this failed QA though. Did the 'Click here' say 'login' before? 'Log in' as an action link or button seems fine. The label for the text box, however, should be consistent. This patch believes it should be 'Username'. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26831&action=edit Bug 7867: Staff and OPAC login areas lack consistency This patch: - Changes the Staff client's login area text from "Username:" into "Login:", since login is more generic than username. - Adds a tool tip to the staff client's login area 'Login:' textbox: "Please enter your username or card number." - Adds a tool tip to the main OPAC screen's login area 'Login:' textbox using the bootstrap theme: "Please enter your username or card number." - Adds a tool tip to the main OPAC screen's login area 'Login:' textbox using the prog theme: "Please enter your username or card number." - Adds a tool tip to the OPAC screen triggered by clicking the 'Log in to your account' link in the top right using the bootstrap theme: "Please enter your username or card number." - Adds a tool tip to the OPAC screen triggered by clicking the 'Log in to your account' link in the top right using the bootstrap theme: "Please enter your username or card number." NOTE: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt was modified similarly as well, though I don't think it can be triggered, since the modal login screen of bootstrap is triggered by the 'Log in to your account' link, and it no longer goes to page it did before. The page still exists by going there by pasting in the known URL. TEST PLAN --------- 1) Go to staff client. 2) Log in and change the OPAC system preference opacthemes to 'bootstrap'. 3) Logout. 4) Go to OPAC in a different tab. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 5) Click the 'Log in to your account' link in the top right. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 6) Go to http://YOUROPAC/cgi-bin/koha/opac-user.pl -- notice staff client's "Username:" differs from the OPAC's "Login" text. 7) Log in to the staff client and change the OPAC system preference opacthemes to 'prog'. 8) Logout 9) In the OPAC tab, reload the page. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 10) Click the icon in the top left to return to the main Koha screen. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 11) Apply the patch 12) Repeat steps 1-10 again. -- The textbox associated with the login should have a tooltip: "Please enter your username or card number." 13) Run the koha qa test tool. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- I have attached a 3rd patch, which is a counter patch to the first two patches. That is, they change the Staff client to 'Login' and add an explanatory tooltip to the text boxes where you are expected to enter either a username or card number. Based on Katrin Fischer's comment 6, I think my counter patch would acceptable. I do agree that login is more generic than username. If the latter one is acceptable for QA purposes, please obsolete the first two (the one I signed off [2.17KB] and the one I added for bootstrap [2.08KB]). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 28137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28137&action=edit [Signed-off] Bug 7867: Staff and OPAC login areas lack consistency This patch: - Changes the Staff client's login area text from "Username:" into "Login:", since login is more generic than username. - Adds a tool tip to the staff client's login area 'Login:' textbox: "Please enter your username or card number." - Adds a tool tip to the main OPAC screen's login area 'Login:' textbox using the bootstrap theme: "Please enter your username or card number." - Adds a tool tip to the main OPAC screen's login area 'Login:' textbox using the prog theme: "Please enter your username or card number." - Adds a tool tip to the OPAC screen triggered by clicking the 'Log in to your account' link in the top right using the bootstrap theme: "Please enter your username or card number." - Adds a tool tip to the OPAC screen triggered by clicking the 'Log in to your account' link in the top right using the bootstrap theme: "Please enter your username or card number." NOTE: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt was modified similarly as well, though I don't think it can be triggered, since the modal login screen of bootstrap is triggered by the 'Log in to your account' link, and it no longer goes to page it did before. The page still exists by going there by pasting in the known URL. TEST PLAN --------- 1) Go to staff client. 2) Log in and change the OPAC system preference opacthemes to 'bootstrap'. 3) Logout. 4) Go to OPAC in a different tab. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 5) Click the 'Log in to your account' link in the top right. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 6) Go to http://YOUROPAC/cgi-bin/koha/opac-user.pl -- notice staff client's "Username:" differs from the OPAC's "Login" text. 7) Log in to the staff client and change the OPAC system preference opacthemes to 'prog'. 8) Logout 9) In the OPAC tab, reload the page. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 10) Click the icon in the top left to return to the main Koha screen. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 11) Apply the patch 12) Repeat steps 1-10 again. -- The textbox associated with the login should have a tooltip: "Please enter your username or card number." 13) Run the koha qa test tool. Followed test plan (without qa test tool). Login screens display as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26828|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|adrien.saurat@biblibre.com |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Adrien is no longer working on Koha - mayabe switch back to unassigned then. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 28282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28282&action=edit Bug 7867 - Further tweaks on error messages related to login As per Jonathan Druart's comments, self-checkout and error messages related to logging in were tweaked. TEST PLAN ---------- 1) Purposefully fail to log in properly with staff client. -- it should say username. 2) Purposefully fail to log in properly with opac. -- it should say username. 3) Re-run 2 with for both prog and bootstrap themes. 4) Purposefully fail to log in properly with self-checkout. -- you should be prompted username and error should say username as well. 6) apply patch. 7) Re-run the steps, but this time messages should be related to login and not username. 8) run koha-qa test tools. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28282|0 |1 is obsolete| | --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 28301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28301&action=edit [SIGNED-OFF] Bug 7867 - Further tweaks on error messages related to login As per Jonathan Druart's comments, self-checkout and error messages related to logging in were tweaked. TEST PLAN ---------- 1) Purposefully fail to log in properly with staff client. -- it should say username. 2) Purposefully fail to log in properly with opac. -- it should say username. 3) Re-run 2 with for both prog and bootstrap themes. 4) Purposefully fail to log in properly with self-checkout. -- you should be prompted username and error should say username as well. 6) apply patch. 7) Re-run the steps, but this time messages should be related to login and not username. 8) run koha-qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No errors. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28349&action=edit Bug 7867: Staff and OPAC login areas lack consistency This patch: - Changes the Staff client's login area text from "Username:" into "Login:", since login is more generic than username. - Adds a tool tip to the staff client's login area 'Login:' textbox: "Please enter your username or card number." - Adds a tool tip to the main OPAC screen's login area 'Login:' textbox using the bootstrap theme: "Please enter your username or card number." - Adds a tool tip to the main OPAC screen's login area 'Login:' textbox using the prog theme: "Please enter your username or card number." - Adds a tool tip to the OPAC screen triggered by clicking the 'Log in to your account' link in the top right using the bootstrap theme: "Please enter your username or card number." - Adds a tool tip to the OPAC screen triggered by clicking the 'Log in to your account' link in the top right using the bootstrap theme: "Please enter your username or card number." NOTE: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt was modified similarly as well, though I don't think it can be triggered, since the modal login screen of bootstrap is triggered by the 'Log in to your account' link, and it no longer goes to page it did before. The page still exists by going there by pasting in the known URL. TEST PLAN --------- 1) Go to staff client. 2) Log in and change the OPAC system preference opacthemes to 'bootstrap'. 3) Logout. 4) Go to OPAC in a different tab. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 5) Click the 'Log in to your account' link in the top right. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 6) Go to http://YOUROPAC/cgi-bin/koha/opac-user.pl -- notice staff client's "Username:" differs from the OPAC's "Login" text. 7) Log in to the staff client and change the OPAC system preference opacthemes to 'prog'. 8) Logout 9) In the OPAC tab, reload the page. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 10) Click the icon in the top left to return to the main Koha screen. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 11) Apply the patch 12) Repeat steps 1-10 again. -- The textbox associated with the login should have a tooltip: "Please enter your username or card number." 13) Run the koha qa test tool. Followed test plan (without qa test tool). Login screens display as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28137|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Looks good to me. Maybe a native speaker should pass QA on it? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28349|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28457&action=edit [PASSED QA] Bug 7867: Staff and OPAC login areas lack consistency This patch: - Changes the Staff client's login area text from "Username:" into "Login:", since login is more generic than username. - Adds a tool tip to the staff client's login area 'Login:' textbox: "Please enter your username or card number." - Adds a tool tip to the main OPAC screen's login area 'Login:' textbox using the bootstrap theme: "Please enter your username or card number." - Adds a tool tip to the main OPAC screen's login area 'Login:' textbox using the prog theme: "Please enter your username or card number." - Adds a tool tip to the OPAC screen triggered by clicking the 'Log in to your account' link in the top right using the bootstrap theme: "Please enter your username or card number." - Adds a tool tip to the OPAC screen triggered by clicking the 'Log in to your account' link in the top right using the bootstrap theme: "Please enter your username or card number." NOTE: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt was modified similarly as well, though I don't think it can be triggered, since the modal login screen of bootstrap is triggered by the 'Log in to your account' link, and it no longer goes to page it did before. The page still exists by going there by pasting in the known URL. TEST PLAN --------- 1) Go to staff client. 2) Log in and change the OPAC system preference opacthemes to 'bootstrap'. 3) Logout. 4) Go to OPAC in a different tab. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 5) Click the 'Log in to your account' link in the top right. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 6) Go to http://YOUROPAC/cgi-bin/koha/opac-user.pl -- notice staff client's "Username:" differs from the OPAC's "Login" text. 7) Log in to the staff client and change the OPAC system preference opacthemes to 'prog'. 8) Logout 9) In the OPAC tab, reload the page. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 10) Click the icon in the top left to return to the main Koha screen. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 11) Apply the patch 12) Repeat steps 1-10 again. -- The textbox associated with the login should have a tooltip: "Please enter your username or card number." 13) Run the koha qa test tool. Followed test plan (without qa test tool). Login screens display as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28350|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28458&action=edit [PASSED QA] Bug 7867 - Further tweaks on error messages related to login As per Jonathan Druart's comments, self-checkout and error messages related to logging in were tweaked. TEST PLAN ---------- 1) Purposefully fail to log in properly with staff client. -- it should say username. 2) Purposefully fail to log in properly with opac. -- it should say username. 3) Re-run 2 with for both prog and bootstrap themes. 4) Purposefully fail to log in properly with self-checkout. -- you should be prompted username and error should say username as well. 6) apply patch. 7) Re-run the steps, but this time messages should be related to login and not username. 8) run koha-qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #22 from Galen Charlton <gmcharlt@gmail.com> --- I have a translation question: the word "login" is ambiguous in English. It can be a verb (to log in), or a noun referring to a username or user ID. Are there languages that use two distinct words for those concepts? If so, that would be a reason for running with "Username or cardnumber" or the like. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Well, at least n this case :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 --- Comment #26 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to M. Tompsett from comment #25)

(In reply to Kyle M Hall from comment #21)

...

In summary, I find this acceptable, but I think that literally having "Username or card number" would be the best solution. However, "Login" is much more terse and I think that by and large it will not cause confusion for patrons.

This is why you will note I added the following: title="Please enter your username or card number." into the code. A hover over should clarify what is expected.

Remember that translators will be seeing lists of words and phrases. So if one sees the word "Login" in the translation interface... quick, tell me whether it's the noun or verb form! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 --- Comment #28 from M. Tompsett <mtompset@hotmail.com> --- I was thinking the other day about logging in. Log in Log on Sign in Sign on We have lost the space which distinguishes the "Login" (noun) from "Log in" (action/verb). This loss of the space is more apparent when we talk about logging in (verb) using your login (noun). What we have here is the mess of language. :( What is the best way to solve this case? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@pttk.fi --- Comment #30 from paxed <pasi.kallinen@pttk.fi> --- If only we supported the message context strings (msgctxt) ... -- You are receiving this mail because: You are watching all bug changes.