[Bug 24490] New: Clarify wording and function of Purchase Items link on POS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Bug ID: 24490 Summary: Clarify wording and function of Purchase Items link on POS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org On cgi-bin/koha/pos/pay.pl, we're given a link with text "Purchase items" that goes to /cgi-bin/koha/admin/debit_types.pl. "Purchase items" sounds like one would click the link to purchase things, when really one clicks the link to define items that can be purchased. "Purchasable items" or "Items for purchase" would be more clear. Alternately, the debit types interface uses the wording "Can be sold" so we could try to match that, but "Items that can be sold" is awkward. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24477 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Depends on| |23354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om CC| |david.roberts@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 --- Comment #1 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 97872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97872&action=edit Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure Cash Registers" and "Configure Items for Purchase" 3) Click both links to ensure you are taken to the relevant config pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from David Roberts <david.roberts@ptfs-europe.com> --- I decided to change the wording on both of the links on the POS page to "Configure Cash Registers" and "Configure Items for Sale". This makes it immediately clear what are the purpose of the two links. To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure Cash Registers" and "Configure Items for Purchase" 3) Click both links to ensure you are taken to the relevant config pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97872|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97879&action=edit Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure Cash Registers" and "Configure Items for Purchase" 3) Click both links to ensure you are taken to the relevant config pages. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Looks good, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry David, but the new text doesn't have the right capitalization. Only the first word of each link should be capitalized (see coding guidelines). Do you want to have a go at fixing this? Let me know if I can help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Btw - I like the new wording much better :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97879|0 |1 is obsolete| | --- Comment #7 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 97930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97930&action=edit Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure Cash Registers" and "Configure Items for Purchase" 3) Click both links to ensure you are taken to the relevant config pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from David Roberts <david.roberts@ptfs-europe.com> --- Hi Katrin OK, try that instead. Do I need to mark it back to Needs Signoff? I've done that anyway, just in case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97979&action=edit Bug 24339: Do not assume there are exactly 3 SIP* AVs Update DB entry 19.06.00.017: We created SIP* AV from accountlines if '^Pay[[:digit:]]{2}$', so I think we should assume that more than SIP00, SIP01, SIP02 can exist. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97979|0 |1 is obsolete| | --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Comment on attachment 97979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97979 Bug 24339: Do not assume there are exactly 3 SIP* AVs Sorry, didn't drink enough coffee before trying this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Patch didn't apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 --- Comment #12 from David Roberts <david.roberts@ptfs-europe.com> --- I'm confused - are these last three comments relevant to this bug, or have they been attached to the wrong bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Sorry, that's my fault! The new patch for this bug didn't apply, but I was very slow to realize it. I went to the POS screen, saw that the links were showing the correct capitalization, but didn't realize that was because they were reverting to the original wording. So then I tried to sign off. Because the actual patch hadn't applied, the sandbox just grabbed the most recent patch on there (which was from another bug) and signed it off here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 --- Comment #14 from David Roberts <david.roberts@ptfs-europe.com> --- OK thanks - no idea why the patch wouldn't apply. I'll rebase and try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97930|0 |1 is obsolete| | --- Comment #15 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 97985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97985&action=edit Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure cash registers" and "Configure items for purchase" 3) Click both links to ensure you are taken to the relevant config pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from David Roberts <david.roberts@ptfs-europe.com> --- Hopefully that is now OK - no idea what went wrong with the last one - the branch I worked on was in a total pickle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97985|0 |1 is obsolete| | --- Comment #17 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97992&action=edit Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure cash registers" and "Configure items for purchase" 3) Click both links to ensure you are taken to the relevant config pages. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Ok, actually signing off this time. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97992|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98358&action=edit Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure cash registers" and "Configure items for purchase" 3) Click both links to ensure you are taken to the relevant config pages. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #21 from Joy Nelson <joy@bywatersolutions.com> --- Does not apply to 19.11.x branch not backported -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org