[Bug 23533] New: Reindent patron entry form (memberentrygen.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Bug ID: 23533 Summary: Reindent patron entry form (memberentrygen.tt) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org I would like to reindent members/memberentrygen.tt. Correct indentation, replace tabs with spaces, and add some comments to clarify the structure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 [Bug 23534] Use patron-title.inc on patron entry page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92581&action=edit Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92582&action=edit Bug 23512: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 [Bug 23536] Use use a template block to output patron categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92581|0 |1 is obsolete| | --- Comment #3 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 92660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92660&action=edit Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92582|0 |1 is obsolete| | --- Comment #4 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 92661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92661&action=edit Bug 23512: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. https://bugs.koha-community.org/show_bug.cgi?id=23533 Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92660|0 |1 is obsolete| | Attachment #92661|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92913&action=edit Bug 23533: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #6 from Jesse Maseto <jesse@bywatersolutions.com> --- Patch did not apply. Merge conflicts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Séverine Queune <severine.queune@bulac.fr> --- fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt). error: could not build fake ancestor Patch failed at 0001 Bug 23533: (follow-up) Add markup comments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92913|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96170&action=edit Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96171&action=edit Bug 23512: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96171|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96172&action=edit Bug 23533: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96170|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 98189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98189&action=edit Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96172|0 |1 is obsolete| | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 98190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98190&action=edit Bug 23533: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. https://bugs.koha-community.org/show_bug.cgi?id=23533 Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98189|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98359&action=edit Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98190|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98360&action=edit Bug 23533: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. https://bugs.koha-community.org/show_bug.cgi?id=23533 Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- t/db_dependent/selenium/patrons_search.t is failing because of this change: # got: 'Koha › Patrons › Modify patron <strong>fir's"tname</strong> \123 ❤ test_patron_1 ( iOVAoJj )' # expected: 'Koha › Patrons › Modify patron <strong>fir's"tname</strong> \123 ❤ test_patron_1 (iOVAoJj)' We are adding space after and before the open/close parenthesis of the category code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98409&action=edit Bug 23533: Remove spaces after/before the open/close parenthesis t/db_dependent/selenium/patrons_search.t is failing because of this change: # got: 'Koha › Patrons › Modify patron <strong>fir's"tname</strong> \123 ❤ test_patron_1 ( iOVAoJj )' # expected: 'Koha › Patrons › Modify patron <strong>fir's"tname</strong> \123 ❤ test_patron_1 (iOVAoJj)' We are adding space after and before the open/close parenthesis of the category code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Followup pushed, thanks Jonathan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |joy@bywatersolutions.com --- Comment #19 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org