[Bug 10798] New: OPAC_SEARCH_LIMIT behaves badly with search groups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Bug ID: 10798 Summary: OPAC_SEARCH_LIMIT behaves badly with search groups Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The code implementing multiple PAC's by URL support as in the RFC here at http://wiki.koha-community.org/wiki/Support_for_multiple_PAC_interfaces_by_U... has been implimented for some time. However, when the 'search by groups' feature was implemented, the above code was not taken into account, and as such if you wish to limit a search by a group as a posed to just a branch, you met with strange behaviour should you also enable the SearchMyLibraryFirst system preference. Testplan to show Failure 1. Add a second PAC by adding an Alias to your Apache vhosts file (See below example) 2. Add a Search group to Koha using the staff client 3. Enable URL specific search limit (branch:search_group_code) to that same Apache vhosts file using a SetEnvIf (See below example) 4. Enable 'SearchMyLibraryFirst' system preference. 5. Create a user, and set that users branch. 6. Go to the 'normal' koha opac url and the search will not be limited 7. Go to the 'second' koha opac url and the search will be limited to your search group 8. Login on the 'normal' url and your search will be limited by your users branch 9. Login on the 'second' url and your search will be limited by your users branch Step 9 is the error, if OPAC_LIMIT_OVERRIDE is set to 1 in the SetEnvIf then this should NOT be your local library branch, but actually the limit set in the Apache conf VirtualHosts example additions ServerName opac.your-domain.com ServerAlias opac2.your-domain.com SetEnvIf Host "opac2.your-domain.com" OPAC_SEARCH_LIMIT=branch:search_group_code OPAC_LIMIT_OVERRIDE=1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Patch complexity|--- |Trivial patch Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 20708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20708&action=edit Bug 10798 - OPAC_SEARCH_LIMIT behaves badly with search groups -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20708|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 21739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21739&action=edit [SIGNED-OFF] Bug 10798 - OPAC_SEARCH_LIMIT behaves badly with search groups Since the addition of search groups to koha, the branch limiting parameter in multiple PAC by URL support should also support limiting by these search groups. This patch adds this ability. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com QA Contact|testopia@bugs.koha-communit |paul.poulain@biblibre.com |y.org | --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: trivial patch, but with tabs instead of spaces ! will pass it QA with a follow-up -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 22237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22237&action=edit Bug 10798 - OPAC_SEARCH_LIMIT behaves badly with search groups Since the addition of search groups to koha, the branch limiting parameter in multiple PAC by URL support should also support limiting by these search groups. This patch adds this ability. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21739|0 |1 is obsolete| | --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 22238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22238&action=edit Bug 10798 follow-up: replacing tabs by spaces Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Martin! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org