[Bug 11167] New: Remove memcached config from koha-conf-site.xml.in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 Bug ID: 11167 Summary: Remove memcached config from koha-conf-site.xml.in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: magnus@enger.priv.no Reporter: magnus@enger.priv.no QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Depends on: 10733, 6193 The file debian/templates/koha-conf-site.xml.in, which is used to generate koha-conf.xml files for packages installations, still contains a couple of lines for configuring memcached, even though this was moved to the Apache config files by bug 6193 (see specifically attachment 7630, which removes the relevant lines from /etc/koha-conf.xml). Here are the lines: <memcached_servers>__MEMCACHED_SERVERS__</memcached_servers> <memcached_namespace>__MEMCACHED_NAMESPACE__</memcached_namespace> Having them there causes no harm, but it might create some confusion over where memcached is actually configured. This can also be seen as a followup to bug 10733 (attachment 21618), which needlessly changes the lines mentioned above from: - <memcached_servers></memcached_servers> - <memcached_namespace></memcached_namespace> to: + <memcached_servers>__MEMCACHED_SERVERS__</memcached_servers> + <memcached_namespace>__MEMCACHED_NAMESPACE__</memcached_namespace> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 22576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22576&action=edit Bug 11167 - Remove memcached config from koha-conf-site.xml.in Memcached-configuration is now done with environment variables or SetEnv in the Apache configs. Having remnants of the now obsolete configuration in koha-conf.xml might cause confusion as to where memcached is actually configured. This patch removes the two lines related to memcached from koha-conf-site.xml.in To test, the hard way: - Apply the patch - Build packages - Install package - Create instances and enable memcached - Check that memcached is used, even without the settings in koha-conf.xml To test, the easy way: - On an installation running off the packages, verify that memcached is actually configured through environment variables/SetEnv in the Apache configs, and not through koha-conf.xml -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22576|0 |1 is obsolete| | --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 22614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22614&action=edit Bug 11167 - Remove memcached config from koha-conf-site.xml.in Memcached-configuration is now done with environment variables or SetEnv in the Apache configs. Having remnants of the now obsolete configuration in koha-conf.xml might cause confusion as to where memcached is actually configured. This patch removes the two lines related to memcached from koha-conf-site.xml.in To test, the hard way: - Apply the patch - Build packages - Install package - Create instances and enable memcached - Check that memcached is used, even without the settings in koha-conf.xml To test, the easy way: - On an installation running off the packages, verify that memcached is actually configured through environment variables/SetEnv in the Apache configs, and not through koha-conf.xml Signed-off-by: Robin Sheat <robin@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22614|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 22828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22828&action=edit Bug 11167 - Remove memcached config from koha-conf-site.xml.in Memcached-configuration is now done with environment variables or SetEnv in the Apache configs. Having remnants of the now obsolete configuration in koha-conf.xml might cause confusion as to where memcached is actually configured. This patch removes the two lines related to memcached from koha-conf-site.xml.in To test, the hard way: - Apply the patch - Build packages - Install package - Create instances and enable memcached - Check that memcached is used, even without the settings in koha-conf.xml To test, the easy way: - On an installation running off the packages, verify that memcached is actually configured through environment variables/SetEnv in the Apache configs, and not through koha-conf.xml Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 22829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22829&action=edit Bug 11167: QA-followup - C4::SQLHelper still used the koha-conf.xml entries There was still some use of the koha-conf.xml memcached_servers and memcached_namespace configuration in C4::SQLHelper. This followup removes that remaining bits. Regards To+ Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | Status|Passed QA |In Discussion CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- I'm punting this one to later and revisit bug 6193 -- nowadays, I don't think it was a good idea to put the memcached config in the Apache configuration: - passing environment variables to Plack is difficult - we don't need to cache koha-conf.xml quite like this in memcached, avoiding the chicken-and-egg problem that may ahve motivated 6193. Setting to in discussion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> --- (In reply to Galen Charlton from comment #5)
- passing environment variables to Plack is difficult
It's not really, I have the init script set to pull from a defaults file: $ cat /etc/default/koha-common-starman # Defaults file for starman-related environment variables # The location of the memcache server (currently only one can be provided.) MEMCACHED_SERVERS=127.0.0.1:11211 # The namespace under which memcache keys will be stored. # ${name} becomes the name of the instance. MEMCACHED_NAMESPACE="${name}_koha" # Koha debug options that you probably don't want to use unless you're trying # to figure out a problem. KOHA_BACKTRACE=1 DEBUG=1
- we don't need to cache koha-conf.xml quite like this in memcached, avoiding the chicken-and-egg problem that may ahve motivated 6193.
We don't so much for plack, we can keep it in a local variable, and a read every 20 requests or whatever is no big deal. But it seems it'd shave a reasonable bit of time off loading the CGI implementation. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org