[Bug 26548] New: [20.05] Update for 20.05.03.001 has wrong SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Bug ID: 26548 Summary: [20.05] Update for 20.05.03.001 has wrong SQL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com 22386 $DBversion = '20.05.03.001'; 22387 if( CheckVersion( $DBversion ) ) { 22388 $dbh->do(q{ 22389 INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES 22390 ('DefaultLongOverdueSkipLostStatuses', '', NULL, 'Skip these lost statuses by default in longoverdue.pl', 'Free'), 22391 }); 22392 22393 NewVersion( $DBversion, 25958, "Allow LongOverdue cron to exclude specified lost values"); 22394 } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The comma 'Free'), here should not be. See email to the mailing list: https://lists.katipo.co.nz/pipermail/koha/2020-September/055204.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |mtj@kohaaloha.com Severity|enhancement |critical Status|NEW |ASSIGNED Depends on| |25958 Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Lucas, can you fix this ASAP please? Then Mason, can you roll a v20.05.04-2 with this patch? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25958 [Bug 25958] Allow LongOverdue cron to exclude specified lost values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, I didn't notice I left this on enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 110876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110876&action=edit Bug 26548: Fix typo in updatedatabase Test plan: 1. On 20.05.x run updatedatbase and see an error 2. Apply patch 3. Re-run updatedatabase without an error https://bugs.koha-community.org/show_bug.cgi?id=25958 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- I had a go at testing, but updatedatabase didn't generate any error on 20.05.x for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I see the error when upgrading from 19.11 : DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 1 [for Statement " INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES ('DefaultLongOverdueSkipLostStatuses', '', NULL, 'Skip these lost statuses by default in longoverdue.pl', 'Free'), "] at ./src/installer/data/mysql/updatedatabase.pl line 22388. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #6)
I see the error when upgrading from 19.11 :
DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 1 [for Statement " INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES ('DefaultLongOverdueSkipLostStatuses', '', NULL, 'Skip these lost statuses by default in longoverdue.pl', 'Free'), "] at ./src/installer/data/mysql/updatedatabase.pl line 22388.
By changing in installer/data/mysql/updatedatabase.pl : - local $dbh->{RaiseError} = 0; + local $dbh->{RaiseError} = 1; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110876|0 |1 is obsolete| | --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 110887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110887&action=edit Bug 26548: Fix typo in updatedatabase Test plan: 1. On 20.05.x run updatedatbase and see an error 2. Apply patch 3. Re-run updatedatabase without an error https://bugs.koha-community.org/show_bug.cgi?id=25958 Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Commit in master in indeed OK : git show 385a4cba44c5ac56d334d5ac4f8acd69d17375e9 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Who signed the| |20.05.05 patch off| | Status|Pushed to master |Pushed to stable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |20.05 CC| |aleisha@catalyst.net.nz --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- not required in 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org