[Bug 26785] New: JS errors in pos/pay.tt in 20.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Bug ID: 26785 Summary: JS errors in pos/pay.tt in 20.05.x Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In 20.05 there is a JS error in pos/pay.tt. This error does not exist in master. TO recreate: 1. enable EnablePointOfSale 2. enable UseCashRegisters 3. Go to /cgi-bin/koha/pos/pay.pl 4. See the console error Not 100% sure but maybe this is fixed in master because of Bug 26234? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I think line 338 is a backporting error and that it doesn't belong: }, items_columns_settings, false); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Component|Tools |Fines and fees -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #1)
I think line 338 is a backporting error and that it doesn't belong:
}, items_columns_settings, false);
Ahh, indeed. From this commit I think: http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=koha-tmpl/intr... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 112273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112273&action=edit Bug 26785: Fix JS error in pos/pay.tt To Test: 1. enable EnablePointOfSale 2. enable UseCashRegisters 3. Go to /cgi-bin/koha/pos/pay.pl 4. See the console error 5. Apply patch 6. Add some debit types and make sure you can add them /cgi-bin/koha/pos/pay.pl 7. Check for console errors, there should be none 8. Make sure you can confrim payments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112273|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 112406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112406&action=edit Bug 26785: Fix JS error in pos/pay.tt To Test: 1. enable EnablePointOfSale 2. enable UseCashRegisters 3. Go to /cgi-bin/koha/pos/pay.pl 4. See the console error 5. Apply patch 6. Add some debit types and make sure you can add them /cgi-bin/koha/pos/pay.pl 7. Check for console errors, there should be none 8. Make sure you can confrim payments. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112406|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112436&action=edit Bug 26785: Fix JS error in pos/pay.tt To Test: 1. enable EnablePointOfSale 2. enable UseCashRegisters 3. Go to /cgi-bin/koha/pos/pay.pl 4. See the console error 5. Apply patch 6. Add some debit types and make sure you can add them /cgi-bin/koha/pos/pay.pl 7. Check for console errors, there should be none 8. Make sure you can confrim payments. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Pushed to master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sending to 20.05 RMaint queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.05 released in| | Status|Pushed to master |Pushed to stable Patch complexity|Trivial patch |String patch --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.05. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org