http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15646 Bug ID: 15646 Summary: koha qa test tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz It would be nice to append to the end of the perlcriticrc file for the koha qa test tools: [InputOutput::RequireCheckedSyscalls] functions = :builtins exclude_functions = print -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15646 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |mtompset@hotmail.com --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 47222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47222&action=edit Allow print function return value to be ignored. TEST PLAN --------- 1) link ~/.perlcriticrc to ~/qa-test-tools/perlcriticrc 2) save simple script --- BEGIN example.pl --- #!/usr/bin/perl use Modern::Perl; our $VERSION = q{1.0}; print "Hello World!\n"; --- END example.pl --- 3) perlcritic -1 example.pl Return value of flagged function ignored - print at line 5, column 1. See pages 208,278 of PBP. (Severity: 1) 4) Apply this patch to the qa test tools 5) redo step 3 example.pl source OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15646 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- % perlcritic -1 C4/Auth.pm | wc -l 531 Well, it seems that we are not ready at all for level 1... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org