[Bug 10455] New: remove duplicated/redundant bibltioitems.marc field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Bug ID: 10455 Summary: remove duplicated/redundant bibltioitems.marc field Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: mtj@kohaaloha.com in Koha, for each bib, we have identical MARC data stored in *two* different columns in the 'biblioitems' table (biblioitems.marcxml and biblioitems.marc) as far as i know, we only need to store this data in one field, not two this patch will attempt to remove code referencing the 'biblioitems.marc' field, and replace it with 'biblioitems.marcxml' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|remove duplicated/redundant |remove redundant |bibltioitems.marc field |'biblioitems.marc' field -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |magnus@enger.priv.no --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- The data might be the same, but the format is different, because biblioitems.marc is iso2709, right? I seem to remember someone saying that we should keep the iso2709 in biblioitems.marc, because if you want to export e.g. 500k records in iso2709 format, transforming all those records from marcxml on the fly would be *really* heavy. But I might be wrong... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@pttk.fi --- Comment #2 from paxed <pasi.kallinen@pttk.fi> --- (In reply to Magnus Enger from comment #1)
I seem to remember someone saying that we should keep the iso2709 in biblioitems.marc, because if you want to export e.g. 500k records in iso2709 format, transforming all those records from marcxml on the fly would be *really* heavy. But I might be wrong...
I'd think not having to take care of twice the data would weigh more than possibly having a hypothetical situation of exporting 500k iso2709 records... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Magnus Enger from comment #1)
I seem to remember someone saying that we should keep the iso2709 in biblioitems.marc, because if you want to export e.g. 500k records in iso2709 format, transforming all those records from marcxml on the fly would be *really* heavy. But I might be wrong...
Sure, if you want ISO2709 and are starting from MARCXML, converting to ISO2709 for an export will consume a bit more CPU than dumping pre-existing ISO2709 directly... but (a) the cost of conversion is not that much, (b) exports are relatively infrequent operations, (c) and as such, better to pay the cost during exports than to (admittedly slightly) slow down the operation of saving or modifying a bib record. I'm taking of removing the "In Discussion" status in the hopes that somebody takes up writing a patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- biblioitems.marc is used by misc/cronjobs/MARC21_parse_test.pl. Does this script still used? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #4)
biblioitems.marc is used by misc/cronjobs/MARC21_parse_test.pl. Does this script still used?
I've never even heard of this script before, so I don't think that we use it. However, I suppose it's possible that someone uses it? Could we just remove the references to biblioitems.marc in this one script? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to David Cook from comment #5)
(In reply to Jonathan Druart from comment #4)
biblioitems.marc is used by misc/cronjobs/MARC21_parse_test.pl. Does this script still used?
I've never even heard of this script before, so I don't think that we use it. However, I suppose it's possible that someone uses it?
Could we just remove the references to biblioitems.marc in this one script?
Yes we could, if nobody uses the --fix option: 243 -f --fix Replace biblioitems.marcxml from data in marc field, default OFF -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #7 from Magnus Enger <magnus@libriotech.no> --- (In reply to Jonathan Druart from comment #6)
Yes we could, if nobody uses the --fix option:
243 -f --fix Replace biblioitems.marcxml from data in marc field, default OFF
The script was added in 2009 and not touched since: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=84ff3747b80d4291...
From the commit message:
"When marcxml cannot be parsed into a MARC::Record object, the biblio is undisplayable and it obviously breaks many features in Koha. This script can test to parse every marcxml, and alert on failures. Optionally, the marcxml can be replaced from the marc field." Didn't we at some point switch from treating marc (ISO2709) as the authoritative format, to treating marcxml as the authoritative format? I'd say loosing the ability to recreate marcxml from marc is no big deal. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tend to agree with Magnus - I am not sure that this script makes that much sense. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Just noticed that http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 is using biblioitems.marc as a string... that would block this bug... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #6)
(In reply to David Cook from comment #5)
(In reply to Jonathan Druart from comment #4)
biblioitems.marc is used by misc/cronjobs/MARC21_parse_test.pl. Does this script still used?
I've never even heard of this script before, so I don't think that we use it. However, I suppose it's possible that someone uses it?
Could we just remove the references to biblioitems.marc in this one script?
Yes we could, if nobody uses the --fix option:
243 -f --fix Replace biblioitems.marcxml from data in marc field, default OFF
I have just used it right now. For testing purpose I have removed the marcxml field. Using --fix, I was able to repopulate it from the marc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #10)
I have just used it right now. For testing purpose I have removed the marcxml field. Using --fix, I was able to repopulate it from the marc.
But why did you remove the marcxml field at all? :p -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to David Cook from comment #11)
(In reply to Jonathan Druart from comment #10)
I have just used it right now. For testing purpose I have removed the marcxml field. Using --fix, I was able to repopulate it from the marc.
But why did you remove the marcxml field at all? :p
I have no idea, really :D -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org