http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 11941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11941&action=edit Warning message triggered by clicking "Keywords to MARC mapping" To reproduce the warning: 1) Log in to staff client 2) Click 'Koha administration' 3) Click 'Keywords to MARC mapping' 4) Check koha-error_log [Mon Sep 03 09:51:45 2012] [error] [client 192.168.100.2] [Mon Sep 3 09:51:45 2012] fieldmapping.pl: Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/admin/fieldmapping.pl line 65., referer: https://.../cgi-bin/koha/admin/admin-home.pl Apply patch. No warning triggered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Tested in 3.6.3, but same patch should apply to 3.6.x, 3.8.x, and master. The attached patch is against master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11941|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11954&action=edit Bug 8713 - Warning message triggered by clicking Keywords to MARC mapping In the Koha Administration screen, clicking Keywords to MARC mapping triggered an uninitialized $op warning in the koha error logs. Added a "|| q{}" to ensure it is set. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #4 from Mason James <mtj@kohaaloha.com> ---

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

patch looks good, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 493b9c2 Bug 8713 - Warning message triggered by clicking Keywords to MARC admin/fieldmapping.pl * admin/fieldmapping.pl OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Tiny patch to silence some warns, pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.